From: Olaf Hering <olaf@aepfle.de>
To: Yang Zhang <yang.z.zhang@intel.com>
Cc: Andrew.Cooper3@citrix.com, kevin.tian@intel.com,
malcolm.crossley@citrix.com, JBeulich@suse.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH for 4.5 v2] vmx, apicv: fix save/restore issue with apicv
Date: Tue, 21 Oct 2014 12:36:49 +0200 [thread overview]
Message-ID: <20141021103649.GA31072@aepfle.de> (raw)
In-Reply-To: <1413869566-23391-1-git-send-email-yang.z.zhang@intel.com>
On Tue, Oct 21, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
>
> This patch fixes two issues:
>
> 1. Interrupts on PIR are lost during save/restore. Syncing the PIR
> into IRR during save will fix it.
>
> 2. EOI exit bitmap doesn't set up correctly after restore. Here we
> will construct the eoi exit bitmap via (IRR | ISR). Though it may cause
> unnecessary eoi exit of the interrupts that pending in IRR or ISR during
> save/restore, each pending interrupt only causes one vmexit. The
> subsequent interrupts will adjust the eoi exit bitmap correctly. So
> the performance hurt can be ignored.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> Hi Olaf and Malcolm, please help to retest this version.
Yes, this works as well. Thanks!
Olaf
next prev parent reply other threads:[~2014-10-21 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 5:32 [PATCH for 4.5 v2] vmx, apicv: fix save/restore issue with apicv Yang Zhang
2014-10-21 9:05 ` Jan Beulich
2014-10-24 2:00 ` Zhang, Yang Z
2014-10-24 9:11 ` Jan Beulich
2014-10-27 1:00 ` Zhang, Yang Z
2014-10-27 10:47 ` Andrew Cooper
2014-10-21 10:36 ` Olaf Hering [this message]
2014-10-28 6:38 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021103649.GA31072@aepfle.de \
--to=olaf@aepfle.de \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=malcolm.crossley@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.