From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback
Date: Tue, 21 Oct 2014 14:35:52 +0300 [thread overview]
Message-ID: <20141021113552.GA23316@redhat.com> (raw)
In-Reply-To: <1413890629.14632.19.camel@nilsson.home.kraxel.org>
On Tue, Oct 21, 2014 at 01:23:49PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > How about making "get_maintainer.pl --git-fallback" actually do what it
> > > says? Right now git it *not* used as fallback, it goes to git log
> > > unconditionally, even if there are hits in MAINTAINERS ...
> >
> > It does?
> >
> > How do you reproduce this behaviour?
> >
> > $ ./scripts/get_maintainer.pl -f vl.c
> > Anthony Liguori <aliguori@amazon.com> (supporter:Main loop)
> >
> > Seems to stop if it sees a maintainer.
>
> nilsson kraxel ~/projects/qemu (usb.work)# scripts/get_maintainer.pl -f
> ui/vnc.c
> Anthony Liguori <aliguori@amazon.com> (odd fixer:Graphics)
> Gerd Hoffmann <kraxel@redhat.com> (odd
> fixer:Graphics,commit_signer:21/24=88%)
> Peter Lieven <pl@kamp.de> (commit_signer:12/24=50%)
> Wenchao Xia <wenchaoqemu@gmail.com> (commit_signer:7/24=29%)
> Markus Armbruster <armbru@redhat.com> (commit_signer:3/24=12%)
> Luiz Capitulino <lcapitulino@redhat.com> (commit_signer:3/24=12%)
>
> Maybe it depends on maintainer status ...
>
> cheers,
> Gerd
>
Yes and that's a bug.
Thanks for the report.
Patch send, maybe that will be enough.
--
MST
next prev parent reply other threads:[~2014-10-21 11:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 9:19 [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback Markus Armbruster
2014-10-20 12:27 ` Don Slutz
2014-10-20 14:04 ` Peter Maydell
2014-10-20 14:15 ` Michael S. Tsirkin
2014-10-20 14:19 ` Peter Maydell
2014-10-20 19:03 ` Michael S. Tsirkin
2014-10-20 20:10 ` Don Slutz
2014-10-20 21:07 ` Peter Maydell
2014-10-21 9:31 ` Markus Armbruster
2014-10-21 10:00 ` Michael S. Tsirkin
2014-10-21 12:22 ` Markus Armbruster
2014-10-21 12:38 ` Michael S. Tsirkin
2014-10-21 13:29 ` Markus Armbruster
2014-10-21 22:30 ` Michael S. Tsirkin
2014-10-22 6:39 ` Markus Armbruster
2014-10-22 7:01 ` Michael S. Tsirkin
2014-10-22 8:10 ` Thomas Huth
2014-10-22 8:18 ` Michael S. Tsirkin
2014-10-20 18:38 ` Paolo Bonzini
2014-10-21 11:09 ` Gerd Hoffmann
2014-10-21 11:15 ` Michael S. Tsirkin
2014-10-21 11:23 ` Gerd Hoffmann
2014-10-21 11:35 ` Michael S. Tsirkin [this message]
2014-10-21 13:34 ` Markus Armbruster
2014-10-21 13:39 ` Paolo Bonzini
2014-10-21 13:46 ` Kirill Batuzov
2014-10-21 22:31 ` Michael S. Tsirkin
2014-10-22 7:01 ` Markus Armbruster
2014-10-22 7:12 ` Michael S. Tsirkin
2014-10-22 7:45 ` Paolo Bonzini
2014-10-22 8:03 ` Markus Armbruster
2014-10-22 8:29 ` Michael S. Tsirkin
2014-10-22 19:25 ` Don Slutz
2014-10-21 6:22 ` Thomas Huth
2014-10-21 9:19 ` Markus Armbruster
2014-10-21 13:40 ` Kirill Batuzov
2014-10-21 14:15 ` Markus Armbruster
2014-10-21 22:35 ` Michael S. Tsirkin
2014-10-20 15:06 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021113552.GA23316@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.