Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

[Don Slutz <dslutz@verizon.com>]

I am happy with this so:

Reviewed-by: Don Slutz <dslutz@verizon.com>

    -Don Slutz

On 10/20/14 05:19, Markus Armbruster wrote:
> Contributors rely on this script to find maintainers to copy.  The
> script falls back to git when no exact MAINTAINERS pattern matches.
> When that happens, recent contributors get copied, which tends not be
> particularly useful.  Some contributors find it even annoying.
>
> Flip the default to "don't fall back to git".  Use --git-fallback to
> ask it to fall back to git.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   scripts/get_maintainer.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 38334de..ec2d16f 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -28,7 +28,7 @@ my $email_git = 0;
>   my $email_git_all_signature_types = 0;
>   my $email_git_blame = 0;
>   my $email_git_blame_signatures = 1;
> -my $email_git_fallback = 1;
> +my $email_git_fallback = 0;
>   my $email_git_min_signatures = 1;
>   my $email_git_max_maintainers = 5;
>   my $email_git_min_percent = 5;