[PATCH 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

[PATCH 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

[Hans de Goede]

Reported (and tested) here:
https://bugzilla.redhat.com/show_bug.cgi?id=861573

Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/samsung-laptop.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 5a59665..ff765d8 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1561,6 +1561,16 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
 	},
 	{
 	 .callback = samsung_dmi_matched,
+	 .ident = "NC210",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "NC210/NC110"),
+		DMI_MATCH(DMI_BOARD_NAME, "NC210/NC110"),
+		},
+	 .driver_data = &samsung_broken_acpi_video,
+	},
+	{
+	 .callback = samsung_dmi_matched,
 	 .ident = "730U3E/740U3E",
 	 .matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
-- 
2.1.0

[PATCH 2/2] acer-wmi: Add acpi_backlight=video quirk for the Acer KAV80

[Hans de Goede]

https://bugzilla.redhat.com/show_bug.cgi?id=1128309

Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/platform/x86/acer-wmi.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 96a0b75..26c4fd1 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -579,6 +579,17 @@ static const struct dmi_system_id video_vendor_dmi_table[] __initconst = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5741"),
 		},
 	},
+	{
+		/*
+		 * Note no video_set_backlight_video_vendor, we must use the
+		 * acer interface, as there is no native backlight interface.
+		 */
+		.ident = "Acer KAV80",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "KAV80"),
+		},
+	},
 	{}
 };
 
-- 
2.1.0

Re: [PATCH 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

[Darren Hart]

On Thu, Oct 16, 2014 at 02:36:30PM +0200, Hans de Goede wrote:

Hi Hans,

Apoligies for the late response, travel and illness are taking their toll.

> Reported (and tested) here:
> https://bugzilla.redhat.com/show_bug.cgi?id=861573

The patch header is required to be sufficient to describe the problem and the
solution without depending on an external bugzilla or other reference.

Please include a complete git commit message.

> Cc: stable@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/platform/x86/samsung-laptop.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index 5a59665..ff765d8 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -1561,6 +1561,16 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
>  	},
>  	{
>  	 .callback = samsung_dmi_matched,
> +	 .ident = "NC210",
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "NC210/NC110"),
> +		DMI_MATCH(DMI_BOARD_NAME, "NC210/NC110"),
> +		},
> +	 .driver_data = &samsung_broken_acpi_video,
> +	},
> +	{
> +	 .callback = samsung_dmi_matched,
>  	 .ident = "730U3E/740U3E",
>  	 .matches = {
>  		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> -- 
> 2.1.0
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH 2/2] acer-wmi: Add acpi_backlight=video quirk for the Acer KAV80

[Darren Hart]

On Thu, Oct 16, 2014 at 02:36:31PM +0200, Hans de Goede wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1128309

Hi Hans,

As with 1/2, the content is fine, but please take the time to provide enough
context in the commit log that a reader of git log can understand what is going
on without requiring them to follow a bugzilla link.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center