All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wim Van Sebroeck <wim@iguana.be>,
	Lior Amsalem <alior@marvell.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-watchdog@vger.kernel.org,
	Tawfik Bayouk <tawfik@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] Make Armada 375 use the reference clock when possible
Date: Wed, 22 Oct 2014 15:55:18 +0200	[thread overview]
Message-ID: <20141022135518.GO9845@lunn.ch> (raw)
In-Reply-To: <1413984884-20273-1-git-send-email-ezequiel.garcia@free-electrons.com>

On Wed, Oct 22, 2014 at 10:34:40AM -0300, Ezequiel Garcia wrote:
> This series adds support for the 25 MHz reference clock available on
> Armada 375 SoC to use on the timer and watchdog drivers. It is
> similar to the one present in Armada XP SoC.
> 
> Given we initially had access to only a very early SoC revision (A375 Z0)
> and due to a hardware issue, the timer and watchdog support was originally
> submitted to use the core clock.

Hi Ezequiel

What happens with Z0 when used with these patches? Do they continue to
work? Do these hardware issues cause a problem?

> Now that the A0 SoC revision is out, we can fix this and use the reference
> clock. The reason for this change is that the core clock is subject to the
> SSCG, so boards where SSCG is enabled exhibit a very large timer drift.

It would of been nice to say what SSCG is. I had to go look it up.
However, since this is just in the cover note and not in the patches
itself, it is not important.

	Andrew

WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Make Armada 375 use the reference clock when possible
Date: Wed, 22 Oct 2014 15:55:18 +0200	[thread overview]
Message-ID: <20141022135518.GO9845@lunn.ch> (raw)
In-Reply-To: <1413984884-20273-1-git-send-email-ezequiel.garcia@free-electrons.com>

On Wed, Oct 22, 2014 at 10:34:40AM -0300, Ezequiel Garcia wrote:
> This series adds support for the 25 MHz reference clock available on
> Armada 375 SoC to use on the timer and watchdog drivers. It is
> similar to the one present in Armada XP SoC.
> 
> Given we initially had access to only a very early SoC revision (A375 Z0)
> and due to a hardware issue, the timer and watchdog support was originally
> submitted to use the core clock.

Hi Ezequiel

What happens with Z0 when used with these patches? Do they continue to
work? Do these hardware issues cause a problem?

> Now that the A0 SoC revision is out, we can fix this and use the reference
> clock. The reason for this change is that the core clock is subject to the
> SSCG, so boards where SSCG is enabled exhibit a very large timer drift.

It would of been nice to say what SSCG is. I had to go look it up.
However, since this is just in the cover note and not in the patches
itself, it is not important.

	Andrew

  parent reply	other threads:[~2014-10-22 13:56 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 13:34 [PATCH 0/4] Make Armada 375 use the reference clock when possible Ezequiel Garcia
2014-10-22 13:34 ` Ezequiel Garcia
2014-10-22 13:34 ` [PATCH 1/4] clocksource: armada-370-xp: Add missing clock enable Ezequiel Garcia
2014-10-22 13:34   ` Ezequiel Garcia
2014-10-22 13:50   ` Thomas Petazzoni
2014-10-22 13:50     ` Thomas Petazzoni
2014-10-22 14:37   ` Gregory CLEMENT
2014-10-22 14:37     ` Gregory CLEMENT
2014-10-22 13:34 ` [PATCH 2/4] watchdog: orion: Use the reference clock on Armada 375 SoC Ezequiel Garcia
2014-10-22 13:34   ` Ezequiel Garcia
2014-10-22 13:51   ` Thomas Petazzoni
2014-10-22 13:51     ` Thomas Petazzoni
2014-10-22 14:02   ` Andrew Lunn
2014-10-22 14:02     ` Andrew Lunn
2014-10-22 22:41     ` Ezequiel Garcia
2014-10-22 22:41       ` Ezequiel Garcia
2014-10-22 22:54       ` Guenter Roeck
2014-10-22 22:54         ` Guenter Roeck
2014-10-22 23:59       ` Andrew Lunn
2014-10-22 23:59         ` Andrew Lunn
2014-10-23  0:55         ` Ezequiel Garcia
2014-10-23  0:55           ` Ezequiel Garcia
2014-10-22 13:34 ` [PATCH 3/4] clocksource: armada-370-xp: Use the reference clock on A375 SoC Ezequiel Garcia
2014-10-22 13:34   ` Ezequiel Garcia
2014-10-22 13:54   ` Thomas Petazzoni
2014-10-22 13:54     ` Thomas Petazzoni
2014-10-22 15:22     ` Ezequiel Garcia
2014-10-22 15:22       ` Ezequiel Garcia
2014-10-22 13:34 ` [PATCH 4/4] ARM: dts: Enable the reference clock for timer and watchdog on Armada 375 SoC Ezequiel Garcia
2014-10-22 13:34   ` Ezequiel Garcia
2014-10-22 13:55   ` Thomas Petazzoni
2014-10-22 13:55     ` Thomas Petazzoni
2014-10-22 15:27     ` Ezequiel Garcia
2014-10-22 15:27       ` Ezequiel Garcia
2014-10-22 13:55 ` Andrew Lunn [this message]
2014-10-22 13:55   ` [PATCH 0/4] Make Armada 375 use the reference clock when possible Andrew Lunn
2014-10-22 13:56 ` Thomas Petazzoni
2014-10-22 13:56   ` Thomas Petazzoni
2014-10-22 14:08   ` Andrew Lunn
2014-10-22 14:08     ` Andrew Lunn
2014-10-22 14:25     ` Thomas Petazzoni
2014-10-22 14:25       ` Thomas Petazzoni
2014-10-22 15:29       ` Ezequiel Garcia
2014-10-22 15:29         ` Ezequiel Garcia
2014-10-23 12:36     ` Ezequiel Garcia
2014-10-23 12:36       ` Ezequiel Garcia
2014-10-23 12:16   ` Ezequiel Garcia
2014-10-23 12:16     ` Ezequiel Garcia
2014-10-23 12:26     ` Thomas Petazzoni
2014-10-23 12:26       ` Thomas Petazzoni
2014-10-23 12:43       ` Ezequiel Garcia
2014-10-23 12:43         ` Ezequiel Garcia
2014-11-03 21:29         ` Thomas Petazzoni
2014-11-03 21:29           ` Thomas Petazzoni
2014-10-22 14:43 ` Gregory CLEMENT
2014-10-22 14:43   ` Gregory CLEMENT
2014-10-22 14:49   ` Thomas Petazzoni
2014-10-22 14:49     ` Thomas Petazzoni
2014-10-22 15:10     ` Ezequiel Garcia
2014-10-22 15:10       ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141022135518.GO9845@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alior@marvell.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=nadavh@marvell.com \
    --cc=tawfik@marvell.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.