All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
	linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com,
	linux-api@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/3] kcmp: Move kcmp.h into uapi
Date: Thu, 23 Oct 2014 12:14:57 +0400	[thread overview]
Message-ID: <20141023081457.GE16267@moon> (raw)
In-Reply-To: <2940943.qiYEMaLEXx@wuerfel>

On Thu, Oct 23, 2014 at 09:49:14AM +0200, Arnd Bergmann wrote:
> On Thursday 23 October 2014 16:07:12 Michael Ellerman wrote:
> > --- a/include/linux/kcmp.h
> > +++ b/include/linux/kcmp.h
> > @@ -1,17 +1,6 @@
> >  #ifndef _LINUX_KCMP_H
> >  #define _LINUX_KCMP_H
> >  
> > -/* Comparison type */
> > -enum kcmp_type {
> > -       KCMP_FILE,
> > -       KCMP_VM,
> > -       KCMP_FILES,
> > -       KCMP_FS,
> > -       KCMP_SIGHAND,
> > -       KCMP_IO,
> > -       KCMP_SYSVSEM,
> > -
> > -       KCMP_TYPES,
> > -};
> > +#include <uapi/linux/kcmp.h>
> >  
> >  #endif /* _LINUX_KCMP_H */
> > 
> 
> If the file is empty except for the uapi include, I think it's better to
> delete it completely. The include path logic should ensure we pick the
> other one up.

Good point, somehow managed to miss this.

  reply	other threads:[~2014-10-23  8:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23  5:07 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman
2014-10-23  5:07 ` Michael Ellerman
     [not found] ` <1414040834-30209-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2014-10-23  5:07   ` [PATCH 2/3] selftests/kcmp: Don't include kernel headers Michael Ellerman
2014-10-23  5:07     ` Michael Ellerman
     [not found]     ` <1414040834-30209-2-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2014-10-23  6:05       ` Cyrill Gorcunov
2014-10-23  6:05         ` Cyrill Gorcunov
2014-10-23  6:04   ` [PATCH 1/3] kcmp: Move kcmp.h into uapi Cyrill Gorcunov
2014-10-23  6:04     ` Cyrill Gorcunov
2014-10-23  7:49   ` Arnd Bergmann
2014-10-23  7:49     ` Arnd Bergmann
2014-10-23  8:14     ` Cyrill Gorcunov [this message]
2014-12-01 16:57       ` Shuah Khan
2014-12-01 16:57         ` Shuah Khan
2014-11-28  2:18   ` Michael Ellerman
2014-11-28  2:18     ` Michael Ellerman
2014-12-01 17:00     ` Shuah Khan
2014-12-01 17:00       ` Shuah Khan
     [not found]       ` <547C9E92.8010606-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-12-02  5:36         ` Michael Ellerman
2014-12-02  5:36           ` Michael Ellerman
2014-10-23  5:07 ` [PATCH 3/3] selftests/kcmp: Always try to build the test Michael Ellerman
2014-10-23  5:07   ` Michael Ellerman
     [not found]   ` <1414040834-30209-3-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2014-10-23  6:09     ` Cyrill Gorcunov
2014-10-23  6:09       ` Cyrill Gorcunov
2014-12-02  5:53       ` Michael Ellerman
2014-12-02  5:53         ` Michael Ellerman
2014-10-23 13:06     ` Christopher Covington
2014-10-23 13:06       ` Christopher Covington
     [not found]       ` <5448FD72.9040301-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-10-23 13:52         ` Shuah Khan
2014-10-23 13:52           ` Shuah Khan
     [not found]           ` <54490832.7040906-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-12-01 16:58             ` Shuah Khan
2014-12-01 16:58               ` Shuah Khan
2014-12-02  5:44       ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2014-12-02  5:52 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141023081457.GE16267@moon \
    --to=gorcunov@gmail.com \
    --cc=akpm@osdl.org \
    --cc=arnd@arndb.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.