From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Christopher Covington
<cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 3/3] selftests/kcmp: Always try to build the test
Date: Thu, 23 Oct 2014 07:52:50 -0600 [thread overview]
Message-ID: <54490832.7040906@osg.samsung.com> (raw)
In-Reply-To: <5448FD72.9040301-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On 10/23/2014 07:06 AM, Christopher Covington wrote:
> Hi Michael,
>
> On 10/23/2014 01:07 AM, Michael Ellerman wrote:
>> Don't prevent the test building on non-x86. Just try and build it and
>> let the chips fall where they may.
>
> As a user of kcmp via CRIU on arm and arm64, thanks!
>
>> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
>> index 4f00c0524501..cda9cc4004c9 100644
>> --- a/tools/testing/selftests/kcmp/Makefile
>> +++ b/tools/testing/selftests/kcmp/Makefile
>> @@ -1,21 +1,7 @@
>> -uname_M := $(shell uname -m 2>/dev/null || echo not)
>> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
>> -ifeq ($(ARCH),i386)
>> - ARCH := x86
>> - CFLAGS := -DCONFIG_X86_32 -D__i386__
>> -endif
>> -ifeq ($(ARCH),x86_64)
>> - ARCH := x86
>> - CFLAGS := -DCONFIG_X86_64 -D__x86_64__
>> -endif
>> CFLAGS += -I../../../../usr/include/
>>
>> all:
>> -ifeq ($(ARCH),x86)
>> gcc $(CFLAGS) kcmp_test.c -o kcmp_test
>
> Not that this needs to be addressed in this patch, but this looks broken for
> cross compilation. It looks like some of the other selftests use:
>
> CC = $(CROSS_COMPILE)gcc
>
It makes sense to fix the cross-compile problem now, since
this patch is extending the support to other archs.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Christopher Covington <cov@codeaurora.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Andrew Morton <akpm@osdl.org>,
gorcunov@openvz.org
Subject: Re: [PATCH 3/3] selftests/kcmp: Always try to build the test
Date: Thu, 23 Oct 2014 07:52:50 -0600 [thread overview]
Message-ID: <54490832.7040906@osg.samsung.com> (raw)
In-Reply-To: <5448FD72.9040301@codeaurora.org>
On 10/23/2014 07:06 AM, Christopher Covington wrote:
> Hi Michael,
>
> On 10/23/2014 01:07 AM, Michael Ellerman wrote:
>> Don't prevent the test building on non-x86. Just try and build it and
>> let the chips fall where they may.
>
> As a user of kcmp via CRIU on arm and arm64, thanks!
>
>> diff --git a/tools/testing/selftests/kcmp/Makefile b/tools/testing/selftests/kcmp/Makefile
>> index 4f00c0524501..cda9cc4004c9 100644
>> --- a/tools/testing/selftests/kcmp/Makefile
>> +++ b/tools/testing/selftests/kcmp/Makefile
>> @@ -1,21 +1,7 @@
>> -uname_M := $(shell uname -m 2>/dev/null || echo not)
>> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
>> -ifeq ($(ARCH),i386)
>> - ARCH := x86
>> - CFLAGS := -DCONFIG_X86_32 -D__i386__
>> -endif
>> -ifeq ($(ARCH),x86_64)
>> - ARCH := x86
>> - CFLAGS := -DCONFIG_X86_64 -D__x86_64__
>> -endif
>> CFLAGS += -I../../../../usr/include/
>>
>> all:
>> -ifeq ($(ARCH),x86)
>> gcc $(CFLAGS) kcmp_test.c -o kcmp_test
>
> Not that this needs to be addressed in this patch, but this looks broken for
> cross compilation. It looks like some of the other selftests use:
>
> CC = $(CROSS_COMPILE)gcc
>
It makes sense to fix the cross-compile problem now, since
this patch is extending the support to other archs.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2014-10-23 13:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 5:07 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman
2014-10-23 5:07 ` Michael Ellerman
[not found] ` <1414040834-30209-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2014-10-23 5:07 ` [PATCH 2/3] selftests/kcmp: Don't include kernel headers Michael Ellerman
2014-10-23 5:07 ` Michael Ellerman
[not found] ` <1414040834-30209-2-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2014-10-23 6:05 ` Cyrill Gorcunov
2014-10-23 6:05 ` Cyrill Gorcunov
2014-10-23 6:04 ` [PATCH 1/3] kcmp: Move kcmp.h into uapi Cyrill Gorcunov
2014-10-23 6:04 ` Cyrill Gorcunov
2014-10-23 7:49 ` Arnd Bergmann
2014-10-23 7:49 ` Arnd Bergmann
2014-10-23 8:14 ` Cyrill Gorcunov
2014-12-01 16:57 ` Shuah Khan
2014-12-01 16:57 ` Shuah Khan
2014-11-28 2:18 ` Michael Ellerman
2014-11-28 2:18 ` Michael Ellerman
2014-12-01 17:00 ` Shuah Khan
2014-12-01 17:00 ` Shuah Khan
[not found] ` <547C9E92.8010606-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-12-02 5:36 ` Michael Ellerman
2014-12-02 5:36 ` Michael Ellerman
2014-10-23 5:07 ` [PATCH 3/3] selftests/kcmp: Always try to build the test Michael Ellerman
2014-10-23 5:07 ` Michael Ellerman
[not found] ` <1414040834-30209-3-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2014-10-23 6:09 ` Cyrill Gorcunov
2014-10-23 6:09 ` Cyrill Gorcunov
2014-12-02 5:53 ` Michael Ellerman
2014-12-02 5:53 ` Michael Ellerman
2014-10-23 13:06 ` Christopher Covington
2014-10-23 13:06 ` Christopher Covington
[not found] ` <5448FD72.9040301-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-10-23 13:52 ` Shuah Khan [this message]
2014-10-23 13:52 ` Shuah Khan
[not found] ` <54490832.7040906-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-12-01 16:58 ` Shuah Khan
2014-12-01 16:58 ` Shuah Khan
2014-12-02 5:44 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2014-12-02 5:52 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman
2014-12-02 5:52 ` [PATCH 3/3] selftests/kcmp: Always try to build the test Michael Ellerman
2014-12-02 16:20 ` Christopher Covington
2014-12-02 20:59 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54490832.7040906@osg.samsung.com \
--to=shuahkh-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
--cc=akpm-3NddpPZAyC0@public.gmane.org \
--cc=cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.