All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Covington <cov@codeaurora.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, shuahkh@osg.samsung.com,
	Andrew Morton <akpm@osdl.org>,
	gorcunov@openvz.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 3/3] selftests/kcmp: Always try to build the test
Date: Tue, 02 Dec 2014 11:20:40 -0500	[thread overview]
Message-ID: <547DE6D8.8090209@codeaurora.org> (raw)
In-Reply-To: <1417499528-23377-3-git-send-email-mpe@ellerman.id.au>

Hi Michael,

On 12/02/2014 12:52 AM, Michael Ellerman wrote:
> Don't prevent the test building on non-x86. Just try and build it and
> let the chips fall where they may.
> 
> Add support for CROSS_COMPILE while we're at it. Also we don't need a
> custom rule for building kcmp_test.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

For what it's worth, all three patches look good to me.

Reviewed-by: Christopher Covington <cov@codeaurora.org>

Thanks,
Chris

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2014-12-02 16:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02  5:52 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman
2014-12-02  5:52 ` [PATCH 2/3] selftests/kcmp: Don't include kernel headers Michael Ellerman
2014-12-02  5:52 ` [PATCH 3/3] selftests/kcmp: Always try to build the test Michael Ellerman
2014-12-02 16:20   ` Christopher Covington [this message]
2014-12-02 20:59     ` Shuah Khan
  -- strict thread matches above, loose matches on Subject: below --
2014-10-23  5:07 [PATCH 1/3] kcmp: Move kcmp.h into uapi Michael Ellerman
2014-10-23  5:07 ` [PATCH 3/3] selftests/kcmp: Always try to build the test Michael Ellerman
2014-10-23  5:07   ` Michael Ellerman
     [not found]   ` <1414040834-30209-3-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2014-10-23  6:09     ` Cyrill Gorcunov
2014-10-23  6:09       ` Cyrill Gorcunov
2014-12-02  5:53       ` Michael Ellerman
2014-12-02  5:53         ` Michael Ellerman
2014-10-23 13:06     ` Christopher Covington
2014-10-23 13:06       ` Christopher Covington
     [not found]       ` <5448FD72.9040301-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-10-23 13:52         ` Shuah Khan
2014-10-23 13:52           ` Shuah Khan
     [not found]           ` <54490832.7040906-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2014-12-01 16:58             ` Shuah Khan
2014-12-01 16:58               ` Shuah Khan
2014-12-02  5:44       ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547DE6D8.8090209@codeaurora.org \
    --to=cov@codeaurora.org \
    --cc=akpm@osdl.org \
    --cc=arnd@arndb.de \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.