From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports
Date: Thu, 23 Oct 2014 10:53:50 +0200 [thread overview]
Message-ID: <20141023085349.GA30381@lst.de> (raw)
In-Reply-To: <20141022165150.GA12809@quack.suse.cz>
On Wed, Oct 22, 2014 at 06:51:50PM +0200, Jan Kara wrote:
> So there are two reasons:
> 1) Currently if you call quotactl() with invalid quota type you'll get
> EINVAL. To maintain this with addition of project quotas you need to check
> the types early before calling check_quotactl_permission() and other
> checks.
>
> 2) I didn't want filesystem quotactl callbacks to deal with quota types
> they don't support. Sure each fs could do a type check in the callback but
> this looked easier.
>
> Now I see your point about s_dquot and I can move allowed_types out of
> s_dquot if that makes you happier. But otherwise what I did still seems as
> the best solution to me.
Moving it out of s_dquot seems very sensible to me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, cluster-devel@redhat.com,
Steven Whitehouse <swhiteho@redhat.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
Jeff Mahoney <jeffm@suse.de>, Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, tytso@mit.edu,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports
Date: Thu, 23 Oct 2014 10:53:50 +0200 [thread overview]
Message-ID: <20141023085349.GA30381@lst.de> (raw)
In-Reply-To: <20141022165150.GA12809@quack.suse.cz>
On Wed, Oct 22, 2014 at 06:51:50PM +0200, Jan Kara wrote:
> So there are two reasons:
> 1) Currently if you call quotactl() with invalid quota type you'll get
> EINVAL. To maintain this with addition of project quotas you need to check
> the types early before calling check_quotactl_permission() and other
> checks.
>
> 2) I didn't want filesystem quotactl callbacks to deal with quota types
> they don't support. Sure each fs could do a type check in the callback but
> this looked easier.
>
> Now I see your point about s_dquot and I can move allowed_types out of
> s_dquot if that makes you happier. But otherwise what I did still seems as
> the best solution to me.
Moving it out of s_dquot seems very sensible to me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, tytso@mit.edu,
Jeff Mahoney <jeffm@suse.de>, Mark Fasheh <mfasheh@suse.com>,
reiserfs-devel@vger.kernel.org, xfs@oss.sgi.com,
cluster-devel@redhat.com, Joel Becker <jlbec@evilplan.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Steven Whitehouse <swhiteho@redhat.com>,
ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports
Date: Thu, 23 Oct 2014 10:53:50 +0200 [thread overview]
Message-ID: <20141023085349.GA30381@lst.de> (raw)
In-Reply-To: <20141022165150.GA12809@quack.suse.cz>
On Wed, Oct 22, 2014 at 06:51:50PM +0200, Jan Kara wrote:
> So there are two reasons:
> 1) Currently if you call quotactl() with invalid quota type you'll get
> EINVAL. To maintain this with addition of project quotas you need to check
> the types early before calling check_quotactl_permission() and other
> checks.
>
> 2) I didn't want filesystem quotactl callbacks to deal with quota types
> they don't support. Sure each fs could do a type check in the callback but
> this looked easier.
>
> Now I see your point about s_dquot and I can move allowed_types out of
> s_dquot if that makes you happier. But otherwise what I did still seems as
> the best solution to me.
Moving it out of s_dquot seems very sensible to me.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, cluster-devel@redhat.com,
Steven Whitehouse <swhiteho@redhat.com>,
Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org,
Jeff Mahoney <jeffm@suse.de>, Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net, tytso@mit.edu,
viro@zeniv.linux.org.uk
Subject: [Ocfs2-devel] [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports
Date: Thu, 23 Oct 2014 10:53:50 +0200 [thread overview]
Message-ID: <20141023085349.GA30381@lst.de> (raw)
In-Reply-To: <20141022165150.GA12809@quack.suse.cz>
On Wed, Oct 22, 2014 at 06:51:50PM +0200, Jan Kara wrote:
> So there are two reasons:
> 1) Currently if you call quotactl() with invalid quota type you'll get
> EINVAL. To maintain this with addition of project quotas you need to check
> the types early before calling check_quotactl_permission() and other
> checks.
>
> 2) I didn't want filesystem quotactl callbacks to deal with quota types
> they don't support. Sure each fs could do a type check in the callback but
> this looked easier.
>
> Now I see your point about s_dquot and I can move allowed_types out of
> s_dquot if that makes you happier. But otherwise what I did still seems as
> the best solution to me.
Moving it out of s_dquot seems very sensible to me.
next prev parent reply other threads:[~2014-10-23 8:53 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 14:38 [Cluster-devel] [PATCH 0/12 v3] Moving i_dquot out of struct inode Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 01/12] quota: Remove const from function declarations Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-22 16:29 ` [Cluster-devel] " Christoph Hellwig
2014-10-22 16:29 ` [Ocfs2-devel] " Christoph Hellwig
2014-10-22 16:29 ` Christoph Hellwig
2014-10-22 16:29 ` Christoph Hellwig
2014-10-22 16:51 ` [Cluster-devel] " Jan Kara
2014-10-22 16:51 ` [Ocfs2-devel] " Jan Kara
2014-10-22 16:51 ` Jan Kara
2014-10-23 8:53 ` Christoph Hellwig [this message]
2014-10-23 8:53 ` [Ocfs2-devel] " Christoph Hellwig
2014-10-23 8:53 ` Christoph Hellwig
2014-10-23 8:53 ` Christoph Hellwig
2014-10-21 14:38 ` [Cluster-devel] [PATCH 03/12] gfs2: Set allowed quota types Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 04/12] xfs: " Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 05/12] quota: Use function to provide i_dquot pointers Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 06/12] ext2: Convert to private i_dquot field Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 07/12] ext3: " Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 08/12] ext4: " Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 09/12] ocfs2: " Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-23 10:25 ` [Cluster-devel] " Joel Becker
2014-10-23 10:25 ` [Ocfs2-devel] " Joel Becker
2014-10-23 10:25 ` Joel Becker
2014-10-23 10:25 ` Joel Becker
2014-10-23 12:05 ` [Cluster-devel] " Jan Kara
2014-10-23 12:05 ` [Ocfs2-devel] " Jan Kara
2014-10-23 12:05 ` Jan Kara
2014-10-23 12:05 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 10/12] reiserfs: " Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 11/12] jfs: " Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` [Cluster-devel] [PATCH 12/12] vfs: Remove i_dquot field from inode Jan Kara
2014-10-21 14:38 ` [Ocfs2-devel] " Jan Kara
2014-10-21 14:38 ` Jan Kara
2014-10-21 14:38 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 11:19 [Cluster-devel] [PATCH 0/12 v4] Moving i_dquot out of struct inode Jan Kara
2014-11-04 11:19 ` [Cluster-devel] [PATCH 02/12] quota: Allow each filesystem to specify which quota types it supports Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023085349.GA30381@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.