From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Hartmut Knaack <knaack.h@gmx.de>
Cc: Brian Vandre <bvandre@gmail.com>,
gregkh@linuxfoundation.org, jic23@kernel.org,
alexandre.belloni@free-electrons.com, linux-iio@vger.kernel.org,
marex@denx.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: iio: adc: fix line over 80 characters
Date: Thu, 23 Oct 2014 15:16:21 +0530 [thread overview]
Message-ID: <20141023094621.GA2253@sudip-PC> (raw)
In-Reply-To: <54484219.5000708@gmx.de>
On Thu, Oct 23, 2014 at 01:47:37AM +0200, Hartmut Knaack wrote:
> Sudip Mukherjee schrieb am 22.10.2014 06:21:
> > On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote:
> >> This fixes the 2 checkpatch.pl warnings:
> >> WARNING: line over 80 characters
> >>
> > please check your patch with --strict option of checkpatch.pl , and you will get :
> > "Alignment should match open parenthesis" .
> >
> Good point, but what solution would you propose?
when you are breaking the line , make a point to align the next line with the open parenthesis.
like :
- mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
+ mxs_lradc_reg_wrt(lradc,
+ LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
I have seen in many patches Greg commenting to resend the patch after aligning it.
so my opinion , even though it is optional , better to use it while sending a patch , so that no one can say about that.
happened to me in few of my initial patches. :)
> > thanks
> > sudip
> >
> >> Signed-off-by: Brian Vandre <bvandre@gmail.com>
> >> ---
> >> drivers/staging/iio/adc/mxs-lradc.c | 6 ++++--
> >> 1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> >> index 32a1926..62449a6 100644
> >> --- a/drivers/staging/iio/adc/mxs-lradc.c
> >> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> >> @@ -455,7 +455,8 @@ static void mxs_lradc_setup_ts_channel(struct mxs_lradc *lradc, unsigned ch)
> >> * SoC's delay unit and start the conversion later
> >> * and automatically.
> >> */
> >> - mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
> >> + mxs_lradc_reg_wrt(lradc,
> >> + LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
> >> LRADC_DELAY_TRIGGER_DELAYS(1 << 3) | /* trigger DELAY unit#3 */
> >> LRADC_DELAY_KICK |
> >> LRADC_DELAY_DELAY(lradc->settling_delay),
> >> @@ -513,7 +514,8 @@ static void mxs_lradc_setup_ts_pressure(struct mxs_lradc *lradc, unsigned ch1,
> >> * SoC's delay unit and start the conversion later
> >> * and automatically.
> >> */
> >> - mxs_lradc_reg_wrt(lradc, LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
> >> + mxs_lradc_reg_wrt(lradc,
> >> + LRADC_DELAY_TRIGGER(0) | /* don't trigger ADC */
> >> LRADC_DELAY_TRIGGER_DELAYS(1 << 3) | /* trigger DELAY unit#3 */
> >> LRADC_DELAY_KICK |
> >> LRADC_DELAY_DELAY(lradc->settling_delay), LRADC_DELAY(2));
> >> --
> >> 1.9.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at http://www.tux.org/lkml/
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
next prev parent reply other threads:[~2014-10-23 9:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 2:48 [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Brian Vandre
2014-10-21 2:48 ` [PATCH 1/2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-23 10:39 ` Daniel Baluta
2014-10-21 2:48 ` [PATCH 2/2] " Brian Vandre
2014-10-21 7:29 ` [PATCH 0/2] Staging: iio: adc: Checkpatch.pl warning cleanups Alexandre Belloni
2014-10-21 22:56 ` [PATCH v2] " Brian Vandre
2014-10-21 22:56 ` [PATCH v2] Staging: iio: adc: fix line over 80 characters Brian Vandre
2014-10-22 4:21 ` Sudip Mukherjee
2014-10-22 23:47 ` Hartmut Knaack
2014-10-23 2:02 ` Brian Vandre
2014-10-23 3:23 ` Joe Perches
2014-10-23 9:46 ` Sudip Mukherjee [this message]
2014-10-23 10:50 ` Lars-Peter Clausen
2014-10-23 12:42 ` Brian Vandre
2014-10-23 12:53 ` Brian Vandre
2014-10-23 13:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023094621.GA2253@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=bvandre@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.