* [PATCH] Make Octeon GPIO IRQ chip CPU hotplug-aware
@ 2014-10-23 13:55 Alexander Sverdlin
2014-10-23 15:59 ` David Daney
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Sverdlin @ 2014-10-23 13:55 UTC (permalink / raw)
To: ddaney.cavm, ralf, linux-mips
From: Alexander Sverdlin <alexander.sverdlin@nsn.com>
Make Octeon GPIO IRQ chip CPU hotplug-aware
Seems that irq_cpu_offline callbacks were forgotten in v1 and v2 CIU
GPIO chips. There is such a callback for octeon_irq_chip_ciu2_gpio,
covering CIU2 chips. Without this callback GPIO IRQs are not being migrated
during core offlining. Patch is tested on Octeon II.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nsn.com>
---
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -809,6 +809,7 @@ static struct irq_chip octeon_irq_chip_ciu_gpio_v2 = {
.irq_set_type = octeon_irq_ciu_gpio_set_type,
#ifdef CONFIG_SMP
.irq_set_affinity = octeon_irq_ciu_set_affinity_v2,
+ .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
#endif
.flags = IRQCHIP_SET_TYPE_MASKED,
};
@@ -823,6 +824,7 @@ static struct irq_chip octeon_irq_chip_ciu_gpio = {
.irq_set_type = octeon_irq_ciu_gpio_set_type,
#ifdef CONFIG_SMP
.irq_set_affinity = octeon_irq_ciu_set_affinity,
+ .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
#endif
.flags = IRQCHIP_SET_TYPE_MASKED,
};
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Make Octeon GPIO IRQ chip CPU hotplug-aware
2014-10-23 13:55 [PATCH] Make Octeon GPIO IRQ chip CPU hotplug-aware Alexander Sverdlin
@ 2014-10-23 15:59 ` David Daney
2014-10-23 16:41 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: David Daney @ 2014-10-23 15:59 UTC (permalink / raw)
To: Alexander Sverdlin; +Cc: ralf, linux-mips
On 10/23/2014 06:55 AM, Alexander Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nsn.com>
>
> Make Octeon GPIO IRQ chip CPU hotplug-aware
>
> Seems that irq_cpu_offline callbacks were forgotten in v1 and v2 CIU
> GPIO chips. There is such a callback for octeon_irq_chip_ciu2_gpio,
> covering CIU2 chips. Without this callback GPIO IRQs are not being migrated
> during core offlining. Patch is tested on Octeon II.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nsn.com>
Acked-by: David Daney <david.daney@cavium.com>
Ralf, please apply.
Thanks,
David Daney
>
> ---
> --- a/arch/mips/cavium-octeon/octeon-irq.c
> +++ b/arch/mips/cavium-octeon/octeon-irq.c
> @@ -809,6 +809,7 @@ static struct irq_chip octeon_irq_chip_ciu_gpio_v2 = {
> .irq_set_type = octeon_irq_ciu_gpio_set_type,
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity_v2,
> + .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> #endif
> .flags = IRQCHIP_SET_TYPE_MASKED,
> };
> @@ -823,6 +824,7 @@ static struct irq_chip octeon_irq_chip_ciu_gpio = {
> .irq_set_type = octeon_irq_ciu_gpio_set_type,
> #ifdef CONFIG_SMP
> .irq_set_affinity = octeon_irq_ciu_set_affinity,
> + .irq_cpu_offline = octeon_irq_cpu_offline_ciu,
> #endif
> .flags = IRQCHIP_SET_TYPE_MASKED,
> };
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Make Octeon GPIO IRQ chip CPU hotplug-aware
2014-10-23 15:59 ` David Daney
@ 2014-10-23 16:41 ` Ralf Baechle
0 siblings, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2014-10-23 16:41 UTC (permalink / raw)
To: David Daney; +Cc: Alexander Sverdlin, linux-mips
On Thu, Oct 23, 2014 at 08:59:08AM -0700, David Daney wrote:
> Date: Thu, 23 Oct 2014 08:59:08 -0700
> From: David Daney <ddaney.cavm@gmail.com>
> To: Alexander Sverdlin <alexander.sverdlin@nsn.com>
> CC: ralf@linux-mips.org, linux-mips@linux-mips.org
> Subject: Re: [PATCH] Make Octeon GPIO IRQ chip CPU hotplug-aware
> Content-Type: text/plain; charset=UTF-8; format=flowed
>
> On 10/23/2014 06:55 AM, Alexander Sverdlin wrote:
> >From: Alexander Sverdlin <alexander.sverdlin@nsn.com>
> >
> >Make Octeon GPIO IRQ chip CPU hotplug-aware
> >
> >Seems that irq_cpu_offline callbacks were forgotten in v1 and v2 CIU
> >GPIO chips. There is such a callback for octeon_irq_chip_ciu2_gpio,
> >covering CIU2 chips. Without this callback GPIO IRQs are not being migrated
> >during core offlining. Patch is tested on Octeon II.
> >
> >Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nsn.com>
>
> Acked-by: David Daney <david.daney@cavium.com>
>
> Ralf, please apply.
Already did that, so the commits won't have your ack.
Thanks for reviewing!
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-23 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 13:55 [PATCH] Make Octeon GPIO IRQ chip CPU hotplug-aware Alexander Sverdlin
2014-10-23 15:59 ` David Daney
2014-10-23 16:41 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.