From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Milosz Tanski <milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-aio-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Mel Gorman <mgorman-l3A5Bk7waGM@public.gmane.org>,
Volker Lendecke
<Volker.Lendecke-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jeff Moyer <jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michael Kerrisk
<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 4/4] vfs: RWF_NONBLOCK flag for preadv2
Date: Fri, 24 Oct 2014 02:40:47 -0700 [thread overview]
Message-ID: <20141024094047.GD29178@infradead.org> (raw)
In-Reply-To: <ba8d704a12c7ceffce610fc438a0af11a3422002.1413923420.git.milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org>
On Tue, Oct 21, 2014 at 04:46:59PM -0400, Milosz Tanski wrote:
> Filesystems that generic_file_read_iter will not be allowed to perform
> non-blocking reads. This only will read data if it's in the page cache and if
> there is no page error (causing a re-read).
I can't quite parse the first sentence, can you try to reword it?
> Christoph Hellwig wrote the filesystem specify code (cifs, ofs, shm, xfs).
s/specify/specific/. It's so trivial that I don't think it matters.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Milosz Tanski <milosz@adfin.com>
Cc: linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
Mel Gorman <mgorman@suse.de>,
Volker Lendecke <Volker.Lendecke@sernet.de>,
Tejun Heo <tj@kernel.org>, Jeff Moyer <jmoyer@redhat.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-api@vger.kernel.org,
Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH 4/4] vfs: RWF_NONBLOCK flag for preadv2
Date: Fri, 24 Oct 2014 02:40:47 -0700 [thread overview]
Message-ID: <20141024094047.GD29178@infradead.org> (raw)
In-Reply-To: <ba8d704a12c7ceffce610fc438a0af11a3422002.1413923420.git.milosz@adfin.com>
On Tue, Oct 21, 2014 at 04:46:59PM -0400, Milosz Tanski wrote:
> Filesystems that generic_file_read_iter will not be allowed to perform
> non-blocking reads. This only will read data if it's in the page cache and if
> there is no page error (causing a re-read).
I can't quite parse the first sentence, can you try to reword it?
> Christoph Hellwig wrote the filesystem specify code (cifs, ofs, shm, xfs).
s/specify/specific/. It's so trivial that I don't think it matters.
next prev parent reply other threads:[~2014-10-24 9:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 20:46 [PATCH 0/4] vfs: Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-10-21 20:46 ` Milosz Tanski
2014-10-21 20:46 ` [PATCH 1/4] vfs: Prepare for adding a new preadv/pwritev with user flags Milosz Tanski
2014-10-21 20:46 ` Milosz Tanski
2014-10-24 9:35 ` Christoph Hellwig
2014-10-24 9:35 ` Christoph Hellwig
2014-10-24 15:12 ` Jeff Moyer
2014-10-24 15:12 ` Jeff Moyer
2014-10-24 16:59 ` Milosz Tanski
2014-10-24 16:59 ` Milosz Tanski
2014-10-21 20:46 ` [PATCH 2/4] vfs: Define new syscalls preadv2,pwritev2 Milosz Tanski
2014-10-21 20:46 ` Milosz Tanski
2014-10-24 9:36 ` Christoph Hellwig
2014-10-24 9:36 ` Christoph Hellwig
2014-10-24 17:08 ` Milosz Tanski
2014-10-24 17:08 ` Milosz Tanski
2014-10-24 15:46 ` Jeff Moyer
2014-11-05 20:32 ` Milosz Tanski
2014-11-05 20:32 ` Milosz Tanski
2014-10-21 20:46 ` [PATCH 3/4] vfs: Export new vector IO syscalls (with flags) to userland Milosz Tanski
2014-10-21 20:46 ` Milosz Tanski
[not found] ` <e43b43c1e7b14b454b6425a650cd45cbb75fd325.1413923420.git.milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org>
2014-10-24 9:38 ` Christoph Hellwig
2014-10-24 9:38 ` Christoph Hellwig
2014-10-21 20:46 ` [PATCH 4/4] vfs: RWF_NONBLOCK flag for preadv2 Milosz Tanski
2014-10-21 20:46 ` Milosz Tanski
[not found] ` <ba8d704a12c7ceffce610fc438a0af11a3422002.1413923420.git.milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org>
2014-10-24 9:40 ` Christoph Hellwig [this message]
2014-10-24 9:40 ` Christoph Hellwig
2014-10-24 15:55 ` Jeff Moyer
2014-10-24 15:55 ` Jeff Moyer
2014-10-24 17:16 ` Milosz Tanski
2014-10-24 17:16 ` Milosz Tanski
2014-10-27 9:58 ` Christoph Hellwig
2014-10-27 9:58 ` Christoph Hellwig
2014-10-27 19:03 ` Steve French
2014-10-27 19:03 ` Steve French
2014-10-27 19:09 ` Milosz Tanski
2014-10-27 19:09 ` Milosz Tanski
2014-10-21 20:59 ` [PATCH] Add preadv2/pwritev2 documentation Milosz Tanski
2014-10-21 20:59 ` Milosz Tanski
2014-10-24 9:41 ` [PATCH 0/4] vfs: Non-blockling buffered fs read (page cache only) Christoph Hellwig
2014-10-24 9:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024094047.GD29178@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=Volker.Lendecke-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org \
--cc=jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-aio-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mgorman-l3A5Bk7waGM@public.gmane.org \
--cc=milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.