All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
	devicetree@vger.kernel.org, tony@atomide.com, j-keerthy@ti.com,
	nsekhar@ti.com, johan@kernel.org, balbi@ti.com, t-kristo@ti.com,
	linux-arm-kernel@lists.infradead.org, bcousson@baylibre.com,
	akpm@linux-foundation.org, linux-omap@vger.kernel.org,
	linux@roeck-us.net
Subject: Re: [PATCH V3 1/3] rtc: omap: use module_platform_driver
Date: Fri, 24 Oct 2014 10:38:17 -0500	[thread overview]
Message-ID: <20141024153817.GI26941@saruman> (raw)
In-Reply-To: <1414126425-13198-2-git-send-email-lokeshvutla@ti.com>


[-- Attachment #1.1: Type: text/plain, Size: 1675 bytes --]

On Fri, Oct 24, 2014 at 10:23:43AM +0530, Lokesh Vutla wrote:
> module_platform_driver_probe() prevents driver from requesting probe deferral.
> So using module_platform_drive() to support probe deferral.
> And also removing .owner field which is set by module_platform_driver.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  drivers/rtc/rtc-omap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index e74750f..d9bb5e7 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -477,7 +477,7 @@ static const struct of_device_id omap_rtc_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, omap_rtc_of_match);
>  
> -static int __init omap_rtc_probe(struct platform_device *pdev)
> +static int omap_rtc_probe(struct platform_device *pdev)
>  {
>  	struct omap_rtc	*rtc;
>  	struct resource	*res;
> @@ -708,18 +708,18 @@ static void omap_rtc_shutdown(struct platform_device *pdev)
>  }
>  
>  static struct platform_driver omap_rtc_driver = {
> +	.probe		= omap_rtc_probe,
>  	.remove		= __exit_p(omap_rtc_remove),
>  	.shutdown	= omap_rtc_shutdown,
>  	.driver		= {
>  		.name	= "omap_rtc",
> -		.owner	= THIS_MODULE,
>  		.pm	= &omap_rtc_pm_ops,
>  		.of_match_table = omap_rtc_of_match,
>  	},
>  	.id_table	= omap_rtc_id_table,
>  };
>  
> -module_platform_driver_probe(omap_rtc_driver, omap_rtc_probe);
> +module_platform_driver(omap_rtc_driver);
>  
>  MODULE_ALIAS("platform:omap_rtc");
>  MODULE_AUTHOR("George G. Davis (and others)");
> -- 
> 1.9.1
> 

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 1/3] rtc: omap: use module_platform_driver
Date: Fri, 24 Oct 2014 10:38:17 -0500	[thread overview]
Message-ID: <20141024153817.GI26941@saruman> (raw)
In-Reply-To: <1414126425-13198-2-git-send-email-lokeshvutla@ti.com>

On Fri, Oct 24, 2014 at 10:23:43AM +0530, Lokesh Vutla wrote:
> module_platform_driver_probe() prevents driver from requesting probe deferral.
> So using module_platform_drive() to support probe deferral.
> And also removing .owner field which is set by module_platform_driver.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  drivers/rtc/rtc-omap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index e74750f..d9bb5e7 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -477,7 +477,7 @@ static const struct of_device_id omap_rtc_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, omap_rtc_of_match);
>  
> -static int __init omap_rtc_probe(struct platform_device *pdev)
> +static int omap_rtc_probe(struct platform_device *pdev)
>  {
>  	struct omap_rtc	*rtc;
>  	struct resource	*res;
> @@ -708,18 +708,18 @@ static void omap_rtc_shutdown(struct platform_device *pdev)
>  }
>  
>  static struct platform_driver omap_rtc_driver = {
> +	.probe		= omap_rtc_probe,
>  	.remove		= __exit_p(omap_rtc_remove),
>  	.shutdown	= omap_rtc_shutdown,
>  	.driver		= {
>  		.name	= "omap_rtc",
> -		.owner	= THIS_MODULE,
>  		.pm	= &omap_rtc_pm_ops,
>  		.of_match_table = omap_rtc_of_match,
>  	},
>  	.id_table	= omap_rtc_id_table,
>  };
>  
> -module_platform_driver_probe(omap_rtc_driver, omap_rtc_probe);
> +module_platform_driver(omap_rtc_driver);
>  
>  MODULE_ALIAS("platform:omap_rtc");
>  MODULE_AUTHOR("George G. Davis (and others)");
> -- 
> 1.9.1
> 

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141024/6d30b913/attachment.sig>

  parent reply	other threads:[~2014-10-24 15:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24  4:53 [PATCH V3 0/3] rtc: omap: Add support for regulator supply Lokesh Vutla
2014-10-24  4:53 ` Lokesh Vutla
2014-10-24  4:53 ` [PATCH V3 1/3] rtc: omap: use module_platform_driver Lokesh Vutla
2014-10-24  4:53   ` Lokesh Vutla
2014-10-24  7:33   ` Johan Hovold
2014-10-24  7:33     ` Johan Hovold
2014-10-24 15:38   ` Felipe Balbi [this message]
2014-10-24 15:38     ` Felipe Balbi
2014-10-24  4:53 ` [PATCH V3 2/3] rtc: omap: Update Kconfig for OMAP RTC Lokesh Vutla
2014-10-24  4:53   ` Lokesh Vutla
2014-10-24  4:53 ` [PATCH V3 3/3] rtc: omap: Support regulator supply for RTC Lokesh Vutla
2014-10-24  4:53   ` Lokesh Vutla
2014-10-24  7:53   ` Johan Hovold
2014-10-24  7:53     ` Johan Hovold
2014-10-24  7:57     ` Lokesh Vutla
2014-10-24  7:57       ` Lokesh Vutla
2014-10-24 15:40     ` Felipe Balbi
2014-10-24 15:40       ` Felipe Balbi
2014-10-24  8:07   ` [PATCH V4 " Lokesh Vutla
2014-10-24  8:07     ` Lokesh Vutla
2014-10-24 15:40     ` Felipe Balbi
2014-10-24 15:40       ` Felipe Balbi
2014-10-24 13:26   ` [PATCH V3 " Nishanth Menon
2014-10-24 13:26     ` Nishanth Menon
2014-10-24 15:43     ` Felipe Balbi
2014-10-24 15:43       ` Felipe Balbi
2014-10-24 15:47       ` Nishanth Menon
2014-10-24 15:47         ` Nishanth Menon
2014-10-28  9:49     ` Lokesh Vutla
2014-10-28  9:49       ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141024153817.GI26941@saruman \
    --to=balbi@ti.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=johan@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lokeshvutla@ti.com \
    --cc=nsekhar@ti.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.