All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Rob Clark <robdclark@gmail.com>
Cc: lgirdwood@gmail.com,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>, David Brown <davidb@codeaurora.org>
Subject: Re: [PATCH] regulator: stub out devm_regulator_get_exclusive
Date: Sat, 25 Oct 2014 10:46:43 +0100	[thread overview]
Message-ID: <20141025094643.GQ3729@sirena.org.uk> (raw)
In-Reply-To: <CAF6AEGsDhv6V8ggOsLHgk6YgWEaL4iV1yX4qOdA_=KzCAWqR=w@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1017 bytes --]

On Fri, Oct 24, 2014 at 05:57:24PM -0400, Rob Clark wrote:

> Oh, you are only looking at the one in mdp4_kms_init(), which could
> possibly be a simple regulator_get().  Look instead at the ones in
> hdmi_init(), where I need to know whether to defer or not.  At one

No, I saw that - looking at the code in hdmi_init() it's using normal
devm_regulator_get() correctly (it appears to be open coding
devm_regulator_bulk_get() and likewise for the enables and disables but
that's a lot less serious).  I can't see anything actively broken with
that code other than the error handling on failed enable.

> point I was having a problem getting dummy regulators with
> regulator_get() but that could have been a symptom of another problem.
> I will re-try regulator_get() next time I am working on the kernel
> part of the driver..

It's a bug elsewhere, if you are getting a dummy regulator on a DT
system it means that you don't have a regulator set up for that supply
so the core is just assuming that it's always on.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
	lgirdwood@gmail.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	David Airlie <airlied@linux.ie>,
	David Brown <davidb@codeaurora.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] regulator: stub out devm_regulator_get_exclusive
Date: Sat, 25 Oct 2014 10:46:43 +0100	[thread overview]
Message-ID: <20141025094643.GQ3729@sirena.org.uk> (raw)
In-Reply-To: <CAF6AEGsDhv6V8ggOsLHgk6YgWEaL4iV1yX4qOdA_=KzCAWqR=w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Fri, Oct 24, 2014 at 05:57:24PM -0400, Rob Clark wrote:

> Oh, you are only looking at the one in mdp4_kms_init(), which could
> possibly be a simple regulator_get().  Look instead at the ones in
> hdmi_init(), where I need to know whether to defer or not.  At one

No, I saw that - looking at the code in hdmi_init() it's using normal
devm_regulator_get() correctly (it appears to be open coding
devm_regulator_bulk_get() and likewise for the enables and disables but
that's a lot less serious).  I can't see anything actively broken with
that code other than the error handling on failed enable.

> point I was having a problem getting dummy regulators with
> regulator_get() but that could have been a symptom of another problem.
> I will re-try regulator_get() next time I am working on the kernel
> part of the driver..

It's a bug elsewhere, if you are getting a dummy regulator on a DT
system it means that you don't have a regulator set up for that supply
so the core is just assuming that it's always on.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-10-25  9:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 19:15 [PATCH] regulator: stub out devm_regulator_get_exclusive Felipe Balbi
2014-10-24 19:15 ` Felipe Balbi
2014-10-24 19:20 ` Felipe Balbi
2014-10-24 19:20   ` Felipe Balbi
2014-10-24 20:11 ` Mark Brown
2014-10-24 20:18   ` Felipe Balbi
2014-10-24 20:18     ` Felipe Balbi
2014-10-24 20:58     ` Mark Brown
2014-10-24 20:36   ` Rob Clark
2014-10-24 20:36     ` Rob Clark
2014-10-24 21:18     ` Mark Brown
2014-10-24 21:57       ` Rob Clark
2014-10-24 21:57         ` Rob Clark
2014-10-25  9:46         ` Mark Brown [this message]
2014-10-25  9:46           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141025094643.GQ3729@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=balbi@ti.com \
    --cc=davidb@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.