All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: Theodore Ts'o <tytso@mit.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
	Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
	Fengguang Wu <fengguang.wu@intel.com>,
	lkp@01.org
Subject: Re: [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758 pagecache_isize_extended+0xdd/0x120()
Date: Mon, 27 Oct 2014 12:04:22 +1100	[thread overview]
Message-ID: <20141027010422.GA16186@dastard> (raw)
In-Reply-To: <20141016110127.GD6085@quack.suse.cz>

On Thu, Oct 16, 2014 at 01:01:27PM +0200, Jan Kara wrote:
> From de3426d6495f4b44b14c09b7c7202e9a86d864b9 Mon Sep 17 00:00:00 2001
> From: Jan Kara <jack@suse.cz>
> Date: Thu, 16 Oct 2014 12:58:42 +0200
> Subject: [PATCH] mm: Remove false WARN_ON from pagecache_isize_extended()
> 
> The WARN_ON checking whether i_mutex is held in
> pagecache_isize_extended() was wrong because some filesystems (e.g.
> XFS) use different locks for serialization of truncates / writes. So
> just remove the check.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  mm/truncate.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 261eaf6e5a19..c646084e5eec 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -755,7 +755,6 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
>  	struct page *page;
>  	pgoff_t index;
>  
> -	WARN_ON(!mutex_is_locked(&inode->i_mutex));
>  	WARN_ON(to > inode->i_size);
>  
>  	if (from >= to || bsize == PAGE_CACHE_SIZE)

Jan, Have you sent this patch upstream yet? I'm seeing it fire in
my testing in 3.18-rc1 kernels, so I was wondering what your plans
are for this...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: lkp@lists.01.org
Subject: Re: [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758 pagecache_isize_extended+0xdd/0x120()
Date: Mon, 27 Oct 2014 12:04:22 +1100	[thread overview]
Message-ID: <20141027010422.GA16186@dastard> (raw)
In-Reply-To: <20141016110127.GD6085@quack.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

On Thu, Oct 16, 2014 at 01:01:27PM +0200, Jan Kara wrote:
> From de3426d6495f4b44b14c09b7c7202e9a86d864b9 Mon Sep 17 00:00:00 2001
> From: Jan Kara <jack@suse.cz>
> Date: Thu, 16 Oct 2014 12:58:42 +0200
> Subject: [PATCH] mm: Remove false WARN_ON from pagecache_isize_extended()
> 
> The WARN_ON checking whether i_mutex is held in
> pagecache_isize_extended() was wrong because some filesystems (e.g.
> XFS) use different locks for serialization of truncates / writes. So
> just remove the check.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  mm/truncate.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 261eaf6e5a19..c646084e5eec 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -755,7 +755,6 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
>  	struct page *page;
>  	pgoff_t index;
>  
> -	WARN_ON(!mutex_is_locked(&inode->i_mutex));
>  	WARN_ON(to > inode->i_size);
>  
>  	if (from >= to || bsize == PAGE_CACHE_SIZE)

Jan, Have you sent this patch upstream yet? I'm seeing it fire in
my testing in 3.18-rc1 kernels, so I was wondering what your plans
are for this...

Cheers,

Dave.
-- 
Dave Chinner
david(a)fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>,
	Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758 pagecache_isize_extended+0xdd/0x120()
Date: Mon, 27 Oct 2014 12:04:22 +1100	[thread overview]
Message-ID: <20141027010422.GA16186@dastard> (raw)
In-Reply-To: <20141016110127.GD6085@quack.suse.cz>

On Thu, Oct 16, 2014 at 01:01:27PM +0200, Jan Kara wrote:
> From de3426d6495f4b44b14c09b7c7202e9a86d864b9 Mon Sep 17 00:00:00 2001
> From: Jan Kara <jack@suse.cz>
> Date: Thu, 16 Oct 2014 12:58:42 +0200
> Subject: [PATCH] mm: Remove false WARN_ON from pagecache_isize_extended()
> 
> The WARN_ON checking whether i_mutex is held in
> pagecache_isize_extended() was wrong because some filesystems (e.g.
> XFS) use different locks for serialization of truncates / writes. So
> just remove the check.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  mm/truncate.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/truncate.c b/mm/truncate.c
> index 261eaf6e5a19..c646084e5eec 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -755,7 +755,6 @@ void pagecache_isize_extended(struct inode *inode, loff_t from, loff_t to)
>  	struct page *page;
>  	pgoff_t index;
>  
> -	WARN_ON(!mutex_is_locked(&inode->i_mutex));
>  	WARN_ON(to > inode->i_size);
>  
>  	if (from >= to || bsize == PAGE_CACHE_SIZE)

Jan, Have you sent this patch upstream yet? I'm seeing it fire in
my testing in 3.18-rc1 kernels, so I was wondering what your plans
are for this...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2014-10-27  1:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 10:09 [vfs] WARNING: CPU: 3 PID: 2339 at mm/truncate.c:758 pagecache_isize_extended+0xdd/0x120() Fengguang Wu
2014-10-16 10:34 ` Fengguang Wu
2014-10-16 10:09 ` Fengguang Wu
2014-10-16 11:01 ` Jan Kara
2014-10-16 11:01   ` Jan Kara
2014-10-16 11:01   ` Jan Kara
2014-10-27  1:04   ` Dave Chinner [this message]
2014-10-27  1:04     ` Dave Chinner
2014-10-27  1:04     ` Dave Chinner
2014-10-27  9:58     ` Jan Kara
2014-10-27  9:58       ` Jan Kara
2014-10-27  9:58       ` Jan Kara
2014-10-27 21:05       ` Dave Chinner
2014-10-27 21:05         ` Dave Chinner
2014-10-27 21:05         ` Dave Chinner
2014-10-28  1:14         ` Xiong Zhou
2014-10-28  1:14           ` Xiong Zhou
2014-10-28  1:14           ` Xiong Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141027010422.GA16186@dastard \
    --to=david@fromorbit.com \
    --cc=fengguang.wu@intel.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=tytso@mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.