* [PATCH] which-2.18: Make sure ChangeLog exists for automake
@ 2014-10-27 9:44 jackie.huang
2014-10-27 9:52 ` Martin Jansa
0 siblings, 1 reply; 5+ messages in thread
From: jackie.huang @ 2014-10-27 9:44 UTC (permalink / raw)
To: openembedded-core
From: Jackie Huang <jackie.huang@windriver.com>
Fixed:
Makefile.am: error: required file './ChangeLog' not found
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
meta/recipes-extended/which/which_2.18.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/recipes-extended/which/which_2.18.bb b/meta/recipes-extended/which/which_2.18.bb
index 5fa5d9e..49e9248 100644
--- a/meta/recipes-extended/which/which_2.18.bb
+++ b/meta/recipes-extended/which/which_2.18.bb
@@ -25,6 +25,9 @@ do_configure_prepend() {
OLD="@ACLOCAL_CWFLAGS@"
NEW="-I ${STAGING_DIR_NATIVE}/${datadir}/cwautomacros/m4"
sed -i "s#${OLD}#${NEW}#g" `grep -rl ${OLD} ${S}`
+
+ # Make sure ChangeLog exists for automake
+ touch ${S}/ChangeLog
}
ALTERNATIVE_${PN} = "which"
--
2.0.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] which-2.18: Make sure ChangeLog exists for automake
2014-10-27 9:44 [PATCH] which-2.18: Make sure ChangeLog exists for automake jackie.huang
@ 2014-10-27 9:52 ` Martin Jansa
2014-10-27 10:52 ` Burton, Ross
2014-10-28 1:36 ` Huang, Jie (Jackie)
0 siblings, 2 replies; 5+ messages in thread
From: Martin Jansa @ 2014-10-27 9:52 UTC (permalink / raw)
To: jackie.huang; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
On Mon, Oct 27, 2014 at 05:44:42AM -0400, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
>
> Fixed:
> Makefile.am: error: required file './ChangeLog' not found
Isn't it better to pass foreign to automake?
>
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
> meta/recipes-extended/which/which_2.18.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-extended/which/which_2.18.bb b/meta/recipes-extended/which/which_2.18.bb
> index 5fa5d9e..49e9248 100644
> --- a/meta/recipes-extended/which/which_2.18.bb
> +++ b/meta/recipes-extended/which/which_2.18.bb
> @@ -25,6 +25,9 @@ do_configure_prepend() {
> OLD="@ACLOCAL_CWFLAGS@"
> NEW="-I ${STAGING_DIR_NATIVE}/${datadir}/cwautomacros/m4"
> sed -i "s#${OLD}#${NEW}#g" `grep -rl ${OLD} ${S}`
> +
> + # Make sure ChangeLog exists for automake
> + touch ${S}/ChangeLog
> }
>
> ALTERNATIVE_${PN} = "which"
> --
> 2.0.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] which-2.18: Make sure ChangeLog exists for automake
2014-10-27 9:52 ` Martin Jansa
@ 2014-10-27 10:52 ` Burton, Ross
2014-10-28 2:03 ` Huang, Jie (Jackie)
2014-10-28 1:36 ` Huang, Jie (Jackie)
1 sibling, 1 reply; 5+ messages in thread
From: Burton, Ross @ 2014-10-27 10:52 UTC (permalink / raw)
To: Martin Jansa; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On 27 October 2014 09:52, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Mon, Oct 27, 2014 at 05:44:42AM -0400, jackie.huang@windriver.com
> wrote:
> > From: Jackie Huang <jackie.huang@windriver.com>
> >
> > Fixed:
> > Makefile.am: error: required file './ChangeLog' not found
>
> Isn't it better to pass foreign to automake?
Yes, and talk to upstream to understand why this isn't a problem. Some
upstreams are unaware of autoreconf and continue using home-grown tools.
Ross
[-- Attachment #2: Type: text/html, Size: 990 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] which-2.18: Make sure ChangeLog exists for automake
2014-10-27 9:52 ` Martin Jansa
2014-10-27 10:52 ` Burton, Ross
@ 2014-10-28 1:36 ` Huang, Jie (Jackie)
1 sibling, 0 replies; 5+ messages in thread
From: Huang, Jie (Jackie) @ 2014-10-28 1:36 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core@lists.openembedded.org
> -----Original Message-----
> From: Martin Jansa [mailto:martin.jansa@gmail.com]
> Sent: Monday, October 27, 2014 5:53 PM
> To: Huang, Jie (Jackie)
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] which-2.18: Make sure ChangeLog exists for automake
>
> On Mon, Oct 27, 2014 at 05:44:42AM -0400, jackie.huang@windriver.com wrote:
> > From: Jackie Huang <jackie.huang@windriver.com>
> >
> > Fixed:
> > Makefile.am: error: required file './ChangeLog' not found
>
> Isn't it better to pass foreign to automake?
Yes, it's better, I will change it, thanks!
Thanks,
Jackie
>
> >
> > Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> > ---
> > meta/recipes-extended/which/which_2.18.bb | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-extended/which/which_2.18.bb b/meta/recipes-
> extended/which/which_2.18.bb
> > index 5fa5d9e..49e9248 100644
> > --- a/meta/recipes-extended/which/which_2.18.bb
> > +++ b/meta/recipes-extended/which/which_2.18.bb
> > @@ -25,6 +25,9 @@ do_configure_prepend() {
> > OLD="@ACLOCAL_CWFLAGS@"
> > NEW="-I ${STAGING_DIR_NATIVE}/${datadir}/cwautomacros/m4"
> > sed -i "s#${OLD}#${NEW}#g" `grep -rl ${OLD} ${S}`
> > +
> > + # Make sure ChangeLog exists for automake
> > + touch ${S}/ChangeLog
> > }
> >
> > ALTERNATIVE_${PN} = "which"
> > --
> > 2.0.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] which-2.18: Make sure ChangeLog exists for automake
2014-10-27 10:52 ` Burton, Ross
@ 2014-10-28 2:03 ` Huang, Jie (Jackie)
0 siblings, 0 replies; 5+ messages in thread
From: Huang, Jie (Jackie) @ 2014-10-28 2:03 UTC (permalink / raw)
To: BURTON, ROSS, Martin Jansa; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
The upstream seems not active any more, the home page (http://carlo17.home.xs4all.nl/which/) is dead,
and the last update in cvs is 6 years ago: http://cvs.savannah.gnu.org/viewvc/which/?root=which
I will add a path with upstream-status inappropriate.
Thanks,
Jackie
From: Burton, Ross [mailto:ross.burton@intel.com]
Sent: Monday, October 27, 2014 6:52 PM
To: Martin Jansa
Cc: Huang, Jie (Jackie); OE-core
Subject: Re: [OE-core] [PATCH] which-2.18: Make sure ChangeLog exists for automake
On 27 October 2014 09:52, Martin Jansa <martin.jansa@gmail.com<mailto:martin.jansa@gmail.com>> wrote:
On Mon, Oct 27, 2014 at 05:44:42AM -0400, jackie.huang@windriver.com<mailto:jackie.huang@windriver.com> wrote:
> From: Jackie Huang <jackie.huang@windriver.com<mailto:jackie.huang@windriver.com>>
>
> Fixed:
> Makefile.am: error: required file './ChangeLog' not found
Isn't it better to pass foreign to automake?
Yes, and talk to upstream to understand why this isn't a problem. Some upstreams are unaware of autoreconf and continue using home-grown tools.
Ross
[-- Attachment #2: Type: text/html, Size: 5138 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-28 2:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-27 9:44 [PATCH] which-2.18: Make sure ChangeLog exists for automake jackie.huang
2014-10-27 9:52 ` Martin Jansa
2014-10-27 10:52 ` Burton, Ross
2014-10-28 2:03 ` Huang, Jie (Jackie)
2014-10-28 1:36 ` Huang, Jie (Jackie)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.