From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 03/10] regulator: act8865: Use of_is_system_power_controller helper function
Date: Mon, 27 Oct 2014 11:40:22 -0500 [thread overview]
Message-ID: <20141027164022.GC14253@saruman> (raw)
In-Reply-To: <1414427215-14380-3-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On Mon, Oct 27, 2014 at 04:26:48PM +0000, Romain Perier wrote:
> Signed-off-by: Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/regulator/act8865-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
> index 76301ed..435aba1 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
> return ret;
> }
>
> - if (of_system_has_poweroff_source(dev->of_node)) {
> + if (of_is_system_power_controller(dev->of_node)) {
so building this driver is broken until this patch ? not very good
either.
Looks to me you should add of_is_system_power_controller without remove
of_system_has_poweroff_source() until all users of that have been
converted over.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 03/10] regulator: act8865: Use of_is_system_power_controller helper function
Date: Mon, 27 Oct 2014 11:40:22 -0500 [thread overview]
Message-ID: <20141027164022.GC14253@saruman> (raw)
In-Reply-To: <1414427215-14380-3-git-send-email-romain.perier@gmail.com>
On Mon, Oct 27, 2014 at 04:26:48PM +0000, Romain Perier wrote:
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> drivers/regulator/act8865-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
> index 76301ed..435aba1 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
> return ret;
> }
>
> - if (of_system_has_poweroff_source(dev->of_node)) {
> + if (of_is_system_power_controller(dev->of_node)) {
so building this driver is broken until this patch ? not very good
either.
Looks to me you should add of_is_system_power_controller without remove
of_system_has_poweroff_source() until all users of that have been
converted over.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/f6c2b806/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Romain Perier <romain.perier@gmail.com>
Cc: <heiko@sntech.de>, <devicetree@vger.kernel.org>,
<broonie@kernel.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <grant.likely@linaro.org>,
<robh@kernel.org>, <mark.rutland@arm.com>, <johan@kernel.org>,
<linux-pm@vger.kernel.org>, <linux@roeck-us.net>,
<lee.jones@linaro.org>, <balbi@ti.com>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <linux@arm.linux.org.uk>,
<swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
<gnurou@gmail.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v1 03/10] regulator: act8865: Use of_is_system_power_controller helper function
Date: Mon, 27 Oct 2014 11:40:22 -0500 [thread overview]
Message-ID: <20141027164022.GC14253@saruman> (raw)
In-Reply-To: <1414427215-14380-3-git-send-email-romain.perier@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Mon, Oct 27, 2014 at 04:26:48PM +0000, Romain Perier wrote:
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> ---
> drivers/regulator/act8865-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
> index 76301ed..435aba1 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -365,7 +365,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
> return ret;
> }
>
> - if (of_system_has_poweroff_source(dev->of_node)) {
> + if (of_is_system_power_controller(dev->of_node)) {
so building this driver is broken until this patch ? not very good
either.
Looks to me you should add of_is_system_power_controller without remove
of_system_has_poweroff_source() until all users of that have been
converted over.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-27 16:40 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 16:26 [PATCH v1 01/10] of: Rename "poweroff-source" property to "system-power-controller" Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:26 ` [PATCH v1 02/10] dt-bindings: Document the standard property "system-power-controller" Romain Perier
2014-10-27 16:26 ` Romain Perier
[not found] ` <1414427215-14380-2-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-27 16:39 ` Felipe Balbi
2014-10-27 16:39 ` Felipe Balbi
2014-10-27 16:39 ` Felipe Balbi
2014-10-27 17:26 ` Mark Brown
2014-10-27 17:26 ` Mark Brown
2014-10-27 17:26 ` Mark Brown
2014-10-27 17:30 ` Felipe Balbi
2014-10-27 17:30 ` Felipe Balbi
2014-10-27 17:30 ` Felipe Balbi
2014-10-27 17:57 ` Mark Brown
2014-10-27 17:57 ` Mark Brown
2014-10-28 7:25 ` Romain Perier
2014-10-28 7:25 ` Romain Perier
2014-10-28 7:25 ` Romain Perier
2014-10-27 16:26 ` [PATCH v1 03/10] regulator: act8865: Use of_is_system_power_controller helper function Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:26 ` Romain Perier
[not found] ` <1414427215-14380-3-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-27 16:40 ` Felipe Balbi [this message]
2014-10-27 16:40 ` Felipe Balbi
2014-10-27 16:40 ` Felipe Balbi
2014-10-27 17:03 ` Heiko Stübner
2014-10-27 17:03 ` Heiko Stübner
2014-10-27 17:03 ` Heiko Stübner
2014-10-27 16:26 ` [PATCH v2 04/10] ARM: dts: rockchip: Enable power off in pmic for Radxa Rock Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:26 ` [PATCH v1 05/10] dt-bindings: act8865: Update documentation about property system-power-controller Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:26 ` [PATCH v2 06/10] mfd: tps65910: Use the standard DT " Romain Perier
2014-10-27 16:26 ` Romain Perier
[not found] ` <1414427215-14380-6-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-27 16:35 ` Lucas Stach
2014-10-27 16:35 ` Lucas Stach
2014-10-27 16:35 ` Lucas Stach
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:43 ` Johan Hovold
2014-10-27 16:43 ` Johan Hovold
2014-10-27 16:53 ` Romain Perier
2014-10-27 16:53 ` Romain Perier
2014-10-27 16:49 ` Heiko Stübner
2014-10-27 16:49 ` Heiko Stübner
2014-10-27 16:49 ` Felipe Balbi
2014-10-27 16:49 ` Felipe Balbi
2014-10-27 16:49 ` Felipe Balbi
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:41 ` Felipe Balbi
2014-10-27 16:26 ` [PATCH v2 07/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 apalis Romain Perier
2014-10-27 16:26 ` Romain Perier
[not found] ` <1414427215-14380-7-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-27 16:42 ` Felipe Balbi
2014-10-27 16:42 ` Felipe Balbi
2014-10-27 16:42 ` Felipe Balbi
2014-10-28 4:34 ` Alexandre Courbot
2014-10-28 4:34 ` Alexandre Courbot
2014-10-28 4:34 ` Alexandre Courbot
2014-10-28 6:47 ` Romain Perier
2014-10-28 6:47 ` Romain Perier
2014-10-28 6:47 ` Romain Perier
2014-10-27 16:26 ` [PATCH v2 08/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 beaver Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:42 ` Felipe Balbi
2014-10-27 16:42 ` Felipe Balbi
2014-10-27 16:42 ` Felipe Balbi
2014-10-27 16:26 ` [PATCH v2 09/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 cardhu Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:26 ` [PATCH v2 10/10] ARM: dts: tegra: Use standard power-off property in tps65911 for tegra30 colibri Romain Perier
2014-10-27 16:26 ` Romain Perier
2014-10-27 16:38 ` [PATCH v1 01/10] of: Rename "poweroff-source" property to "system-power-controller" Felipe Balbi
2014-10-27 16:38 ` Felipe Balbi
2014-10-27 16:38 ` Felipe Balbi
2014-10-27 16:41 ` Johan Hovold
2014-10-27 16:41 ` Johan Hovold
2014-10-27 16:47 ` Felipe Balbi
2014-10-27 16:47 ` Felipe Balbi
2014-10-27 16:47 ` Felipe Balbi
2014-10-27 17:02 ` Johan Hovold
2014-10-27 17:02 ` Johan Hovold
2014-10-27 17:02 ` Johan Hovold
2014-10-27 17:05 ` Heiko Stübner
2014-10-27 17:05 ` Heiko Stübner
2014-10-27 17:08 ` Felipe Balbi
2014-10-27 17:08 ` Felipe Balbi
2014-10-27 17:08 ` Felipe Balbi
2014-10-27 17:16 ` Johan Hovold
2014-10-27 17:16 ` Johan Hovold
2014-10-27 18:16 ` Romain Perier
2014-10-27 18:16 ` Romain Perier
2014-10-27 18:16 ` Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027164022.GC14253@saruman \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.