[PATCH v2 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

[PATCH v2 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

[Hans de Goede]

The acpi-video backlight interface on the NC210 does not work, blacklist it
and use the samsung-laptop interface instead.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=861573
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

--
Changes in v2: Improve commit message
---
 drivers/platform/x86/samsung-laptop.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 5a59665..ff765d8 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1561,6 +1561,16 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
 	},
 	{
 	 .callback = samsung_dmi_matched,
+	 .ident = "NC210",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "NC210/NC110"),
+		DMI_MATCH(DMI_BOARD_NAME, "NC210/NC110"),
+		},
+	 .driver_data = &samsung_broken_acpi_video,
+	},
+	{
+	 .callback = samsung_dmi_matched,
 	 .ident = "730U3E/740U3E",
 	 .matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
-- 
2.1.0

[PATCH v2 2/2] acer-wmi: Add acpi_backlight=video quirk for the Acer KAV80

[Hans de Goede]

The acpi-video backlight interface on the Acer KAV80 is broken, and worse
it causes the entire machine to slow down significantly after a suspend/resume.

Blacklist it, and use the acer-wmi backlight interface instead. Note that
the KAV80 is somewhat unique in that it is the only Acer model where we
fall back to acer-wmi after blacklisting, rather then using the native
(e.g. intel) backlight driver. This is done because there is no native
backlight interface on this model.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1128309
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

--
Changes in v2: Improve commit message
---
 drivers/platform/x86/acer-wmi.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 96a0b75..26c4fd1 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -579,6 +579,17 @@ static const struct dmi_system_id video_vendor_dmi_table[] __initconst = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5741"),
 		},
 	},
+	{
+		/*
+		 * Note no video_set_backlight_video_vendor, we must use the
+		 * acer interface, as there is no native backlight interface.
+		 */
+		.ident = "Acer KAV80",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "KAV80"),
+		},
+	},
 	{}
 };
 
-- 
2.1.0

Re: [PATCH v2 2/2] acer-wmi: Add acpi_backlight=video quirk for the Acer KAV80

[Darren Hart]

On Wed, Oct 22, 2014 at 04:06:38PM +0200, Hans de Goede wrote:
> The acpi-video backlight interface on the Acer KAV80 is broken, and worse
> it causes the entire machine to slow down significantly after a suspend/resume.
> 
> Blacklist it, and use the acer-wmi backlight interface instead. Note that
> the KAV80 is somewhat unique in that it is the only Acer model where we
> fall back to acer-wmi after blacklisting, rather then using the native
> (e.g. intel) backlight driver. This is done because there is no native
> backlight interface on this model.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1128309
> Cc: stable@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> --
> Changes in v2: Improve commit message

Queued, thanks Hans.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH v2 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

[Darren Hart]

On Wed, Oct 22, 2014 at 04:06:37PM +0200, Hans de Goede wrote:
> The acpi-video backlight interface on the NC210 does not work, blacklist it
> and use the samsung-laptop interface instead.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=861573
> Cc: stable@vger.kernel.org
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> --
> Changes in v2: Improve commit message

Queued, thanks Hans.

(In the future, please use my infradead email address for submissions as
 documented in MAINTAINERS. Kernel patches to dvhart.com will be lost)

-- 
Darren Hart
Intel Open Source Technology Center