* [PATCH] Don't enable F00F workaround on Intel Quark processors.
@ 2014-10-28 17:57 Dave Jones
2014-10-28 18:33 ` [tip:x86/urgent] x86: Don' t " tip-bot for Dave Jones
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dave Jones @ 2014-10-28 17:57 UTC (permalink / raw)
To: Linux Kernel; +Cc: x86, Bryan O'Donoghue
The Intel Quark processor is a part of family 5, but does not have the
F00F bug present in Pentiums of the same family.
Pentiums were models 0 through 8, Quark is model 9.
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 1ef456273172..9cc6b6f25f42 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -213,12 +213,13 @@ static void intel_workarounds(struct cpuinfo_x86 *c)
{
#ifdef CONFIG_X86_F00F_BUG
/*
- * All current models of Pentium and Pentium with MMX technology CPUs
+ * All models of Pentium and Pentium with MMX technology CPUs
* have the F0 0F bug, which lets nonprivileged users lock up the
* system. Announce that the fault handler will be checking for it.
+ * The Quark is also family 5, but does not have the same bug.
*/
clear_cpu_bug(c, X86_BUG_F00F);
- if (!paravirt_enabled() && c->x86 == 5) {
+ if (!paravirt_enabled() && c->x86 == 5 && c->x86_model < 9) {
static int f00f_workaround_enabled;
set_cpu_bug(c, X86_BUG_F00F);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [tip:x86/urgent] x86: Don' t enable F00F workaround on Intel Quark processors
2014-10-28 17:57 [PATCH] Don't enable F00F workaround on Intel Quark processors Dave Jones
@ 2014-10-28 18:33 ` tip-bot for Dave Jones
2014-10-29 0:02 ` [PATCH] Don't " Bryan O'Donoghue
2014-10-29 9:10 ` [tip:x86/urgent] x86: Don' t " tip-bot for Dave Jones
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Dave Jones @ 2014-10-28 18:33 UTC (permalink / raw)
To: linux-tip-commits; +Cc: davej, hpa, linux-kernel, tglx, pure.logic, mingo
Commit-ID: c1dd2d38a55119e1611a9ea3ee30bcf8902e2b04
Gitweb: http://git.kernel.org/tip/c1dd2d38a55119e1611a9ea3ee30bcf8902e2b04
Author: Dave Jones <davej@redhat.com>
AuthorDate: Tue, 28 Oct 2014 13:57:53 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 28 Oct 2014 19:31:23 +0100
x86: Don't enable F00F workaround on Intel Quark processors
The Intel Quark processor is a part of family 5, but does not have the
F00F bug present in Pentiums of the same family.
Pentiums were models 0 through 8, Quark is model 9.
Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Link: http://lkml.kernel.org/r/20141028175753.GA12743@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/cpu/intel.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 1ef4562..9cc6b6f 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -213,12 +213,13 @@ static void intel_workarounds(struct cpuinfo_x86 *c)
{
#ifdef CONFIG_X86_F00F_BUG
/*
- * All current models of Pentium and Pentium with MMX technology CPUs
+ * All models of Pentium and Pentium with MMX technology CPUs
* have the F0 0F bug, which lets nonprivileged users lock up the
* system. Announce that the fault handler will be checking for it.
+ * The Quark is also family 5, but does not have the same bug.
*/
clear_cpu_bug(c, X86_BUG_F00F);
- if (!paravirt_enabled() && c->x86 == 5) {
+ if (!paravirt_enabled() && c->x86 == 5 && c->x86_model < 9) {
static int f00f_workaround_enabled;
set_cpu_bug(c, X86_BUG_F00F);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Don't enable F00F workaround on Intel Quark processors.
2014-10-28 17:57 [PATCH] Don't enable F00F workaround on Intel Quark processors Dave Jones
2014-10-28 18:33 ` [tip:x86/urgent] x86: Don' t " tip-bot for Dave Jones
@ 2014-10-29 0:02 ` Bryan O'Donoghue
2014-10-29 9:10 ` [tip:x86/urgent] x86: Don' t " tip-bot for Dave Jones
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2014-10-29 0:02 UTC (permalink / raw)
To: Dave Jones, Linux Kernel, x86
On 28/10/14 17:57, Dave Jones wrote:
> The Intel Quark processor is a part of family 5, but does not have the
> F00F bug present in Pentiums of the same family.
>
> Pentiums were models 0 through 8, Quark is model 9.
Tested - works, F00F removed from list of bugs in /proc/cpuinfo
BOD
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86: Don' t enable F00F workaround on Intel Quark processors
2014-10-28 17:57 [PATCH] Don't enable F00F workaround on Intel Quark processors Dave Jones
2014-10-28 18:33 ` [tip:x86/urgent] x86: Don' t " tip-bot for Dave Jones
2014-10-29 0:02 ` [PATCH] Don't " Bryan O'Donoghue
@ 2014-10-29 9:10 ` tip-bot for Dave Jones
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Dave Jones @ 2014-10-29 9:10 UTC (permalink / raw)
To: linux-tip-commits; +Cc: hpa, linux-kernel, pure.logic, davej, mingo, tglx
Commit-ID: d4e1a0af1d3a88cdfc8c954d3005eb8745ec518d
Gitweb: http://git.kernel.org/tip/d4e1a0af1d3a88cdfc8c954d3005eb8745ec518d
Author: Dave Jones <davej@redhat.com>
AuthorDate: Tue, 28 Oct 2014 13:57:53 -0400
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 29 Oct 2014 08:52:09 +0100
x86: Don't enable F00F workaround on Intel Quark processors
The Intel Quark processor is a part of family 5, but does not have the
F00F bug present in Pentiums of the same family.
Pentiums were models 0 through 8, Quark is model 9.
Signed-off-by: Dave Jones <davej@redhat.com>
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Link: http://lkml.kernel.org/r/20141028175753.GA12743@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/intel.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index 1ef4562..9cc6b6f 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -213,12 +213,13 @@ static void intel_workarounds(struct cpuinfo_x86 *c)
{
#ifdef CONFIG_X86_F00F_BUG
/*
- * All current models of Pentium and Pentium with MMX technology CPUs
+ * All models of Pentium and Pentium with MMX technology CPUs
* have the F0 0F bug, which lets nonprivileged users lock up the
* system. Announce that the fault handler will be checking for it.
+ * The Quark is also family 5, but does not have the same bug.
*/
clear_cpu_bug(c, X86_BUG_F00F);
- if (!paravirt_enabled() && c->x86 == 5) {
+ if (!paravirt_enabled() && c->x86 == 5 && c->x86_model < 9) {
static int f00f_workaround_enabled;
set_cpu_bug(c, X86_BUG_F00F);
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-29 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28 17:57 [PATCH] Don't enable F00F workaround on Intel Quark processors Dave Jones
2014-10-28 18:33 ` [tip:x86/urgent] x86: Don' t " tip-bot for Dave Jones
2014-10-29 0:02 ` [PATCH] Don't " Bryan O'Donoghue
2014-10-29 9:10 ` [tip:x86/urgent] x86: Don' t " tip-bot for Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.