* [patch] goldfish: off by one in goldfish_tty_console_setup()
@ 2014-10-29 8:43 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-10-29 8:43 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-kernel, kernel-janitors
The goldfish_ttys[] array has "goldfish_tty_line_count" number of
elements. It's allocated in goldfish_tty_create_driver(). This test
should be >= instead of >.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index 09495f5..2f68540 100644
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -155,7 +155,7 @@ static struct tty_driver *goldfish_tty_console_device(struct console *c,
static int goldfish_tty_console_setup(struct console *co, char *options)
{
- if ((unsigned)co->index > goldfish_tty_line_count)
+ if ((unsigned)co->index >= goldfish_tty_line_count)
return -ENODEV;
if (goldfish_ttys[co->index].base = 0)
return -ENODEV;
^ permalink raw reply related [flat|nested] 2+ messages in thread* [patch] goldfish: off by one in goldfish_tty_console_setup()
@ 2014-10-29 8:43 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-10-29 8:43 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-kernel, kernel-janitors
The goldfish_ttys[] array has "goldfish_tty_line_count" number of
elements. It's allocated in goldfish_tty_create_driver(). This test
should be >= instead of >.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index 09495f5..2f68540 100644
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -155,7 +155,7 @@ static struct tty_driver *goldfish_tty_console_device(struct console *c,
static int goldfish_tty_console_setup(struct console *co, char *options)
{
- if ((unsigned)co->index > goldfish_tty_line_count)
+ if ((unsigned)co->index >= goldfish_tty_line_count)
return -ENODEV;
if (goldfish_ttys[co->index].base == 0)
return -ENODEV;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-29 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-29 8:43 [patch] goldfish: off by one in goldfish_tty_console_setup() Dan Carpenter
2014-10-29 8:43 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.