All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
	Michal Kazior <michal.kazior@tieto.com>,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: handle ieee80211 header and payload tracing separately
Date: Thu, 30 Oct 2014 14:54:09 +0530	[thread overview]
Message-ID: <20141030092408.GA20221@qca.qualcomm.com> (raw)
In-Reply-To: <1414595144.1827.5.camel@jlt4.sipsolutions.net>

On Wed, Oct 29, 2014 at 04:05:44PM +0100, Johannes Berg wrote:
> On Wed, 2014-10-29 at 19:39 +0530, Rajkumar Manoharan wrote:
> 
> > +	u32 hdr_len = ieee80211_hdrlen(hdr->frame_control);
> 
> > +	trace_ath10k_rx_hdr(ar, hdr, hdr_len);
> > +	trace_ath10k_rx_payload(ar, skb->data + hdr_len, skb->len - hdr_len);
> 
> Another note, since you're taking my suggestion :-)
> 
> It would be worth hiding that inside the tracepoint's assign function,
> so instead of passing data/len here you'd pass the full skb, or the full
> skb data/skb len, like this:
> 
> ar, skb->data, skb->len
> 
> to both tracers. Then inside the tracer you can do the hdrlen check, and
> that way move the code into the tracing so it's not hit when tracing is
> disabled.
> 
Nice. Let me send v2. Thanks once again.

-Rajkumar

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	"Michal Kazior" <michal.kazior@tieto.com>
Subject: Re: [PATCH] ath10k: handle ieee80211 header and payload tracing separately
Date: Thu, 30 Oct 2014 14:54:09 +0530	[thread overview]
Message-ID: <20141030092408.GA20221@qca.qualcomm.com> (raw)
In-Reply-To: <1414595144.1827.5.camel@jlt4.sipsolutions.net>

On Wed, Oct 29, 2014 at 04:05:44PM +0100, Johannes Berg wrote:
> On Wed, 2014-10-29 at 19:39 +0530, Rajkumar Manoharan wrote:
> 
> > +	u32 hdr_len = ieee80211_hdrlen(hdr->frame_control);
> 
> > +	trace_ath10k_rx_hdr(ar, hdr, hdr_len);
> > +	trace_ath10k_rx_payload(ar, skb->data + hdr_len, skb->len - hdr_len);
> 
> Another note, since you're taking my suggestion :-)
> 
> It would be worth hiding that inside the tracepoint's assign function,
> so instead of passing data/len here you'd pass the full skb, or the full
> skb data/skb len, like this:
> 
> ar, skb->data, skb->len
> 
> to both tracers. Then inside the tracer you can do the hdrlen check, and
> that way move the code into the tracing so it's not hit when tracing is
> disabled.
> 
Nice. Let me send v2. Thanks once again.

-Rajkumar

  reply	other threads:[~2014-10-30  9:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 14:09 [PATCH] ath10k: handle ieee80211 header and payload tracing separately Rajkumar Manoharan
2014-10-29 14:09 ` Rajkumar Manoharan
2014-10-29 15:05 ` Johannes Berg
2014-10-29 15:05   ` Johannes Berg
2014-10-30  9:24   ` Rajkumar Manoharan [this message]
2014-10-30  9:24     ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141030092408.GA20221@qca.qualcomm.com \
    --to=rmanohar@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.