From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Wim Van Sebroeck <wim@iguana.be>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: at91rm9200: allow building when using device tree
Date: Thu, 30 Oct 2014 16:17:19 +0100 [thread overview]
Message-ID: <20141030151719.GG17398@piout.net> (raw)
In-Reply-To: <2000678.14fQbcst9s@wuerfel>
On 30/10/2014 at 15:43:43 +0100, Arnd Bergmann wrote :
> On Thursday 30 October 2014 15:36:24 Boris Brezillon wrote:
> > On Thu, 30 Oct 2014 15:15:34 +0100
> > Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> >
> > > When building with device tree, ARCH_AT91RM9200 may not be selected. Allow
> > > building that driver by also depending on ARCH_AT91.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >
>
> Doesn't this reintroduce the bug fixed by commit 09549cd0172 ("watchdog:
> Revert the AT91RM9200_WATCHDOG dependency")?
>
> At least in 3.18-rc2, the driver still uses at91_st_write/at91_st_read.
>
Hum, right, then we have no better way to express that than depends on
SOC_AT91RM9200, would that be acceptable ?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] watchdog: at91rm9200: allow building when using device tree
Date: Thu, 30 Oct 2014 16:17:19 +0100 [thread overview]
Message-ID: <20141030151719.GG17398@piout.net> (raw)
In-Reply-To: <2000678.14fQbcst9s@wuerfel>
On 30/10/2014 at 15:43:43 +0100, Arnd Bergmann wrote :
> On Thursday 30 October 2014 15:36:24 Boris Brezillon wrote:
> > On Thu, 30 Oct 2014 15:15:34 +0100
> > Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> >
> > > When building with device tree, ARCH_AT91RM9200 may not be selected. Allow
> > > building that driver by also depending on ARCH_AT91.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> >
>
> Doesn't this reintroduce the bug fixed by commit 09549cd0172 ("watchdog:
> Revert the AT91RM9200_WATCHDOG dependency")?
>
> At least in 3.18-rc2, the driver still uses at91_st_write/at91_st_read.
>
Hum, right, then we have no better way to express that than depends on
SOC_AT91RM9200, would that be acceptable ?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-30 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 14:15 [PATCH] watchdog: at91rm9200: allow building when using device tree Alexandre Belloni
2014-10-30 14:15 ` Alexandre Belloni
2014-10-30 14:36 ` Boris Brezillon
2014-10-30 14:36 ` Boris Brezillon
2014-10-30 14:43 ` Arnd Bergmann
2014-10-30 14:43 ` Arnd Bergmann
2014-10-30 15:17 ` Alexandre Belloni [this message]
2014-10-30 15:17 ` Alexandre Belloni
2014-10-30 15:43 ` Arnd Bergmann
2014-10-30 15:43 ` Arnd Bergmann
2014-10-30 16:20 ` Alexandre Belloni
2014-10-30 16:20 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030151719.GG17398@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.