From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: fix a typo of instruction operand
Date: Thu, 30 Oct 2014 17:58:35 +0100 [thread overview]
Message-ID: <20141030175835.5f227dcb@lilith> (raw)
In-Reply-To: <CAHwEcmZfHGxsEtjof-hyeC6FE+i2MAEEvwfk0nuQLJoOX38AYw@mail.gmail.com>
Hello Jethro,
On Thu, 30 Oct 2014 19:27:41 +0800, Jethro Hsu <cchsu77@gmail.com>
wrote:
> From 79344f479bad75b47477dcc9768e564e02f72f59 Mon Sep 17 00:00:00 2001
> From: Jethro Hsu <cchsu77@gmail.com>
> Date: Thu, 30 Oct 2014 17:26:00 +0800
> Subject: [PATCH] arm: fix a typo of instruction operand
>
> To fix compile error caused by incorrect data format,
> add "0x" to specify the operand value in hex mode.
>
> error message:
>
> arch/arm/lib/gic_64.S: Assembler messages:
> arch/arm/lib/gic_64.S:187: Error: unexpected characters
> following instruction at operand 3 -- `and w9,w9,#3ff'
>
> Change-Id: Ifef22c6d9a0f6a4255b3f2daf96bef08db6731dc
> Signed-off-by: Jethro Hsu <cchsu77@gmail.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Arnab Basu <arnab.basu@freescale.com>
> Cc: David Feng <fenghua@phytium.com.cn>
> Cc: York Sun <yorksun@freescale.com>
> Cc: Scott Wood <scottwood@freescale.com>
> ---
> arch/arm/include/asm/macro.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/macro.h b/arch/arm/include/asm/macro.h
> index 541b443..1c8c425 100644
> --- a/arch/arm/include/asm/macro.h
> +++ b/arch/arm/include/asm/macro.h
> @@ -193,7 +193,7 @@ lr .req x30
> 0 : wfi
> ldr \wreg2, [\xreg1, GICC_AIAR]
> str \wreg2, [\xreg1, GICC_AEOIR]
> - and \wreg2, \wreg2, #3ff
> + and \wreg2, \wreg2, #0x3ff
> cbnz \wreg2, 0b
> .endm
> #endif
> --
> 1.8.3.1
This was fixed already in u-boot-arm/master (currently top of tree,
soon to merge into u-boot/master.
Amicalement,
--
Albert.
prev parent reply other threads:[~2014-10-30 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 11:27 [U-Boot] [PATCH] arm: fix a typo of instruction operand Jethro Hsu
2014-10-30 16:58 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030175835.5f227dcb@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.