* [U-Boot] [PATCH] arm: fix a typo of instruction operand
2014-10-30 11:27 [U-Boot] [PATCH] arm: fix a typo of instruction operand Jethro Hsu
@ 2014-10-30 16:58 ` Albert ARIBAUD
0 siblings, 0 replies; 2+ messages in thread
From: Albert ARIBAUD @ 2014-10-30 16:58 UTC (permalink / raw)
To: u-boot
Hello Jethro,
On Thu, 30 Oct 2014 19:27:41 +0800, Jethro Hsu <cchsu77@gmail.com>
wrote:
> From 79344f479bad75b47477dcc9768e564e02f72f59 Mon Sep 17 00:00:00 2001
> From: Jethro Hsu <cchsu77@gmail.com>
> Date: Thu, 30 Oct 2014 17:26:00 +0800
> Subject: [PATCH] arm: fix a typo of instruction operand
>
> To fix compile error caused by incorrect data format,
> add "0x" to specify the operand value in hex mode.
>
> error message:
>
> arch/arm/lib/gic_64.S: Assembler messages:
> arch/arm/lib/gic_64.S:187: Error: unexpected characters
> following instruction at operand 3 -- `and w9,w9,#3ff'
>
> Change-Id: Ifef22c6d9a0f6a4255b3f2daf96bef08db6731dc
> Signed-off-by: Jethro Hsu <cchsu77@gmail.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Arnab Basu <arnab.basu@freescale.com>
> Cc: David Feng <fenghua@phytium.com.cn>
> Cc: York Sun <yorksun@freescale.com>
> Cc: Scott Wood <scottwood@freescale.com>
> ---
> arch/arm/include/asm/macro.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/macro.h b/arch/arm/include/asm/macro.h
> index 541b443..1c8c425 100644
> --- a/arch/arm/include/asm/macro.h
> +++ b/arch/arm/include/asm/macro.h
> @@ -193,7 +193,7 @@ lr .req x30
> 0 : wfi
> ldr \wreg2, [\xreg1, GICC_AIAR]
> str \wreg2, [\xreg1, GICC_AEOIR]
> - and \wreg2, \wreg2, #3ff
> + and \wreg2, \wreg2, #0x3ff
> cbnz \wreg2, 0b
> .endm
> #endif
> --
> 1.8.3.1
This was fixed already in u-boot-arm/master (currently top of tree,
soon to merge into u-boot/master.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 2+ messages in thread