From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
Cc: Corentin LABBE
<clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
crope-X3B1VOXEql0@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator
Date: Fri, 31 Oct 2014 09:13:23 +0100 [thread overview]
Message-ID: <20141031081323.GS21251@lukather> (raw)
In-Reply-To: <20141031072030.GA7563-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Fri, Oct 31, 2014 at 03:20:30PM +0800, Herbert Xu wrote:
> On Thu, Oct 30, 2014 at 06:19:33PM +0100, Maxime Ripard wrote:
> >
> > > With AF_ALG and cryptodev, the SG is in highmem. Verified with some
> > > PageHighMem().
> >
> > Then fix AF_ALG and cryptodev, because all of the other drivers might
> > be affected.
>
> No it's the driver that needs to be fixed. Of course if there
> are enough drivers it may be worthwhile adding either copying or
> a software fallback for highmem requests.
I don't understand here. Why would other drivers *not* being affected?
If the scatter list passed by AF_ALG can be in highmem, I guess it's
the case for every driver out there. Almost every kernel code I've
seen so far makes the assumption that the memory it has is mapped and
accessible.
Somehow, it's the driver's fault now, and not the part of kernel that
actually does the allocation?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator
Date: Fri, 31 Oct 2014 09:13:23 +0100 [thread overview]
Message-ID: <20141031081323.GS21251@lukather> (raw)
In-Reply-To: <20141031072030.GA7563@gondor.apana.org.au>
On Fri, Oct 31, 2014 at 03:20:30PM +0800, Herbert Xu wrote:
> On Thu, Oct 30, 2014 at 06:19:33PM +0100, Maxime Ripard wrote:
> >
> > > With AF_ALG and cryptodev, the SG is in highmem. Verified with some
> > > PageHighMem().
> >
> > Then fix AF_ALG and cryptodev, because all of the other drivers might
> > be affected.
>
> No it's the driver that needs to be fixed. Of course if there
> are enough drivers it may be worthwhile adding either copying or
> a software fallback for highmem requests.
I don't understand here. Why would other drivers *not* being affected?
If the scatter list passed by AF_ALG can be in highmem, I guess it's
the case for every driver out there. Almost every kernel code I've
seen so far makes the assumption that the memory it has is mapped and
accessible.
Somehow, it's the driver's fault now, and not the part of kernel that
actually does the allocation?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141031/552452fb/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Corentin LABBE <clabbe.montjoie@gmail.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, davem@davemloft.net,
grant.likely@linaro.org, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, joe@perches.com,
mchehab@osg.samsung.com, crope@iki.fi,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator
Date: Fri, 31 Oct 2014 09:13:23 +0100 [thread overview]
Message-ID: <20141031081323.GS21251@lukather> (raw)
In-Reply-To: <20141031072030.GA7563@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Fri, Oct 31, 2014 at 03:20:30PM +0800, Herbert Xu wrote:
> On Thu, Oct 30, 2014 at 06:19:33PM +0100, Maxime Ripard wrote:
> >
> > > With AF_ALG and cryptodev, the SG is in highmem. Verified with some
> > > PageHighMem().
> >
> > Then fix AF_ALG and cryptodev, because all of the other drivers might
> > be affected.
>
> No it's the driver that needs to be fixed. Of course if there
> are enough drivers it may be worthwhile adding either copying or
> a software fallback for highmem requests.
I don't understand here. Why would other drivers *not* being affected?
If the scatter list passed by AF_ALG can be in highmem, I guess it's
the case for every driver out there. Almost every kernel code I've
seen so far makes the assumption that the memory it has is mapped and
accessible.
Somehow, it's the driver's fault now, and not the part of kernel that
actually does the allocation?
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-31 8:13 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 14:16 [PATCH v5] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
[not found] ` <1413728182-13569-1-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-19 14:16 ` [PATCH v5 1/4] ARM: sun7i: dt: Add Security System to A20 SoC DTS LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-19 14:16 ` [PATCH v5 2/4] ARM: sunxi: dt: Add DT bindings documentation for SUNXI Security System LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
[not found] ` <1413728182-13569-3-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-20 12:02 ` Koen Kooi
2014-10-20 12:02 ` [linux-sunxi] " Koen Kooi
2014-10-20 12:02 ` Koen Kooi
2014-10-19 14:16 ` [PATCH v5 3/4] MAINTAINERS: Add myself as maintainer of Allwinner " LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-19 14:16 ` [PATCH v5 4/4] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-19 14:16 ` LABBE Corentin
2014-10-20 23:28 ` Vladimir Zapolskiy
2014-10-20 23:28 ` Vladimir Zapolskiy
2014-10-20 23:52 ` Joe Perches
2014-10-20 23:52 ` Joe Perches
[not found] ` <1413849173.5407.6.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2014-10-21 16:39 ` Corentin LABBE
2014-10-21 16:39 ` Corentin LABBE
2014-10-21 16:39 ` Corentin LABBE
[not found] ` <54459AA5.2030705-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
2014-10-21 16:25 ` Corentin LABBE
2014-10-21 16:25 ` Corentin LABBE
2014-10-21 16:25 ` Corentin LABBE
[not found] ` <54468902.1040802-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-21 17:27 ` Vladimir Zapolskiy
2014-10-21 17:27 ` Vladimir Zapolskiy
2014-10-21 17:27 ` Vladimir Zapolskiy
[not found] ` <1413728182-13569-5-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-21 19:11 ` Maxime Ripard
2014-10-21 19:11 ` Maxime Ripard
2014-10-21 19:11 ` Maxime Ripard
2014-10-24 18:52 ` Corentin LABBE
2014-10-24 18:52 ` Corentin LABBE
2014-10-24 18:52 ` Corentin LABBE
[not found] ` <544A9FEA.6020304-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-30 17:19 ` Maxime Ripard
2014-10-30 17:19 ` Maxime Ripard
2014-10-30 17:19 ` Maxime Ripard
2014-10-31 7:20 ` Herbert Xu
2014-10-31 7:20 ` Herbert Xu
2014-10-31 7:20 ` Herbert Xu
[not found] ` <20141031072030.GA7563-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2014-10-31 8:13 ` Maxime Ripard [this message]
2014-10-31 8:13 ` Maxime Ripard
2014-10-31 8:13 ` Maxime Ripard
2014-10-31 8:18 ` Herbert Xu
2014-10-31 8:18 ` Herbert Xu
2014-10-31 8:18 ` Herbert Xu
[not found] ` <20141031081803.GA8012-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2014-10-31 9:57 ` Maxime Ripard
2014-10-31 9:57 ` Maxime Ripard
2014-10-31 9:57 ` Maxime Ripard
2014-10-31 10:05 ` Herbert Xu
2014-10-31 10:05 ` Herbert Xu
[not found] ` <20141031100522.GA8655-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2014-11-03 9:34 ` Maxime Ripard
2014-11-03 9:34 ` Maxime Ripard
2014-11-03 9:34 ` Maxime Ripard
2014-11-03 10:35 ` Herbert Xu
2014-11-03 10:35 ` Herbert Xu
[not found] ` <20141103103528.GA30154-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2014-11-06 14:26 ` Maxime Ripard
2014-11-06 14:26 ` Maxime Ripard
2014-11-06 14:26 ` Maxime Ripard
2014-11-06 14:32 ` Herbert Xu
2014-11-06 14:32 ` Herbert Xu
[not found] ` <20141106143217.GA3636-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2014-11-16 17:13 ` Maxime Ripard
2014-11-16 17:13 ` Maxime Ripard
2014-11-16 17:13 ` Maxime Ripard
2014-10-22 9:00 ` Arnd Bergmann
2014-10-22 9:00 ` Arnd Bergmann
2014-10-22 9:00 ` Arnd Bergmann
2014-10-22 9:00 ` Arnd Bergmann
2014-10-22 9:00 ` Arnd Bergmann
2014-10-24 18:50 ` Corentin LABBE
2014-10-24 18:50 ` [linux-sunxi] " Corentin LABBE
2014-10-24 18:50 ` Corentin LABBE
2014-10-22 9:00 ` Arnd Bergmann
2014-11-06 14:13 ` Herbert Xu
2014-11-06 14:13 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031081323.GS21251@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=crope-X3B1VOXEql0@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.