From: Amos Kong <akong@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, m@bues.ch,
mpm@selenic.com, amit.shah@redhat.com
Subject: Re: [PATCH v2 4/6] hw_random: fix unregister race.
Date: Sun, 2 Nov 2014 23:06:13 +0800 [thread overview]
Message-ID: <20141102150613.GA31178@air.redhat.com> (raw)
In-Reply-To: <20141031072321.GB7563@gondor.apana.org.au>
On Fri, Oct 31, 2014 at 03:23:21PM +0800, Herbert Xu wrote:
> On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote:
> > Herbert Xu <herbert@gondor.apana.org.au> writes:
> > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote:
> > >> From: Rusty Russell <rusty@rustcorp.com.au>
> > >>
> > >> The previous patch added one potential problem: we can still be
> > >> reading from a hwrng when it's unregistered. Add a wait for zero
> > >> in the hwrng_unregister path.
> > >>
> > >> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> > >
> > > You totally corrupted Rusty's patch. If you're going to repost
> > > his series you better make sure that you've got the right patches.
> > >
> > > Just as well though as it made me think a little more about this
> > > patch :)
> >
> > OK Amos, can you please repost the complete series?
>
> Please fix the unregister race I identified first.
Ok, I redownload the patches from https://patchwork.kernel.org/project/LKML/list/?submitter=5
and rebase fixes of me and rusty on it. I will post a V4 later. Thanks.
--
Amos.
WARNING: multiple messages have this Message-ID (diff)
From: Amos Kong <akong@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
m@bues.ch, mpm@selenic.com, amit.shah@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] hw_random: fix unregister race.
Date: Sun, 2 Nov 2014 23:06:13 +0800 [thread overview]
Message-ID: <20141102150613.GA31178@air.redhat.com> (raw)
In-Reply-To: <20141031072321.GB7563@gondor.apana.org.au>
On Fri, Oct 31, 2014 at 03:23:21PM +0800, Herbert Xu wrote:
> On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote:
> > Herbert Xu <herbert@gondor.apana.org.au> writes:
> > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote:
> > >> From: Rusty Russell <rusty@rustcorp.com.au>
> > >>
> > >> The previous patch added one potential problem: we can still be
> > >> reading from a hwrng when it's unregistered. Add a wait for zero
> > >> in the hwrng_unregister path.
> > >>
> > >> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> > >
> > > You totally corrupted Rusty's patch. If you're going to repost
> > > his series you better make sure that you've got the right patches.
> > >
> > > Just as well though as it made me think a little more about this
> > > patch :)
> >
> > OK Amos, can you please repost the complete series?
>
> Please fix the unregister race I identified first.
Ok, I redownload the patches from https://patchwork.kernel.org/project/LKML/list/?submitter=5
and rebase fixes of me and rusty on it. I will post a V4 later. Thanks.
--
Amos.
next prev parent reply other threads:[~2014-11-02 15:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 12:37 [PATCH v2 0/6] fix hw_random stuck Amos Kong
2014-09-18 12:37 ` Amos Kong
2014-09-18 12:37 ` [PATCH v2 1/6] hw_random: place mutex around read functions and buffers Amos Kong
2014-09-18 12:37 ` Amos Kong
2014-09-18 12:37 ` [PATCH v2 2/6] hw_random: move some code out mutex_lock for avoiding underlying deadlock Amos Kong
2014-09-18 12:37 ` Amos Kong
2014-09-18 12:37 ` [PATCH v2 3/6] hw_random: use reference counts on each struct hwrng Amos Kong
2014-09-18 17:08 ` Amos Kong
2014-10-20 0:12 ` Rusty Russell
2014-10-20 0:12 ` Rusty Russell
2014-10-20 3:58 ` Amos Kong
2014-10-20 3:58 ` Amos Kong
2014-10-20 0:08 ` Rusty Russell
2014-10-20 0:08 ` Rusty Russell
2014-09-18 12:37 ` Amos Kong
2014-09-18 12:37 ` [PATCH v2 4/6] hw_random: fix unregister race Amos Kong
2014-09-18 12:37 ` Amos Kong
2014-10-21 14:17 ` Herbert Xu
2014-10-21 14:17 ` Herbert Xu
2014-10-30 23:58 ` Rusty Russell
2014-10-30 23:58 ` Rusty Russell
2014-10-31 7:23 ` Herbert Xu
2014-10-31 7:23 ` Herbert Xu
2014-11-02 15:06 ` Amos Kong [this message]
2014-11-02 15:06 ` Amos Kong
2014-11-02 15:08 ` Herbert Xu
2014-11-02 15:08 ` Herbert Xu
2014-11-02 15:14 ` Amos Kong
2014-11-02 15:14 ` Amos Kong
2014-09-18 12:37 ` [PATCH v2 5/6] hw_random: don't double-check old_rng Amos Kong
2014-09-18 12:37 ` Amos Kong
2014-09-18 12:37 ` [PATCH v2 6/6] hw_random: don't init list element we're about to add to list Amos Kong
2014-09-18 12:37 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141102150613.GA31178@air.redhat.com \
--to=akong@redhat.com \
--cc=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m@bues.ch \
--cc=mpm@selenic.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.