All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC V6 3/3] arm64:add bitrev.h file to support rbit instruction
Date: Mon, 3 Nov 2014 09:50:51 +0000	[thread overview]
Message-ID: <20141103095051.GA23019@arm.com> (raw)
In-Reply-To: <CAKv+Gu-+fe9Hj-uGQHq8KR_6WjrQL-1q=xVBSXVXg2EJO=MW2w@mail.gmail.com>

On Mon, Nov 03, 2014 at 08:47:32AM +0000, Ard Biesheuvel wrote:
> On 3 November 2014 03:17, Wang, Yalin <Yalin.Wang@sonymobile.com> wrote:
> >> From: Will Deacon [mailto:will.deacon at arm.com]
> >> > +#ifndef __ASM_ARM64_BITREV_H
> >> > +#define __ASM_ARM64_BITREV_H
> >>
> >> Really minor nit, but we don't tend to include 'ARM64' in our header guards,
> >> so this should just be __ASM_BITREV_H.
> >>
> >> With that change,
> >>
> >>   Acked-by: Will Deacon <will.deacon@arm.com>
> >>
> > I have send the patch to the patch system:
> > http://www.arm.linux.org.uk/developer/patches/search.php?uid=4025
> >
> > 8187/1 8188/1 8189/1
> >
> > Just remind you that , should also cherry-pick Joe Perches's
> > 2 patches:
> > [PATCH] 6fire: Convert byte_rev_table uses to bitrev8
> > [PATCH] carl9170: Convert byte_rev_table uses to bitrev8
> >
> > To make sure there is no build error when build these 2 drivers.
> >
> 
> If this is the case, I suggest you update patch 8187/1 to retain the
> byte_rev_table symbol, even in the accelerated case, and remove it
> with a followup patch once Joe's patches have landed upstream. Also, a
> link to the patches would be nice, and perhaps a bit of explanation
> how/when they are expected to be merged.

Indeed, or instead put together a series with the appropriate acks so
somebody can merge it all in one go. Merging this on a piecemeal basis is
going to cause breakages (as you pointed out).

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Wang, Yalin" <Yalin.Wang@sonymobile.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Joe Perches <joe@perches.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC V6 3/3] arm64:add bitrev.h file to support rbit instruction
Date: Mon, 3 Nov 2014 09:50:51 +0000	[thread overview]
Message-ID: <20141103095051.GA23019@arm.com> (raw)
In-Reply-To: <CAKv+Gu-+fe9Hj-uGQHq8KR_6WjrQL-1q=xVBSXVXg2EJO=MW2w@mail.gmail.com>

On Mon, Nov 03, 2014 at 08:47:32AM +0000, Ard Biesheuvel wrote:
> On 3 November 2014 03:17, Wang, Yalin <Yalin.Wang@sonymobile.com> wrote:
> >> From: Will Deacon [mailto:will.deacon@arm.com]
> >> > +#ifndef __ASM_ARM64_BITREV_H
> >> > +#define __ASM_ARM64_BITREV_H
> >>
> >> Really minor nit, but we don't tend to include 'ARM64' in our header guards,
> >> so this should just be __ASM_BITREV_H.
> >>
> >> With that change,
> >>
> >>   Acked-by: Will Deacon <will.deacon@arm.com>
> >>
> > I have send the patch to the patch system:
> > http://www.arm.linux.org.uk/developer/patches/search.php?uid=4025
> >
> > 8187/1 8188/1 8189/1
> >
> > Just remind you that , should also cherry-pick Joe Perches's
> > 2 patches:
> > [PATCH] 6fire: Convert byte_rev_table uses to bitrev8
> > [PATCH] carl9170: Convert byte_rev_table uses to bitrev8
> >
> > To make sure there is no build error when build these 2 drivers.
> >
> 
> If this is the case, I suggest you update patch 8187/1 to retain the
> byte_rev_table symbol, even in the accelerated case, and remove it
> with a followup patch once Joe's patches have landed upstream. Also, a
> link to the patches would be nice, and perhaps a bit of explanation
> how/when they are expected to be merged.

Indeed, or instead put together a series with the appropriate acks so
somebody can merge it all in one go. Merging this on a piecemeal basis is
going to cause breakages (as you pointed out).

Will

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Wang, Yalin" <Yalin.Wang@sonymobile.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Joe Perches <joe@perches.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC V6 3/3] arm64:add bitrev.h file to support rbit instruction
Date: Mon, 3 Nov 2014 09:50:51 +0000	[thread overview]
Message-ID: <20141103095051.GA23019@arm.com> (raw)
In-Reply-To: <CAKv+Gu-+fe9Hj-uGQHq8KR_6WjrQL-1q=xVBSXVXg2EJO=MW2w@mail.gmail.com>

On Mon, Nov 03, 2014 at 08:47:32AM +0000, Ard Biesheuvel wrote:
> On 3 November 2014 03:17, Wang, Yalin <Yalin.Wang@sonymobile.com> wrote:
> >> From: Will Deacon [mailto:will.deacon@arm.com]
> >> > +#ifndef __ASM_ARM64_BITREV_H
> >> > +#define __ASM_ARM64_BITREV_H
> >>
> >> Really minor nit, but we don't tend to include 'ARM64' in our header guards,
> >> so this should just be __ASM_BITREV_H.
> >>
> >> With that change,
> >>
> >>   Acked-by: Will Deacon <will.deacon@arm.com>
> >>
> > I have send the patch to the patch system:
> > http://www.arm.linux.org.uk/developer/patches/search.php?uid=4025
> >
> > 8187/1 8188/1 8189/1
> >
> > Just remind you that , should also cherry-pick Joe Perches's
> > 2 patches:
> > [PATCH] 6fire: Convert byte_rev_table uses to bitrev8
> > [PATCH] carl9170: Convert byte_rev_table uses to bitrev8
> >
> > To make sure there is no build error when build these 2 drivers.
> >
> 
> If this is the case, I suggest you update patch 8187/1 to retain the
> byte_rev_table symbol, even in the accelerated case, and remove it
> with a followup patch once Joe's patches have landed upstream. Also, a
> link to the patches would be nice, and perhaps a bit of explanation
> how/when they are expected to be merged.

Indeed, or instead put together a series with the appropriate acks so
somebody can merge it all in one go. Merging this on a piecemeal basis is
going to cause breakages (as you pointed out).

Will

  reply	other threads:[~2014-11-03  9:50 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24  5:10 [PATCH RFC] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit Wang, Yalin
2014-10-24  5:10 ` Wang, Yalin
2014-10-24  5:10 ` Wang, Yalin
2014-10-27  6:37 ` [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction Wang, Yalin
2014-10-27  6:37   ` Wang, Yalin
2014-10-27  6:46   ` Joe Perches
2014-10-27  6:46     ` Joe Perches
2014-10-27  6:46     ` Joe Perches
2014-10-27  7:13     ` Wang, Yalin
2014-10-27  7:13       ` Wang, Yalin
2014-10-27  7:13       ` Wang, Yalin
2014-10-28 21:18     ` [PATCH] carl9170: Convert byte_rev_table uses to bitrev8 Joe Perches
2014-10-28 21:18       ` Joe Perches
2014-10-28 21:18       ` Joe Perches
2014-10-28 21:22     ` [PATCH] 6fire: " Joe Perches
2014-10-28 21:22       ` Joe Perches
2014-10-28 21:22       ` Joe Perches
2014-10-29  2:42       ` Wang, Yalin
2014-10-29  2:42         ` Wang, Yalin
2014-10-29  2:42         ` Wang, Yalin
2014-10-29  3:06         ` Joe Perches
2014-10-29  3:06           ` Joe Perches
2014-10-29  3:06           ` Joe Perches
2014-10-29  3:10           ` Wang, Yalin
2014-10-29  3:10             ` Wang, Yalin
2014-10-29  3:10             ` Wang, Yalin
2014-10-29  3:28     ` [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction Rob Herring
2014-10-29  3:28       ` Rob Herring
2014-10-29  3:28       ` Rob Herring
2014-10-29  5:14       ` [RFC V4 1/3] add " Wang, Yalin
2014-10-29  5:14         ` Wang, Yalin
2014-10-29  5:15         ` [RFC V4 2/3] arm:add bitrev.h file " Wang, Yalin
2014-10-29  5:15           ` Wang, Yalin
2014-10-29  5:16           ` [RFC V4 3/3] arm64:add " Wang, Yalin
2014-10-29  5:16             ` Wang, Yalin
2014-10-29  5:50             ` [RFC V5 1/3] add CONFIG_HAVE_ARCH_BITREVERSE " Wang, Yalin
2014-10-29  5:50               ` Wang, Yalin
2014-10-29  5:51               ` [RFC V5 2/3] arm:add bitrev.h file " Wang, Yalin
2014-10-29  5:51                 ` Wang, Yalin
2014-10-29  5:52                 ` [RFC V5 3/3] arm64:add " Wang, Yalin
2014-10-29  5:52                   ` Wang, Yalin
2014-10-30 12:01                   ` Will Deacon
2014-10-30 12:01                     ` Will Deacon
2014-10-30 12:01                     ` Will Deacon
2014-10-30 12:26                     ` Ard Biesheuvel
2014-10-30 12:26                       ` Ard Biesheuvel
2014-10-30 12:26                       ` Ard Biesheuvel
2014-10-30 13:57                       ` Will Deacon
2014-10-30 13:57                         ` Will Deacon
2014-10-30 13:57                         ` Will Deacon
2014-10-31  5:40                         ` [RFC V6 1/3] add CONFIG_HAVE_ARCH_BITREVERSE " Wang, Yalin
2014-10-31  5:40                           ` Wang, Yalin
2014-10-31  5:40                           ` [RFC V6 2/3] " Wang, Yalin
2014-10-31  5:40                             ` Wang, Yalin
2014-10-31  5:42                             ` [RFC V6 2/3] arm:add bitrev.h file " Wang, Yalin
2014-10-31  5:42                               ` Wang, Yalin
2014-10-31  7:40                               ` [RFC] arm:remove clear_thread_flag(TIF_UPROBE) Wang, Yalin
2014-10-31  7:40                                 ` Wang, Yalin
2014-10-31  7:45                                 ` Joe Perches
2014-10-31  7:45                                   ` Joe Perches
2014-10-31  7:45                                   ` Joe Perches
2014-10-31  7:51                                   ` Wang, Yalin
2014-10-31  7:51                                     ` Wang, Yalin
2014-10-31  7:51                                     ` Wang, Yalin
2014-10-31  7:58                                     ` Joe Perches
2014-10-31  7:58                                       ` Joe Perches
2014-10-31  7:58                                       ` Joe Perches
2014-10-31  7:59                                       ` Wang, Yalin
2014-10-31  7:59                                         ` Wang, Yalin
2014-10-31  7:59                                         ` Wang, Yalin
2014-10-31  8:01                                     ` [RFC V2] " Wang, Yalin
2014-10-31  8:01                                       ` Wang, Yalin
2014-11-13 23:53                               ` [RFC V6 2/3] arm:add bitrev.h file to support rbit instruction Russell King - ARM Linux
2014-11-13 23:53                                 ` Russell King - ARM Linux
2014-11-13 23:53                                 ` Russell King - ARM Linux
2014-11-14  0:05                                 ` Joe Perches
2014-11-14  0:05                                   ` Joe Perches
2014-11-14  0:05                                   ` Joe Perches
2014-11-14  0:17                                   ` Russell King - ARM Linux
2014-11-14  0:17                                     ` Russell King - ARM Linux
2014-11-14  0:17                                     ` Russell King - ARM Linux
2014-11-14  0:45                                     ` Joe Perches
2014-11-14  0:45                                       ` Joe Perches
2014-11-14  0:45                                       ` Joe Perches
2014-11-14  1:18                                       ` Russell King - ARM Linux
2014-11-14  1:18                                         ` Russell King - ARM Linux
2014-11-14  1:18                                         ` Russell King - ARM Linux
2014-11-14  1:26                                         ` Joe Perches
2014-11-14  1:26                                           ` Joe Perches
2014-11-14  1:26                                           ` Joe Perches
2014-11-14  9:52                                           ` Russell King - ARM Linux
2014-11-14  9:52                                             ` Russell King - ARM Linux
2014-11-14  9:52                                             ` Russell King - ARM Linux
2014-11-14  6:37                                   ` Takashi Iwai
2014-11-14  6:37                                     ` Takashi Iwai
2014-11-14  6:37                                     ` Takashi Iwai
2014-11-14  6:55                                     ` Joe Perches
2014-11-14  6:55                                       ` Joe Perches
2014-11-14  6:55                                       ` Joe Perches
2014-11-14  7:03                                       ` Takashi Iwai
2014-11-14  7:03                                         ` Takashi Iwai
2014-11-14  7:03                                         ` Takashi Iwai
2014-11-14  2:01                                 ` Wang, Yalin
2014-11-14  2:01                                   ` Wang, Yalin
2014-11-14  2:01                                   ` Wang, Yalin
2014-11-14  9:58                                   ` Russell King - ARM Linux
2014-11-14  9:58                                     ` Russell King - ARM Linux
2014-11-14  9:58                                     ` Russell King - ARM Linux
2014-11-17  2:38                                     ` Wang, Yalin
2014-11-17  2:38                                       ` Wang, Yalin
2014-11-17  2:38                                       ` Wang, Yalin
2015-01-08 18:40                                       ` Russell King - ARM Linux
2015-01-08 18:40                                         ` Russell King - ARM Linux
2015-01-08 18:40                                         ` Russell King - ARM Linux
2015-01-09  2:16                                         ` Wang, Yalin
2015-01-09  2:16                                           ` Wang, Yalin
2015-01-09  2:16                                           ` Wang, Yalin
2015-01-09 11:10                                           ` Russell King - ARM Linux
2015-01-09 11:10                                             ` Russell King - ARM Linux
2015-01-09 11:10                                             ` Russell King - ARM Linux
2015-01-09 12:40                                             ` Wang, Yalin
2015-01-09 12:40                                               ` Wang, Yalin
2015-01-09 12:40                                               ` Wang, Yalin
2015-01-14 16:38                                               ` Russell King - ARM Linux
2015-01-14 16:38                                                 ` Russell King - ARM Linux
2015-01-14 16:38                                                 ` Russell King - ARM Linux
2015-01-16  1:42                                                 ` Wang, Yalin
2015-01-16  1:42                                                   ` Wang, Yalin
2015-01-16  1:42                                                   ` Wang, Yalin
2014-10-31  7:54                             ` [RFC V6 2/3] add CONFIG_HAVE_ARCH_BITREVERSE " Wang, Yalin
2014-10-31  7:54                               ` Wang, Yalin
2014-10-31  7:54                               ` Wang, Yalin
2014-10-31  5:41                           ` [RFC V6 3/3] arm64:add bitrev.h file " Wang, Yalin
2014-10-31  5:41                             ` Wang, Yalin
2014-10-31 10:43                             ` Will Deacon
2014-10-31 10:43                               ` Will Deacon
2014-10-31 10:43                               ` Will Deacon
2014-11-03  2:17                               ` Wang, Yalin
2014-11-03  2:17                                 ` Wang, Yalin
2014-11-03  2:17                                 ` Wang, Yalin
2014-11-03  8:47                                 ` Ard Biesheuvel
2014-11-03  8:47                                   ` Ard Biesheuvel
2014-11-03  8:47                                   ` Ard Biesheuvel
2014-11-03  9:50                                   ` Will Deacon [this message]
2014-11-03  9:50                                     ` Will Deacon
2014-11-03  9:50                                     ` Will Deacon
2014-11-04  1:45                                     ` Wang, Yalin
2014-11-04  1:45                                       ` Wang, Yalin
2014-11-04  1:45                                       ` Wang, Yalin
2014-10-31  2:03                     ` [RFC V5 " Wang, Yalin
2014-10-31  2:03                       ` Wang, Yalin
2014-10-31  2:03                       ` Wang, Yalin
2014-10-29  5:21         ` [RFC V4 1/3] add CONFIG_HAVE_ARCH_BITREVERSE " Joe Perches
2014-10-29  5:21           ` Joe Perches
2014-10-29  5:21           ` Joe Perches
2014-10-29  5:36           ` Wang, Yalin
2014-10-29  5:36             ` Wang, Yalin
2014-10-29  5:36             ` Wang, Yalin
2014-10-29  5:20       ` [RFC V2] arm/arm64:add " Wang, Yalin
2014-10-29  5:20         ` Wang, Yalin
2014-10-29  5:20         ` Wang, Yalin
2014-10-27  8:02   ` [RFC V3] " Wang, Yalin
2014-10-27  8:02     ` Wang, Yalin
2014-10-27 10:48     ` Will Deacon
2014-10-27 10:48       ` Will Deacon
2014-10-27 10:48       ` Will Deacon
2014-10-28  1:34       ` Wang, Yalin
2014-10-28  1:34         ` Wang, Yalin
2014-10-28  1:34         ` Wang, Yalin
2014-10-28 13:59         ` Will Deacon
2014-10-28 13:59           ` Will Deacon
2014-10-28 13:59           ` Will Deacon
2014-10-29  2:52           ` Wang, Yalin
2014-10-29  2:52             ` Wang, Yalin
2014-10-29  2:52             ` Wang, Yalin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141103095051.GA23019@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.