From: "Michael S. Tsirkin" <mst@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds
Date: Mon, 3 Nov 2014 18:40:36 +0200 [thread overview]
Message-ID: <20141103164036.GA31267@redhat.com> (raw)
In-Reply-To: <87egtkuusk.fsf@blackfin.pond.sub.org>
On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote:
> >> "Michael S. Tsirkin" <mst@redhat.com> writes:
> >>
> >> > tcp_get_fds API discards fds if there's more than 1 of these.
> >>
> >> s/tcp_get_fds/tcp_get_msgfds/ (subject as well)
> >
> > Right. Too late as I sent this upstream :(
>
> Oh, now I see: you already sent this in a pull request, after less than
> 20 hours on list. Please don't do that except in dire emergency. It
> sabotages our review process.
I sometimes do this for patches that seem trivial to me.
I've backed this one out for now.
--
MST
next prev parent reply other threads:[~2014-11-03 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 16:53 [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds Michael S. Tsirkin
2014-11-03 15:09 ` Markus Armbruster
2014-11-03 15:19 ` Michael S. Tsirkin
2014-11-03 16:06 ` Markus Armbruster
2014-11-03 16:13 ` Markus Armbruster
2014-11-03 16:22 ` Peter Maydell
2014-11-03 16:32 ` Michael S. Tsirkin
2014-11-03 16:35 ` Michael S. Tsirkin
2014-11-04 0:17 ` Peter Maydell
2014-11-04 13:49 ` Michael S. Tsirkin
2014-11-03 16:40 ` Michael S. Tsirkin [this message]
2014-11-04 6:50 ` Markus Armbruster
2014-11-27 9:58 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103164036.GA31267@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.