From: Markus Armbruster <armbru@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds
Date: Mon, 03 Nov 2014 17:06:53 +0100 [thread overview]
Message-ID: <87ioiwuv36.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20141103151955.GA14401@redhat.com> (Michael S. Tsirkin's message of "Mon, 3 Nov 2014 17:19:55 +0200")
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote:
>> "Michael S. Tsirkin" <mst@redhat.com> writes:
>>
>> > tcp_get_fds API discards fds if there's more than 1 of these.
>>
>> s/tcp_get_fds/tcp_get_msgfds/ (subject as well)
>
> Right. Too late as I sent this upstream :(
Why not simply respin with a fixed commit message? Or ask the
maintainer to fix it up on commit?
>> What exactly doesn't work without this patch?
>
> It's only used by vhost test. It works by chance because
> it's only using 512m ram.
Would be a nice addition to the commit message.
> I tweaked vhost user test
> to use more memory (3900 instead of 512 M) and it started failing
> because it needs 3 fds then.
>
> Not yet upstreaming the test change itself, looking
> for ways to avoid using huge pages for this.
Okay :)
[...]
next prev parent reply other threads:[~2014-11-03 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 16:53 [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds Michael S. Tsirkin
2014-11-03 15:09 ` Markus Armbruster
2014-11-03 15:19 ` Michael S. Tsirkin
2014-11-03 16:06 ` Markus Armbruster [this message]
2014-11-03 16:13 ` Markus Armbruster
2014-11-03 16:22 ` Peter Maydell
2014-11-03 16:32 ` Michael S. Tsirkin
2014-11-03 16:35 ` Michael S. Tsirkin
2014-11-04 0:17 ` Peter Maydell
2014-11-04 13:49 ` Michael S. Tsirkin
2014-11-03 16:40 ` Michael S. Tsirkin
2014-11-04 6:50 ` Markus Armbruster
2014-11-27 9:58 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioiwuv36.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.