From: Guenter Roeck <linux@roeck-us.net>
To: Felipe Balbi <balbi@ti.com>
Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
nsekhar@ti.com, grant.likely@linaro.org,
George Cherian <george.cherian@ti.com>
Subject: Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's
Date: Mon, 3 Nov 2014 10:01:50 -0800 [thread overview]
Message-ID: <20141103180150.GA10164@roeck-us.net> (raw)
In-Reply-To: <1415032350-8459-2-git-send-email-balbi@ti.com>
On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote:
> From: George Cherian <george.cherian@ti.com>
>
> Convert the driver to use gpiod_* API's.
>
> Reviewed-by: Roger Quadros <rogerq@ti.com>
> Signed-off-by: George Cherian <george.cherian@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
I think it might be useful and appropriate to explain that and why
you remove support for active-low pins, instead of hiding it in a
seemingly unrelated patch.
Also, since you don't use the platform data flag anymore, you might
as well remove it to give out-of-tree users a fair warning. Overall,
it might be easier to just revert the patch introducing it (5bfbdc9caa7)
before converting extcon to gpiod.
I am just glad that we stopped using extcon for other reasons ;-)
Guenter
next prev parent reply other threads:[~2014-11-03 18:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 16:32 [PATCH 0/4] extcon: gpio: add DT support Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:32 ` [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 18:01 ` Guenter Roeck [this message]
2014-11-03 18:06 ` Felipe Balbi
2014-11-03 18:06 ` Felipe Balbi
2014-11-03 18:51 ` Guenter Roeck
2014-11-03 20:43 ` Felipe Balbi
2014-11-03 20:43 ` Felipe Balbi
[not found] ` <1415032350-8459-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2014-11-03 16:32 ` [PATCH 2/4] extcon: gpio: Add dt support for the driver Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:32 ` [PATCH 3/4] extcon: gpio: Always use gpio_get_value_cansleep Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:32 ` [PATCH 4/4] extcon: gpio: Add support for using cable names Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:39 ` Felipe Balbi
2014-11-03 16:39 ` Felipe Balbi
2014-11-04 6:12 ` [PATCH 0/4] extcon: gpio: add DT support George Cherian
2014-11-04 6:12 ` George Cherian
2014-11-04 14:41 ` Felipe Balbi
2014-11-04 14:41 ` Felipe Balbi
2014-11-05 15:25 ` George Cherian
2014-11-05 15:25 ` George Cherian
2014-11-05 18:28 ` Felipe Balbi
2014-11-05 18:28 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103180150.GA10164@roeck-us.net \
--to=linux@roeck-us.net \
--cc=balbi@ti.com \
--cc=cw00.choi@samsung.com \
--cc=george.cherian@ti.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.