From: Felipe Balbi <balbi@TI.COM>
To: Felipe Balbi <balbi@TI.COM>
Cc: myungjoo.ham@samsung.com, cw00.choi@samsung.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
nsekhar@TI.COM, grant.likely@linaro.org,
George Cherian <george.cherian@TI.COM>
Subject: Re: [PATCH 4/4] extcon: gpio: Add support for using cable names
Date: Mon, 3 Nov 2014 10:39:36 -0600 [thread overview]
Message-ID: <20141103163936.GO27425@saruman> (raw)
In-Reply-To: <1415032350-8459-5-git-send-email-balbi@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2510 bytes --]
On Mon, Nov 03, 2014 at 10:32:30AM -0600, Felipe Balbi wrote:
> From: George Cherian <george.cherian@ti.com>
>
> Add support for using cable names. Enables other drivers to register interest
> and get notified using extcon provided notifier call backs.
>
> Signed-off-by: George Cherian <george.cherian@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> Documentation/devicetree/bindings/extcon/extcon-gpio.txt | 2 ++
> drivers/extcon/extcon-gpio.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> index 5fe6846..f19aeb4 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> @@ -7,6 +7,7 @@ Required Properties:
> - compatible: should be:
> * "linux,extcon-gpio"
> - gpios: specifies the gpio pin used.
> + - cable-name: Name of the cable used.
>
> Optional Properties:
> - debounce: Debounce time for GPIO IRQ in ms
> @@ -18,4 +19,5 @@ Eg:
> compatible = "linux,extcon-gpio";
> gpios = <&gpio3 12 GPIO_ACTIVE_HIGH>;
> debounce = <20>;
> + cable-name = "USB-HOST";
> };
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 7191d28..cbe35af 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -42,6 +42,7 @@ struct gpio_extcon_data {
> struct delayed_work work;
> unsigned long debounce_jiffies;
> bool check_on_resume;
> + const char *cable_name[1];
> };
>
> static void gpio_extcon_work(struct work_struct *work)
> @@ -112,6 +113,9 @@ static int gpio_extcon_probe(struct platform_device *pdev)
> of_property_read_u32(np, "debounce", &debounce);
> irq = gpiod_to_irq(extcon_data->gpiod);
> irq_flags = irq_get_trigger_type(irq);
> + of_property_read_string_index(np, "cable-name", 0,
> + extcon_data->cable_name);
> + extcon_data->edev->supported_cable = extcon_data->cable_name;
> } else {
> if (!pdata)
> return -EBUSY;
> --
> 2.1.0.GIT
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@TI.COM>
To: Felipe Balbi <balbi@TI.COM>
Cc: <myungjoo.ham@samsung.com>, <cw00.choi@samsung.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
<nsekhar@TI.COM>, <grant.likely@linaro.org>,
George Cherian <george.cherian@TI.COM>
Subject: Re: [PATCH 4/4] extcon: gpio: Add support for using cable names
Date: Mon, 3 Nov 2014 10:39:36 -0600 [thread overview]
Message-ID: <20141103163936.GO27425@saruman> (raw)
In-Reply-To: <1415032350-8459-5-git-send-email-balbi@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2510 bytes --]
On Mon, Nov 03, 2014 at 10:32:30AM -0600, Felipe Balbi wrote:
> From: George Cherian <george.cherian@ti.com>
>
> Add support for using cable names. Enables other drivers to register interest
> and get notified using extcon provided notifier call backs.
>
> Signed-off-by: George Cherian <george.cherian@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> Documentation/devicetree/bindings/extcon/extcon-gpio.txt | 2 ++
> drivers/extcon/extcon-gpio.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> index 5fe6846..f19aeb4 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-gpio.txt
> @@ -7,6 +7,7 @@ Required Properties:
> - compatible: should be:
> * "linux,extcon-gpio"
> - gpios: specifies the gpio pin used.
> + - cable-name: Name of the cable used.
>
> Optional Properties:
> - debounce: Debounce time for GPIO IRQ in ms
> @@ -18,4 +19,5 @@ Eg:
> compatible = "linux,extcon-gpio";
> gpios = <&gpio3 12 GPIO_ACTIVE_HIGH>;
> debounce = <20>;
> + cable-name = "USB-HOST";
> };
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 7191d28..cbe35af 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -42,6 +42,7 @@ struct gpio_extcon_data {
> struct delayed_work work;
> unsigned long debounce_jiffies;
> bool check_on_resume;
> + const char *cable_name[1];
> };
>
> static void gpio_extcon_work(struct work_struct *work)
> @@ -112,6 +113,9 @@ static int gpio_extcon_probe(struct platform_device *pdev)
> of_property_read_u32(np, "debounce", &debounce);
> irq = gpiod_to_irq(extcon_data->gpiod);
> irq_flags = irq_get_trigger_type(irq);
> + of_property_read_string_index(np, "cable-name", 0,
> + extcon_data->cable_name);
> + extcon_data->edev->supported_cable = extcon_data->cable_name;
> } else {
> if (!pdata)
> return -EBUSY;
> --
> 2.1.0.GIT
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-03 16:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 16:32 [PATCH 0/4] extcon: gpio: add DT support Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:32 ` [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 18:01 ` Guenter Roeck
2014-11-03 18:06 ` Felipe Balbi
2014-11-03 18:06 ` Felipe Balbi
2014-11-03 18:51 ` Guenter Roeck
2014-11-03 20:43 ` Felipe Balbi
2014-11-03 20:43 ` Felipe Balbi
[not found] ` <1415032350-8459-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2014-11-03 16:32 ` [PATCH 2/4] extcon: gpio: Add dt support for the driver Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:32 ` [PATCH 3/4] extcon: gpio: Always use gpio_get_value_cansleep Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:32 ` [PATCH 4/4] extcon: gpio: Add support for using cable names Felipe Balbi
2014-11-03 16:32 ` Felipe Balbi
2014-11-03 16:39 ` Felipe Balbi [this message]
2014-11-03 16:39 ` Felipe Balbi
2014-11-04 6:12 ` [PATCH 0/4] extcon: gpio: add DT support George Cherian
2014-11-04 6:12 ` George Cherian
2014-11-04 14:41 ` Felipe Balbi
2014-11-04 14:41 ` Felipe Balbi
2014-11-05 15:25 ` George Cherian
2014-11-05 15:25 ` George Cherian
2014-11-05 18:28 ` Felipe Balbi
2014-11-05 18:28 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103163936.GO27425@saruman \
--to=balbi@ti.com \
--cc=cw00.choi@samsung.com \
--cc=george.cherian@TI.COM \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nsekhar@TI.COM \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.