From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jan Beulich <jbeulich@suse.com>, Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Sebastian Lackner <sebastian@fds-team.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chuck Ebbert <cebbert.lkml@gmail.com>,
Anish Bhatt <anish@chelsio.com>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-tip-commits@vger.kernel.org"
<linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/asm] sched/x86_64: Don't save flags on context switch
Date: Mon, 3 Nov 2014 22:58:37 +0100 [thread overview]
Message-ID: <20141103215837.GB8711@redhat.com> (raw)
In-Reply-To: <20141103214712.GA8711@redhat.com>
On 11/03, Oleg Nesterov wrote:
>
> On 11/03, Andy Lutomirski wrote:
> >
> > And do we ever have TF set during a context switch? I hope not.
>
> I too hope.
>
> > Also, what's with 'jmp exit_intr' at the end of retint_kernel? Why
> > isn't that 'jmp retint_kernel'?
>
> Even better, why not "jmp retint_restore_args" ?
>
> preempt_schedule_irq() checks need_resched() and returns with irqs
> disabled, not need to to recheck test_preempt_need_resched() ?
Btw, why retint_kernel() checks "interrupts on" ? It seems to me that
that "interrupts off" is not possible, no? And this will be more clear
when we remove the "exit_intr" label.
Oleg.
next prev parent reply other threads:[~2014-11-03 21:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 18:28 [PATCH v3 0/2] x86_64,entry: Clear NT on entry and speed up switch_to Andy Lutomirski
2014-10-01 18:28 ` [PATCH v3 1/2] x86_64,entry: Filter RFLAGS.NT on entry from userspace Andy Lutomirski
2014-10-01 18:28 ` [PATCH v3 2/2] x86_64: Don't save flags on context switch Andy Lutomirski
2014-10-01 18:35 ` H. Peter Anvin
2014-10-01 18:44 ` Andy Lutomirski
2014-10-20 18:52 ` Andy Lutomirski
2014-10-28 11:14 ` [tip:x86/asm] sched/x86_64: " tip-bot for Andy Lutomirski
2014-11-03 21:11 ` Andy Lutomirski
2014-11-03 21:47 ` Oleg Nesterov
2014-11-03 21:58 ` Oleg Nesterov [this message]
2014-11-03 22:37 ` Andy Lutomirski
2014-11-03 22:57 ` Oleg Nesterov
2014-11-03 23:02 ` Andy Lutomirski
2014-11-03 23:10 ` Oleg Nesterov
2014-11-04 23:09 ` Oleg Nesterov
2014-11-03 22:17 ` H. Peter Anvin
2014-10-01 18:34 ` [PATCH v3 0/2] x86_64,entry: Clear NT on entry and speed up switch_to H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103215837.GB8711@redhat.com \
--to=oleg@redhat.com \
--cc=anish@chelsio.com \
--cc=cebbert.lkml@gmail.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=sebastian@fds-team.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.