From: Felipe Balbi <balbi@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: omap: hwmod: drop unnecessary list initialization
Date: Mon, 3 Nov 2014 23:39:52 -0600 [thread overview]
Message-ID: <20141104053952.GA15760@saruman> (raw)
In-Reply-To: <alpine.DEB.2.02.1407280524160.24161@utopia.booyaka.com>
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
Hi,
On Mon, Jul 28, 2014 at 05:24:34AM +0000, Paul Walmsley wrote:
> On Tue, 15 Jul 2014, Felipe Balbi wrote:
>
> > ml->node and sl->node are currently initialized
> > by means of INIT_LIST_HEAD(). That initialiation
> > is followed by a list_add() call.
> >
> > Looking at what both these functions do we will have:
> >
> > ml->node.next = &ml->node;
> > ml->node.prev = &ml->node;
> > oi->master->master_ports.next.prev = &ml->node;
> > ml->node.next = &oi->master->master_ports.next;
> > ml->node.prev = &oi->master->master_ports;
> > oi->master->master_ports.next = &ml->node;
> >
> > from this, it's clear that both INIT_LIST_HEAD() calls
> > are unnecessary and can be safely removed.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >
> > found by code inspection, boot tested on am437x SK on today's
> > linux-next + pending patches.
>
> Thanks, queued for v3.18.
This is not on v3.18, what happened ?
$ git log --author=balbi@ti.com linus/master ^v3.17 -- arch/arm/mach-omap2/omap_hwmod.c
$
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap: hwmod: drop unnecessary list initialization
Date: Mon, 3 Nov 2014 23:39:52 -0600 [thread overview]
Message-ID: <20141104053952.GA15760@saruman> (raw)
In-Reply-To: <alpine.DEB.2.02.1407280524160.24161@utopia.booyaka.com>
Hi,
On Mon, Jul 28, 2014 at 05:24:34AM +0000, Paul Walmsley wrote:
> On Tue, 15 Jul 2014, Felipe Balbi wrote:
>
> > ml->node and sl->node are currently initialized
> > by means of INIT_LIST_HEAD(). That initialiation
> > is followed by a list_add() call.
> >
> > Looking at what both these functions do we will have:
> >
> > ml->node.next = &ml->node;
> > ml->node.prev = &ml->node;
> > oi->master->master_ports.next.prev = &ml->node;
> > ml->node.next = &oi->master->master_ports.next;
> > ml->node.prev = &oi->master->master_ports;
> > oi->master->master_ports.next = &ml->node;
> >
> > from this, it's clear that both INIT_LIST_HEAD() calls
> > are unnecessary and can be safely removed.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >
> > found by code inspection, boot tested on am437x SK on today's
> > linux-next + pending patches.
>
> Thanks, queued for v3.18.
This is not on v3.18, what happened ?
$ git log --author=balbi at ti.com linus/master ^v3.17 -- arch/arm/mach-omap2/omap_hwmod.c
$
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141103/355af47a/attachment.sig>
next prev parent reply other threads:[~2014-11-04 5:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 20:18 [PATCH] arm: omap: hwmod: drop unnecessary list initialization Felipe Balbi
2014-07-15 20:18 ` Felipe Balbi
2014-07-28 5:24 ` Paul Walmsley
2014-07-28 5:24 ` Paul Walmsley
2014-11-04 5:39 ` Felipe Balbi [this message]
2014-11-04 5:39 ` Felipe Balbi
2014-11-06 16:19 ` Felipe Balbi
2014-11-06 16:19 ` Felipe Balbi
2014-11-07 14:09 ` Paul Walmsley
2014-11-07 14:09 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104053952.GA15760@saruman \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.