From: Bjorn Helgaas <bhelgaas@google.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
liviu.dudau@arm.com, Suravee.Suthikulpanit@amd.com,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH RFC 1/2] drivers: pci: fix window allocation order wrt bus_range filtering
Date: Wed, 5 Nov 2014 17:05:36 -0700 [thread overview]
Message-ID: <20141106000536.GL6168@google.com> (raw)
In-Reply-To: <1414077787-20633-1-git-send-email-lorenzo.pieralisi@arm.com>
On Thu, Oct 23, 2014 at 04:23:06PM +0100, Lorenzo Pieralisi wrote:
> The number of windows allocated for the host bridge depends on the
> bus resource. Instead of first allocating the windows and then
> limit the bus resource, this patch reshuffles the code so that if any
> limitation is applied to the bus resource it is taken into account in
> the windows allocation.
>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
I applied these with Will's acks to pci/host-generic for v3.19, thanks!
In my mind, posting patches to the list is implicitly a request for
comments, so I usually don't pay too much attention to things explicitly
marked "RFC" because I figure that's a hint that "this is work-in-progress,
please comment if you see anything obviously broken."
Bjorn
> ---
> drivers/pci/host/pci-host-generic.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
> index 3d2076f..1e1a80f 100644
> --- a/drivers/pci/host/pci-host-generic.c
> +++ b/drivers/pci/host/pci-host-generic.c
> @@ -276,17 +276,17 @@ static int gen_pci_parse_map_cfg_windows(struct gen_pci *pci)
> return err;
> }
>
> - pci->cfg.win = devm_kcalloc(dev, resource_size(&pci->cfg.bus_range),
> - sizeof(*pci->cfg.win), GFP_KERNEL);
> - if (!pci->cfg.win)
> - return -ENOMEM;
> -
> /* Limit the bus-range to fit within reg */
> bus_max = pci->cfg.bus_range.start +
> (resource_size(&pci->cfg.res) >> pci->cfg.ops->bus_shift) - 1;
> pci->cfg.bus_range.end = min_t(resource_size_t, pci->cfg.bus_range.end,
> bus_max);
>
> + pci->cfg.win = devm_kcalloc(dev, resource_size(&pci->cfg.bus_range),
> + sizeof(*pci->cfg.win), GFP_KERNEL);
> + if (!pci->cfg.win)
> + return -ENOMEM;
> +
> /* Map our Configuration Space windows */
> if (!devm_request_mem_region(dev, pci->cfg.res.start,
> resource_size(&pci->cfg.res),
> --
> 2.1.2
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: bhelgaas@google.com (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/2] drivers: pci: fix window allocation order wrt bus_range filtering
Date: Wed, 5 Nov 2014 17:05:36 -0700 [thread overview]
Message-ID: <20141106000536.GL6168@google.com> (raw)
In-Reply-To: <1414077787-20633-1-git-send-email-lorenzo.pieralisi@arm.com>
On Thu, Oct 23, 2014 at 04:23:06PM +0100, Lorenzo Pieralisi wrote:
> The number of windows allocated for the host bridge depends on the
> bus resource. Instead of first allocating the windows and then
> limit the bus resource, this patch reshuffles the code so that if any
> limitation is applied to the bus resource it is taken into account in
> the windows allocation.
>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
I applied these with Will's acks to pci/host-generic for v3.19, thanks!
In my mind, posting patches to the list is implicitly a request for
comments, so I usually don't pay too much attention to things explicitly
marked "RFC" because I figure that's a hint that "this is work-in-progress,
please comment if you see anything obviously broken."
Bjorn
> ---
> drivers/pci/host/pci-host-generic.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
> index 3d2076f..1e1a80f 100644
> --- a/drivers/pci/host/pci-host-generic.c
> +++ b/drivers/pci/host/pci-host-generic.c
> @@ -276,17 +276,17 @@ static int gen_pci_parse_map_cfg_windows(struct gen_pci *pci)
> return err;
> }
>
> - pci->cfg.win = devm_kcalloc(dev, resource_size(&pci->cfg.bus_range),
> - sizeof(*pci->cfg.win), GFP_KERNEL);
> - if (!pci->cfg.win)
> - return -ENOMEM;
> -
> /* Limit the bus-range to fit within reg */
> bus_max = pci->cfg.bus_range.start +
> (resource_size(&pci->cfg.res) >> pci->cfg.ops->bus_shift) - 1;
> pci->cfg.bus_range.end = min_t(resource_size_t, pci->cfg.bus_range.end,
> bus_max);
>
> + pci->cfg.win = devm_kcalloc(dev, resource_size(&pci->cfg.bus_range),
> + sizeof(*pci->cfg.win), GFP_KERNEL);
> + if (!pci->cfg.win)
> + return -ENOMEM;
> +
> /* Map our Configuration Space windows */
> if (!devm_request_mem_region(dev, pci->cfg.res.start,
> resource_size(&pci->cfg.res),
> --
> 2.1.2
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-11-06 0:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:23 [PATCH RFC 1/2] drivers: pci: fix window allocation order wrt bus_range filtering Lorenzo Pieralisi
2014-10-23 15:23 ` Lorenzo Pieralisi
2014-10-23 15:23 ` Lorenzo Pieralisi
2014-10-23 15:23 ` [PATCH RFC 2/2] drivers: pci: convert generic host controller to DT resource parsing API Lorenzo Pieralisi
2014-10-23 15:23 ` Lorenzo Pieralisi
2014-10-23 15:23 ` Lorenzo Pieralisi
2014-10-27 12:03 ` Will Deacon
2014-10-27 12:03 ` Will Deacon
2014-10-27 15:44 ` Lorenzo Pieralisi
2014-10-27 15:44 ` Lorenzo Pieralisi
2014-10-23 22:27 ` [PATCH RFC 1/2] drivers: pci: fix window allocation order wrt bus_range filtering Bjorn Helgaas
2014-10-23 22:27 ` Bjorn Helgaas
2014-10-24 8:53 ` Lorenzo Pieralisi
2014-10-24 8:53 ` Lorenzo Pieralisi
2014-10-24 9:04 ` Liviu Dudau
2014-10-24 9:04 ` Liviu Dudau
2014-10-24 10:55 ` Arnd Bergmann
2014-10-24 10:55 ` Arnd Bergmann
2014-10-27 12:01 ` Will Deacon
2014-10-27 12:01 ` Will Deacon
2014-11-06 0:05 ` Bjorn Helgaas [this message]
2014-11-06 0:05 ` Bjorn Helgaas
2014-11-06 9:58 ` Lorenzo Pieralisi
2014-11-06 9:58 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106000536.GL6168@google.com \
--to=bhelgaas@google.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.