From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Bryan Wu <cooloney@gmail.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
Grant Likely <grant.likely@linaro.org>,
Richard Purdie <rpurdie@rpsys.net>,
Linus Walleij <linus.walleij@linaro.org>,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: leds-gpio: Fix legacy GPIO number case
Date: Thu, 6 Nov 2014 13:50:32 +0200 [thread overview]
Message-ID: <20141106115032.GN1618@lahna.fi.intel.com> (raw)
In-Reply-To: <1415273003-27674-1-git-send-email-geert+renesas@glider.be>
On Thu, Nov 06, 2014 at 12:23:23PM +0100, Geert Uytterhoeven wrote:
> In the legacy case, led_dat->gpiod is initialized correctly, but
> overwritten later by template->gpiod, which is NULL, causing leds-gpio
> to fail with:
>
> gpiod_direction_output: invalid GPIO
> leds-gpio: probe of leds-gpio failed with error -22
>
> Move the initialization of led_dat->gpiod from template->gpiod up, and
> always use led_dat->gpiod later, to fix this.
>
> Fixes: 5c51277a9ababfa4 ("leds: leds-gpio: Add support for GPIO descriptors")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] leds: leds-gpio: Fix legacy GPIO number case
Date: Thu, 06 Nov 2014 11:50:32 +0000 [thread overview]
Message-ID: <20141106115032.GN1618@lahna.fi.intel.com> (raw)
In-Reply-To: <1415273003-27674-1-git-send-email-geert+renesas@glider.be>
On Thu, Nov 06, 2014 at 12:23:23PM +0100, Geert Uytterhoeven wrote:
> In the legacy case, led_dat->gpiod is initialized correctly, but
> overwritten later by template->gpiod, which is NULL, causing leds-gpio
> to fail with:
>
> gpiod_direction_output: invalid GPIO
> leds-gpio: probe of leds-gpio failed with error -22
>
> Move the initialization of led_dat->gpiod from template->gpiod up, and
> always use led_dat->gpiod later, to fix this.
>
> Fixes: 5c51277a9ababfa4 ("leds: leds-gpio: Add support for GPIO descriptors")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: mika.westerberg@linux.intel.com (Mika Westerberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds: leds-gpio: Fix legacy GPIO number case
Date: Thu, 6 Nov 2014 13:50:32 +0200 [thread overview]
Message-ID: <20141106115032.GN1618@lahna.fi.intel.com> (raw)
In-Reply-To: <1415273003-27674-1-git-send-email-geert+renesas@glider.be>
On Thu, Nov 06, 2014 at 12:23:23PM +0100, Geert Uytterhoeven wrote:
> In the legacy case, led_dat->gpiod is initialized correctly, but
> overwritten later by template->gpiod, which is NULL, causing leds-gpio
> to fail with:
>
> gpiod_direction_output: invalid GPIO
> leds-gpio: probe of leds-gpio failed with error -22
>
> Move the initialization of led_dat->gpiod from template->gpiod up, and
> always use led_dat->gpiod later, to fix this.
>
> Fixes: 5c51277a9ababfa4 ("leds: leds-gpio: Add support for GPIO descriptors")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2014-11-06 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 11:23 [PATCH] leds: leds-gpio: Fix legacy GPIO number case Geert Uytterhoeven
2014-11-06 11:23 ` Geert Uytterhoeven
2014-11-06 11:23 ` Geert Uytterhoeven
2014-11-06 11:50 ` Mika Westerberg [this message]
2014-11-06 11:50 ` Mika Westerberg
2014-11-06 11:50 ` Mika Westerberg
2014-11-06 17:31 ` Rafael J. Wysocki
2014-11-06 17:31 ` Rafael J. Wysocki
2014-11-06 17:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106115032.GN1618@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=arnd@arndb.de \
--cc=cooloney@gmail.com \
--cc=geert+renesas@glider.be \
--cc=grant.likely@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.