From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: pl330: Correct device assignment.
Date: Thu, 6 Nov 2014 18:28:52 +0530 [thread overview]
Message-ID: <20141106125852.GB1870@intel.com> (raw)
In-Reply-To: <545B5E03.3040809@arm.com>
On Thu, Nov 06, 2014 at 11:39:47AM +0000, Andrew Jackson wrote:
> Commit f6f2421c0a1c removed pl330_info structure by embedding it into
> pl330_dmac structure, but did not ensure that the dmac->ddma.dev
> pointer gets initialised before use. When dma_alloc_coherent() gets
> called on arm64 a WARN() gets triggered due to dev being NULL.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Andrew Jackson <Andrew.Jackson@arm.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dmaengine: pl330: Correct device assignment.
Date: Thu, 6 Nov 2014 18:28:52 +0530 [thread overview]
Message-ID: <20141106125852.GB1870@intel.com> (raw)
In-Reply-To: <545B5E03.3040809@arm.com>
On Thu, Nov 06, 2014 at 11:39:47AM +0000, Andrew Jackson wrote:
> Commit f6f2421c0a1c removed pl330_info structure by embedding it into
> pl330_dmac structure, but did not ensure that the dmac->ddma.dev
> pointer gets initialised before use. When dma_alloc_coherent() gets
> called on arm64 a WARN() gets triggered due to dev being NULL.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2014-11-06 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 11:39 [PATCH] dmaengine: pl330: Correct device assignment Andrew Jackson
2014-11-06 11:39 ` Andrew Jackson
2014-11-06 12:58 ` Vinod Koul [this message]
2014-11-06 12:58 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106125852.GB1870@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.