From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: mvebu: Let the device-tree determine smp_ops
Date: Thu, 6 Nov 2014 16:21:35 +0100 [thread overview]
Message-ID: <20141106152135.GC4974@lunn.ch> (raw)
In-Reply-To: <20141106155823.213f8811@free-electrons.com>
> > diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c
> > index 6478626..894974b 100644
> > --- a/arch/arm/mach-mvebu/board-v7.c
> > +++ b/arch/arm/mach-mvebu/board-v7.c
> > @@ -206,7 +206,6 @@ static const char * const armada_370_xp_dt_compat[] = {
> > DT_MACHINE_START(ARMADA_370_XP_DT, "Marvell Armada 370/XP (Device Tree)")
> > .l2c_aux_val = 0,
> > .l2c_aux_mask = ~0,
> > - .smp = smp_ops(armada_xp_smp_ops),
> > .init_machine = mvebu_dt_init,
> > .init_irq = mvebu_init_irq,
> > .restart = mvebu_restart,
>
> There is a very good reason to keep this .smp initialization. The
> Device Tree for Armada XP used to *not* have the enable-method
> property, since the SMP enable-method binding did not exist at the
> time we introduced the Armada XP SMP support. Therefore, if we want to
> keep backward compatibility with the old Armada XP DTs and continue to
> have SMP support working with those, we need to keep this .smp
> initialization essentially forever.
Hi Thomas
Any idea what order things are done?
Would it be possible to remove the .smp entry, and then in
mvebu_dt_init() check if there are smp operations set. If not, then
set them to armada_xp_smp_ops?
Andrew
next prev parent reply other threads:[~2014-11-06 15:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 4:49 [RFC PATCH] ARM: mvebu: Let the device-tree determine smp_ops Chris Packham
2014-11-06 14:49 ` Andrew Lunn
2014-11-06 19:49 ` Chris Packham
2014-11-06 20:03 ` Andrew Lunn
2014-11-06 14:58 ` Thomas Petazzoni
2014-11-06 15:21 ` Andrew Lunn [this message]
2014-11-06 15:33 ` Thomas Petazzoni
2014-11-06 19:56 ` Chris Packham
2014-11-06 20:16 ` Andrew Lunn
2014-11-07 2:33 ` [RFC PATCHv2] " Chris Packham
2014-11-16 22:40 ` [RFC PATCHv3] " Chris Packham
2014-11-17 8:45 ` [RFC PATCHv2] " Thomas Petazzoni
2014-11-17 8:56 ` Thomas Petazzoni
2014-11-17 20:46 ` Chris Packham
2014-11-17 23:34 ` Chris Packham
2014-11-18 0:31 ` Chris Packham
2014-11-18 8:21 ` Maxime Ripard
2014-11-18 19:43 ` Chris Packham
2014-11-18 23:37 ` [RFC PATCHv4] ARM: mvebu: use dt_fixup to provide fallback for enable-method Chris Packham
2014-11-18 8:16 ` [RFC PATCHv2] ARM: mvebu: Let the device-tree determine smp_ops Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106152135.GC4974@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.