All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-fbdev@vger.kernel.org, linux-pwm@vger.kernel.org,
	Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
	Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
Subject: Re: [PATCH 2/2] backlight: pwm: clean up pwm requested using legacy API
Date: Fri, 07 Nov 2014 11:50:09 +0000	[thread overview]
Message-ID: <20141107115009.GA3745@x1> (raw)
In-Reply-To: <20141106225420.GA2770@kroah.com>

On Thu, 06 Nov 2014, Greg KH wrote:

> On Fri, Nov 07, 2014 at 12:10:25AM +0200, Vladimir Zapolskiy wrote:
> > Hello Greg, Thierry,
> > 
> > On 11.10.2014 17:21, Greg KH wrote:
> > > On Sat, Oct 11, 2014 at 04:46:26PM +0300, Vladimir Zapolskiy wrote:
> > >> If PWM device is requested by means of legacy API pwm_request(), its
> > >> resources are not freed on module unbind, which may cause an oops on
> > >> access, e.g. by reading /sys/kernel/debug/pwm.
> > >>
> > >> Reported-by: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
> > >> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> > >> ---
> > >>  drivers/video/backlight/pwm_bl.c |    4 ++++
> > >>  1 file changed, 4 insertions(+)
> > > 
> > > <formletter>
> > > 
> > > This is not the correct way to submit patches for inclusion in the
> > > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > > for how to do this properly.
> > > 
> > > </formletter>
> > > --
> > 
> > could you please review the change? I believe it would be nice to have
> > oops fix in v3.18.
> 
> drivers/video/ is not under my control, so there's nothing I can do
> here, sorry...

I can apply this with Thierry's Ack.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-fbdev@vger.kernel.org, linux-pwm@vger.kernel.org,
	Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
	Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
Subject: Re: [PATCH 2/2] backlight: pwm: clean up pwm requested using legacy API
Date: Fri, 7 Nov 2014 11:50:09 +0000	[thread overview]
Message-ID: <20141107115009.GA3745@x1> (raw)
In-Reply-To: <20141106225420.GA2770@kroah.com>

On Thu, 06 Nov 2014, Greg KH wrote:

> On Fri, Nov 07, 2014 at 12:10:25AM +0200, Vladimir Zapolskiy wrote:
> > Hello Greg, Thierry,
> > 
> > On 11.10.2014 17:21, Greg KH wrote:
> > > On Sat, Oct 11, 2014 at 04:46:26PM +0300, Vladimir Zapolskiy wrote:
> > >> If PWM device is requested by means of legacy API pwm_request(), its
> > >> resources are not freed on module unbind, which may cause an oops on
> > >> access, e.g. by reading /sys/kernel/debug/pwm.
> > >>
> > >> Reported-by: Dmitry Eremin-Solenikov <dmitry_eremin@mentor.com>
> > >> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> > >> ---
> > >>  drivers/video/backlight/pwm_bl.c |    4 ++++
> > >>  1 file changed, 4 insertions(+)
> > > 
> > > <formletter>
> > > 
> > > This is not the correct way to submit patches for inclusion in the
> > > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > > for how to do this properly.
> > > 
> > > </formletter>
> > > --
> > 
> > could you please review the change? I believe it would be nice to have
> > oops fix in v3.18.
> 
> drivers/video/ is not under my control, so there's nothing I can do
> here, sorry...

I can apply this with Thierry's Ack.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2014-11-07 11:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11 13:46 [PATCH 0/2] backlight: pwm: fix oops on accessing removed legacy pwm device Vladimir Zapolskiy
2014-10-11 13:46 ` Vladimir Zapolskiy
2014-10-11 13:46 ` [PATCH 1/2] backlight: pwm: don't call legacy pwm request for device defined in dt Vladimir Zapolskiy
2014-10-11 13:46   ` Vladimir Zapolskiy
2014-10-11 14:21   ` Greg KH
2014-10-11 14:21     ` Greg KH
2014-11-07 13:48   ` Thierry Reding
2014-11-07 13:48     ` Thierry Reding
2014-11-07 14:19     ` Vladimir Zapolskiy
2014-11-07 14:19       ` Vladimir Zapolskiy
2014-11-07 14:57       ` Vladimir Zapolskiy
2014-11-07 14:57         ` Vladimir Zapolskiy
2014-12-01 14:47         ` Vladimir Zapolskiy
2014-12-01 14:47           ` Vladimir Zapolskiy
2015-01-21 13:18           ` Vladimir Zapolskiy
2015-01-21 13:18             ` Vladimir Zapolskiy
2015-06-12 11:31   ` Thierry Reding
2015-06-12 11:31     ` Thierry Reding
2015-06-12 12:57     ` Vladimir Zapolskiy
2015-06-12 12:57       ` Vladimir Zapolskiy
2015-06-12 12:57       ` Vladimir Zapolskiy
2015-06-12 13:19       ` Thierry Reding
2015-06-12 13:19         ` Thierry Reding
2014-10-11 13:46 ` [PATCH 2/2] backlight: pwm: clean up pwm requested using legacy API Vladimir Zapolskiy
2014-10-11 13:46   ` Vladimir Zapolskiy
2014-10-11 14:21   ` Greg KH
2014-10-11 14:21     ` Greg KH
2014-11-06 22:10     ` Vladimir Zapolskiy
2014-11-06 22:10       ` Vladimir Zapolskiy
2014-11-06 22:54       ` Greg KH
2014-11-06 22:54         ` Greg KH
2014-11-07 11:50         ` Lee Jones [this message]
2014-11-07 11:50           ` Lee Jones
2014-11-07 13:47   ` Thierry Reding
2014-11-07 13:47     ` Thierry Reding
2014-11-10 10:01   ` Lee Jones
2014-11-10 10:01     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141107115009.GA3745@x1 \
    --to=lee.jones@linaro.org \
    --cc=cooloney@gmail.com \
    --cc=dmitry_eremin@mentor.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.