From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: "Stéphane Marchesin" <marcheu@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/panel: update innolux n116bge timings
Date: Fri, 7 Nov 2014 13:13:25 +0100 [thread overview]
Message-ID: <20141107121322.GA11084@ulmo.nvidia.com> (raw)
In-Reply-To: <CAGS+omBFQi2BokDCV8DpRYwKs7DsGWKfxtDu8+7zJfKatL0SeA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1602 bytes --]
On Mon, Sep 22, 2014 at 06:12:41PM +0800, Daniel Kurtz wrote:
> On Mon, Sep 22, 2014 at 4:39 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> >
> > On Tue, Sep 02, 2014 at 10:56:46AM +0800, Daniel Kurtz wrote:
> > > There are several different models of N116BGE. According to the commit
> > > that added innolux_n116bge_mode [0], this N116BGE is for the eDP variety.
> > >
> > > [0] commit 0a2288c06aab73c966e82045c8f20b0e713baf2a
> > > Author: Thierry Reding <treding@nvidia.com>
> > > Date: Thu Jul 3 14:02:59 2014 +0200
> > >
> > > drm/panel: simple: Add Innolux N116BGE panel support
> > >
> > > The clock and htotal values from add by that patch are out of spec according to
> > > the datasheets I have seen for the eDP N116BGE (-EA2 and -EB2).
> >
> > Does out of spec imply that these timings aren't working for you?
>
> No, I didn't even try with your values, actually.
> Out of spec just means that the numbers do not fall between Min and
> Max on the datasheet:
>
> 72.6 <= DCLK <= 80.24 vs. 71
> 1506 <= htotal <= 1716 vs. 1500
>
> > > This patch changes the values to the "Typ" values on the datasheet.
> >
> > The original patch was based on -E42 of the datasheet. But I can run
> > some tests to see if the timings in this patch work on the panel that I
> > have. If so I guess the easiest would be to apply this.
>
> Thanks!
Took me a while longer to test this than I had expected. Turns out the
Tegra132 Norrin board that I have works with the timings you provide in
this patch too, so I'm going to apply this patch.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"David Airlie" <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Stéphane Marchesin" <marcheu@chromium.org>
Subject: Re: [PATCH] drm/panel: update innolux n116bge timings
Date: Fri, 7 Nov 2014 13:13:25 +0100 [thread overview]
Message-ID: <20141107121322.GA11084@ulmo.nvidia.com> (raw)
In-Reply-To: <CAGS+omBFQi2BokDCV8DpRYwKs7DsGWKfxtDu8+7zJfKatL0SeA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]
On Mon, Sep 22, 2014 at 06:12:41PM +0800, Daniel Kurtz wrote:
> On Mon, Sep 22, 2014 at 4:39 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> >
> > On Tue, Sep 02, 2014 at 10:56:46AM +0800, Daniel Kurtz wrote:
> > > There are several different models of N116BGE. According to the commit
> > > that added innolux_n116bge_mode [0], this N116BGE is for the eDP variety.
> > >
> > > [0] commit 0a2288c06aab73c966e82045c8f20b0e713baf2a
> > > Author: Thierry Reding <treding@nvidia.com>
> > > Date: Thu Jul 3 14:02:59 2014 +0200
> > >
> > > drm/panel: simple: Add Innolux N116BGE panel support
> > >
> > > The clock and htotal values from add by that patch are out of spec according to
> > > the datasheets I have seen for the eDP N116BGE (-EA2 and -EB2).
> >
> > Does out of spec imply that these timings aren't working for you?
>
> No, I didn't even try with your values, actually.
> Out of spec just means that the numbers do not fall between Min and
> Max on the datasheet:
>
> 72.6 <= DCLK <= 80.24 vs. 71
> 1506 <= htotal <= 1716 vs. 1500
>
> > > This patch changes the values to the "Typ" values on the datasheet.
> >
> > The original patch was based on -E42 of the datasheet. But I can run
> > some tests to see if the timings in this patch work on the panel that I
> > have. If so I guess the easiest would be to apply this.
>
> Thanks!
Took me a while longer to test this than I had expected. Turns out the
Tegra132 Norrin board that I have works with the timings you provide in
this patch too, so I'm going to apply this patch.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-07 12:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 2:56 [PATCH] drm/panel: update innolux n116bge timings Daniel Kurtz
2014-09-02 2:56 ` Daniel Kurtz
2014-09-21 7:53 ` Daniel Kurtz
2014-09-21 7:53 ` Daniel Kurtz
2014-09-22 8:35 ` Thierry Reding
2014-09-22 8:35 ` Thierry Reding
2014-09-22 8:39 ` Thierry Reding
2014-09-22 8:39 ` Thierry Reding
2014-09-22 10:12 ` Daniel Kurtz
2014-09-22 10:12 ` Daniel Kurtz
2014-09-22 10:43 ` Thierry Reding
2014-09-22 10:43 ` Thierry Reding
2014-11-07 12:13 ` Thierry Reding [this message]
2014-11-07 12:13 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107121322.GA11084@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcheu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.