From: Mark Brown <broonie@kernel.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, lgirdwood@gmail.com, nm@ti.com,
tony@atomide.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [REPOST PATCH 1/2] ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks
Date: Fri, 7 Nov 2014 15:22:01 +0000 [thread overview]
Message-ID: <20141107152201.GS8509@sirena.org.uk> (raw)
In-Reply-To: <1412949989-20186-2-git-send-email-t-kristo@ti.com>
[-- Attachment #1: Type: text/plain, Size: 356 bytes --]
On Fri, Oct 10, 2014 at 05:06:28PM +0300, Tero Kristo wrote:
> - dev->platform_data = &twl_gpio_auxdata;
> + if (!strcmp("twl4030-gpio", dev_name(dev)))
> + dev->platform_data = &twl_gpio_auxdata;
> + else
> + dev->platform_data = omap_twl_match_regulator(dev);
Looking at this idiom here I'd expect that we'd be adding another string
comparison here?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [REPOST PATCH 1/2] ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks
Date: Fri, 7 Nov 2014 15:22:01 +0000 [thread overview]
Message-ID: <20141107152201.GS8509@sirena.org.uk> (raw)
In-Reply-To: <1412949989-20186-2-git-send-email-t-kristo@ti.com>
On Fri, Oct 10, 2014 at 05:06:28PM +0300, Tero Kristo wrote:
> - dev->platform_data = &twl_gpio_auxdata;
> + if (!strcmp("twl4030-gpio", dev_name(dev)))
> + dev->platform_data = &twl_gpio_auxdata;
> + else
> + dev->platform_data = omap_twl_match_regulator(dev);
Looking at this idiom here I'd expect that we'd be adding another string
comparison here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141107/de6c774f/attachment.sig>
next prev parent reply other threads:[~2014-11-07 15:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 14:06 [REPOST PATCH 0/2] ARM: OMAP3+: VCVP mapping fixes to get DVFS working Tero Kristo
2014-10-10 14:06 ` Tero Kristo
2014-10-10 14:06 ` [REPOST PATCH 1/2] ARM: OMAP3+: TWL: add support for mapping platform data via pdata-quirks Tero Kristo
2014-10-10 14:06 ` Tero Kristo
2014-11-07 15:22 ` Mark Brown [this message]
2014-11-07 15:22 ` Mark Brown
2014-11-07 17:13 ` Tero Kristo
2014-11-07 17:13 ` Tero Kristo
2014-10-10 14:06 ` [REPOST PATCH 2/2] regulator: twl: use platform data in the DT based boot also Tero Kristo
2014-10-10 14:06 ` Tero Kristo
2014-10-16 14:21 ` [REPOST PATCH 0/2] ARM: OMAP3+: VCVP mapping fixes to get DVFS working Enric Balletbo Serra
2014-10-16 14:21 ` Enric Balletbo Serra
2014-10-17 5:55 ` Tero Kristo
2014-10-17 5:55 ` Tero Kristo
2014-10-17 11:55 ` Enric Balletbo Serra
2014-10-17 11:55 ` Enric Balletbo Serra
2014-10-17 12:35 ` Tero Kristo
2014-10-17 12:35 ` Tero Kristo
2014-10-17 12:48 ` Enric Balletbo Serra
2014-10-17 12:48 ` Enric Balletbo Serra
2014-10-17 13:54 ` Nishanth Menon
2014-10-17 13:54 ` Nishanth Menon
2014-10-17 13:56 ` Tero Kristo
2014-10-17 13:56 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107152201.GS8509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.