All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org>
Cc: Mauro Carvalho Chehab
	<m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Hans Verkuil
	<hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
	Laurent Pinchart
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Guennadi Liakhovetski
	<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH v4 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel
Date: Sat, 8 Nov 2014 01:38:41 +0100	[thread overview]
Message-ID: <20141108013841.1f3f1bc2@bbrezillon> (raw)
In-Reply-To: <545D4BFD.6000206-X3B1VOXEql0@public.gmane.org>

On Sat, 08 Nov 2014 00:47:25 +0200
Sakari Ailus <sakari.ailus-X3B1VOXEql0@public.gmane.org> wrote:

> Hi Boris,
> 
> Boris Brezillon wrote:
> > @@ -102,6 +113,7 @@ enum v4l2_mbus_pixelcode {
> >  
> >  	V4L2_MBUS_FROM_MEDIA_BUS_FMT(AHSV8888_1X32),
> >  };
> > +#endif /* __KERNEL__ */
> >  
> >  /**
> >   * struct v4l2_mbus_framefmt - frame format on the media bus
> 
> Was it intended to be this way, or did I miss something? I'd put this to
> beginning of the file, as Hans suggested.

Oops, I forgot to move the struct.

> 
> With this matter sorted out, for the set:
> 
> Acked-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel
Date: Sat, 8 Nov 2014 01:38:41 +0100	[thread overview]
Message-ID: <20141108013841.1f3f1bc2@bbrezillon> (raw)
In-Reply-To: <545D4BFD.6000206@iki.fi>

On Sat, 08 Nov 2014 00:47:25 +0200
Sakari Ailus <sakari.ailus@iki.fi> wrote:

> Hi Boris,
> 
> Boris Brezillon wrote:
> > @@ -102,6 +113,7 @@ enum v4l2_mbus_pixelcode {
> >  
> >  	V4L2_MBUS_FROM_MEDIA_BUS_FMT(AHSV8888_1X32),
> >  };
> > +#endif /* __KERNEL__ */
> >  
> >  /**
> >   * struct v4l2_mbus_framefmt - frame format on the media bus
> 
> Was it intended to be this way, or did I miss something? I'd put this to
> beginning of the file, as Hans suggested.

Oops, I forgot to move the struct.

> 
> With this matter sorted out, for the set:
> 
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH v4 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel
Date: Sat, 8 Nov 2014 01:38:41 +0100	[thread overview]
Message-ID: <20141108013841.1f3f1bc2@bbrezillon> (raw)
In-Reply-To: <545D4BFD.6000206@iki.fi>

On Sat, 08 Nov 2014 00:47:25 +0200
Sakari Ailus <sakari.ailus@iki.fi> wrote:

> Hi Boris,
> 
> Boris Brezillon wrote:
> > @@ -102,6 +113,7 @@ enum v4l2_mbus_pixelcode {
> >  
> >  	V4L2_MBUS_FROM_MEDIA_BUS_FMT(AHSV8888_1X32),
> >  };
> > +#endif /* __KERNEL__ */
> >  
> >  /**
> >   * struct v4l2_mbus_framefmt - frame format on the media bus
> 
> Was it intended to be this way, or did I miss something? I'd put this to
> beginning of the file, as Hans suggested.

Oops, I forgot to move the struct.

> 
> With this matter sorted out, for the set:
> 
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2014-11-08  0:38 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 14:07 [PATCH v3 00/10] [media] Make mediabus format subsystem neutral Boris Brezillon
2014-11-07 14:07 ` Boris Brezillon
2014-11-07 14:07 ` Boris Brezillon
2014-11-07 14:07 ` [PATCH v3 01/10] [media] Move mediabus format definition to a more standard place Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 15:24   ` Sakari Ailus
2014-11-07 15:24     ` Sakari Ailus
     [not found]     ` <20141107152416.GC3136-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2014-11-07 16:09       ` Boris Brezillon
2014-11-07 16:09         ` Boris Brezillon
2014-11-07 16:09         ` Boris Brezillon
2014-11-07 16:28     ` [PATCH v4 " Boris Brezillon
2014-11-07 16:28       ` Boris Brezillon
2014-11-07 16:28       ` Boris Brezillon
2014-11-07 14:07 ` [PATCH v3 02/10] [media] v4l: Update subdev-formats doc with new MEDIA_BUS_FMT values Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07 ` [PATCH v3 03/10] [media] Make use of the new media_bus_format definitions Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07 ` [PATCH v3 04/10] [media] i2c: Make use of media_bus_format enum Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
     [not found]   ` <1415369269-5064-5-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-11-08  9:23     ` Prabhakar Lad
2014-11-08  9:23       ` Prabhakar Lad
2014-11-07 14:07 ` [PATCH v3 05/10] [media] pci: Make use of MEDIA_BUS_FMT definitions Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07 ` [PATCH v3 06/10] [media] platform: Make use of media_bus_format enum Boris Brezillon
2014-11-08  9:18   ` Prabhakar Lad
2014-11-08  9:18     ` Prabhakar Lad
2014-11-11  4:42     ` Sekhar Nori
2014-11-11  4:42       ` Sekhar Nori
2014-11-11  7:49       ` Sekhar Nori
2014-11-11  7:49         ` Sekhar Nori
2014-11-07 14:07 ` [PATCH v3 08/10] staging: media: Make use of MEDIA_BUS_FMT_ definitions Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-08  9:11   ` Prabhakar Lad
2014-11-08  9:11     ` Prabhakar Lad
2014-11-08  9:11     ` Prabhakar Lad
2014-11-07 14:07 ` [PATCH v3 09/10] gpu: ipu-v3: Make use of media_bus_format enum Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 15:05   ` Philipp Zabel
2014-11-07 15:05     ` Philipp Zabel
2014-11-07 14:07 ` [PATCH v3 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:07   ` Boris Brezillon
2014-11-07 14:47   ` Hans Verkuil
2014-11-07 14:47     ` Hans Verkuil
2014-11-07 14:47     ` Hans Verkuil
     [not found]     ` <545CDB8D.4080406-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2014-11-07 15:31       ` Boris Brezillon
2014-11-07 15:31         ` Boris Brezillon
2014-11-07 15:31         ` Boris Brezillon
2014-11-07 16:27     ` [PATCH v4 " Boris Brezillon
2014-11-07 16:27       ` Boris Brezillon
2014-11-07 16:27       ` Boris Brezillon
2014-11-07 22:47       ` Sakari Ailus
2014-11-07 22:47         ` Sakari Ailus
     [not found]         ` <545D4BFD.6000206-X3B1VOXEql0@public.gmane.org>
2014-11-08  0:38           ` Boris Brezillon [this message]
2014-11-08  0:38             ` Boris Brezillon
2014-11-08  0:38             ` Boris Brezillon
     [not found] ` <1415369269-5064-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-11-07 14:07   ` [PATCH v3 07/10] [media] usb: Make use of media_bus_format enum Boris Brezillon
2014-11-07 14:07     ` Boris Brezillon
2014-11-07 14:07     ` Boris Brezillon
2014-11-07 14:51   ` [PATCH v3 00/10] [media] Make mediabus format subsystem neutral Hans Verkuil
2014-11-07 14:51     ` Hans Verkuil
2014-11-07 14:51     ` Hans Verkuil
2014-11-08 15:47   ` [PATCH v5 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel Boris Brezillon
2014-11-08 15:47     ` Boris Brezillon
2014-11-08 15:47     ` Boris Brezillon
2014-11-10 11:09     ` Hans Verkuil
2014-11-10 11:09       ` Hans Verkuil
2014-11-10 11:09       ` Hans Verkuil
     [not found]       ` <54609CDF.8030303-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2014-11-10 17:02         ` Boris Brezillon
2014-11-10 17:02           ` Boris Brezillon
2014-11-10 17:02           ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141108013841.1f3f1bc2@bbrezillon \
    --to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
    --cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
    --cc=hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.