* [PATCH 1/1] dvb-usb-dvbsky: fix i2c adapter for sp2 device
@ 2014-11-08 8:34 Nibble Max
2014-11-09 21:57 ` Antti Palosaari
0 siblings, 1 reply; 2+ messages in thread
From: Nibble Max @ 2014-11-08 8:34 UTC (permalink / raw)
To: Olli Salonen; +Cc: linux-media, Antti Palosaari
It is wrong that sp2 device uses the i2c adapter from m88ds3103 return.
sp2 device sits on the same i2c bus with m88ds3103, not behind m88ds3103.
Signed-off-by: Nibble Max <nibble.max@gmail.com>
---
drivers/media/usb/dvb-usb-v2/dvbsky.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c
index c67a118..8be8447 100644
--- a/drivers/media/usb/dvb-usb-v2/dvbsky.c
+++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c
@@ -479,7 +479,7 @@ static int dvbsky_s960c_attach(struct dvb_usb_adapter *adap)
info.addr = 0x40;
info.platform_data = &sp2_config;
request_module("sp2");
- client_ci = i2c_new_device(i2c_adapter, &info);
+ client_ci = i2c_new_device(&d->i2c_adap, &info);
if (client_ci == NULL || client_ci->dev.driver == NULL) {
ret = -ENODEV;
goto fail_ci_device;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] dvb-usb-dvbsky: fix i2c adapter for sp2 device
2014-11-08 8:34 [PATCH 1/1] dvb-usb-dvbsky: fix i2c adapter for sp2 device Nibble Max
@ 2014-11-09 21:57 ` Antti Palosaari
0 siblings, 0 replies; 2+ messages in thread
From: Antti Palosaari @ 2014-11-09 21:57 UTC (permalink / raw)
To: Nibble Max, Olli Salonen; +Cc: linux-media
On 11/08/2014 10:34 AM, Nibble Max wrote:
> It is wrong that sp2 device uses the i2c adapter from m88ds3103 return.
> sp2 device sits on the same i2c bus with m88ds3103, not behind m88ds3103.
>
> Signed-off-by: Nibble Max <nibble.max@gmail.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Antti
> ---
> drivers/media/usb/dvb-usb-v2/dvbsky.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> index c67a118..8be8447 100644
> --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c
> +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> @@ -479,7 +479,7 @@ static int dvbsky_s960c_attach(struct dvb_usb_adapter *adap)
> info.addr = 0x40;
> info.platform_data = &sp2_config;
> request_module("sp2");
> - client_ci = i2c_new_device(i2c_adapter, &info);
> + client_ci = i2c_new_device(&d->i2c_adap, &info);
> if (client_ci == NULL || client_ci->dev.driver == NULL) {
> ret = -ENODEV;
> goto fail_ci_device;
>
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-09 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-08 8:34 [PATCH 1/1] dvb-usb-dvbsky: fix i2c adapter for sp2 device Nibble Max
2014-11-09 21:57 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.