From: Pavel Machek <pavel@ucw.cz>
To: Mark Brown <broonie@debian.org>
Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, freemangordon@abv.bg,
peter.ujfalusi@ti.com, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org
Subject: Re: sound: enable sound support on n900 on devicetree-based boot
Date: Sun, 9 Nov 2014 20:39:53 +0100 [thread overview]
Message-ID: <20141109193953.GA7852@amd> (raw)
In-Reply-To: <20141109123753.GO2722@sirena.org.uk>
On Sun 2014-11-09 12:37:53, Mark Brown wrote:
> On Sun, Nov 09, 2014 at 01:02:22PM +0100, Pavel Machek wrote:
> >
> > With device tree, it is possible (and encouraged) to build N900
> > kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable
> > the driver build in this case.
>
> Please do try to use subject lines reflecting the style for the
> subsystem.
Ok.
> > config SND_OMAP_SOC_RX51
> > tristate "SoC Audio support for Nokia RX-51"
> > - depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
> > + depends on SND_OMAP_SOC && ARM && I2C
>
> Please also update the config text so users have a chance to figure out
> that this driver is the one they need for their system - I guess most
> people won't know what RX-51 is.
Actually help text below already explains that. I'll update tristate
text, too.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: sound: enable sound support on n900 on devicetree-based boot
Date: Sun, 9 Nov 2014 20:39:53 +0100 [thread overview]
Message-ID: <20141109193953.GA7852@amd> (raw)
In-Reply-To: <20141109123753.GO2722@sirena.org.uk>
On Sun 2014-11-09 12:37:53, Mark Brown wrote:
> On Sun, Nov 09, 2014 at 01:02:22PM +0100, Pavel Machek wrote:
> >
> > With device tree, it is possible (and encouraged) to build N900
> > kernels without CONFIG_MACH_NOKIA_RX51. Update config file to enable
> > the driver build in this case.
>
> Please do try to use subject lines reflecting the style for the
> subsystem.
Ok.
> > config SND_OMAP_SOC_RX51
> > tristate "SoC Audio support for Nokia RX-51"
> > - depends on SND_OMAP_SOC && ARM && (MACH_NOKIA_RX51 || COMPILE_TEST) && I2C
> > + depends on SND_OMAP_SOC && ARM && I2C
>
> Please also update the config text so users have a chance to figure out
> that this driver is the one they need for their system - I guess most
> people won't know what RX-51 is.
Actually help text below already explains that. I'll update tristate
text, too.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-11-09 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 12:02 sound: enable sound support on n900 on devicetree-based boot Pavel Machek
2014-11-09 12:02 ` Pavel Machek
2014-11-09 12:37 ` Mark Brown
2014-11-09 12:37 ` Mark Brown
2014-11-09 19:39 ` Pavel Machek [this message]
2014-11-09 19:39 ` Pavel Machek
2014-11-09 19:41 ` ASoC: omap: " Pavel Machek
2014-11-09 19:41 ` Pavel Machek
2014-11-10 12:13 ` Mark Brown
2014-11-10 12:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141109193953.GA7852@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@debian.org \
--cc=freemangordon@abv.bg \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tiwai@suse.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.