From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/13] ARM: STi: DT: STiH410: Add defines for STiH410 DT clocks
Date: Mon, 10 Nov 2014 10:08:40 +0000 [thread overview]
Message-ID: <20141110100840.GO21424@x1> (raw)
In-Reply-To: <1415361475-6218-9-git-send-email-peter.griffin@linaro.org>
On Fri, 07 Nov 2014, Peter Griffin wrote:
> Although most clock outputs are the same as stih407 SoC, stih410
> also has some additional new clock outputs.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> include/dt-bindings/clock/stih410-clks.h | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 include/dt-bindings/clock/stih410-clks.h
>
> diff --git a/include/dt-bindings/clock/stih410-clks.h b/include/dt-bindings/clock/stih410-clks.h
> new file mode 100644
> index 0000000..2c5d6ff
> --- /dev/null
> +++ b/include/dt-bindings/clock/stih410-clks.h
> @@ -0,0 +1,24 @@
> +/*
> + * This header provides constants clk index STMicroelectronics
> + * STiH410 SoC.
> + */
> +#ifndef _DT_BINDINGS_CLK_STIH410
> +#define _DT_BINDINGS_CLK_STIH410
> +#include "stih407-clks.h"
Nit: Please add a newline between the sentries and #include.
Apart from that, looks good:
Acked-by: Lee Jones <lee.jones@linaro.org>
> +/* STiH410 introduces new clock outputs compared to STiH407 */
> +
> +/* CLOCKGEN C0 */
> +#define CLK_TX_ICN_HADES 32
> +#define CLK_RX_ICN_HADES 33
> +#define CLK_ICN_REG_16 34
> +#define CLK_PP_HADES 35
> +#define CLK_CLUST_HADES 36
> +#define CLK_HWPE_HADES 37
> +#define CLK_FC_HADES 38
> +
> +/* CLOCKGEN D0 */
> +#define CLK_PCMR10_MASTER 4
> +#define CLK_USB2_PHY 5
> +
> +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
maxime.coquelin-qxv4g6HH51o@public.gmane.org,
patrice.chotard-qxv4g6HH51o@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 08/13] ARM: STi: DT: STiH410: Add defines for STiH410 DT clocks
Date: Mon, 10 Nov 2014 10:08:40 +0000 [thread overview]
Message-ID: <20141110100840.GO21424@x1> (raw)
In-Reply-To: <1415361475-6218-9-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Fri, 07 Nov 2014, Peter Griffin wrote:
> Although most clock outputs are the same as stih407 SoC, stih410
> also has some additional new clock outputs.
>
> Signed-off-by: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> include/dt-bindings/clock/stih410-clks.h | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 include/dt-bindings/clock/stih410-clks.h
>
> diff --git a/include/dt-bindings/clock/stih410-clks.h b/include/dt-bindings/clock/stih410-clks.h
> new file mode 100644
> index 0000000..2c5d6ff
> --- /dev/null
> +++ b/include/dt-bindings/clock/stih410-clks.h
> @@ -0,0 +1,24 @@
> +/*
> + * This header provides constants clk index STMicroelectronics
> + * STiH410 SoC.
> + */
> +#ifndef _DT_BINDINGS_CLK_STIH410
> +#define _DT_BINDINGS_CLK_STIH410
> +#include "stih407-clks.h"
Nit: Please add a newline between the sentries and #include.
Apart from that, looks good:
Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> +/* STiH410 introduces new clock outputs compared to STiH407 */
> +
> +/* CLOCKGEN C0 */
> +#define CLK_TX_ICN_HADES 32
> +#define CLK_RX_ICN_HADES 33
> +#define CLK_ICN_REG_16 34
> +#define CLK_PP_HADES 35
> +#define CLK_CLUST_HADES 36
> +#define CLK_HWPE_HADES 37
> +#define CLK_FC_HADES 38
> +
> +/* CLOCKGEN D0 */
> +#define CLK_PCMR10_MASTER 4
> +#define CLK_USB2_PHY 5
> +
> +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
maxime.coquelin@st.com, patrice.chotard@st.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 08/13] ARM: STi: DT: STiH410: Add defines for STiH410 DT clocks
Date: Mon, 10 Nov 2014 10:08:40 +0000 [thread overview]
Message-ID: <20141110100840.GO21424@x1> (raw)
In-Reply-To: <1415361475-6218-9-git-send-email-peter.griffin@linaro.org>
On Fri, 07 Nov 2014, Peter Griffin wrote:
> Although most clock outputs are the same as stih407 SoC, stih410
> also has some additional new clock outputs.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> include/dt-bindings/clock/stih410-clks.h | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 include/dt-bindings/clock/stih410-clks.h
>
> diff --git a/include/dt-bindings/clock/stih410-clks.h b/include/dt-bindings/clock/stih410-clks.h
> new file mode 100644
> index 0000000..2c5d6ff
> --- /dev/null
> +++ b/include/dt-bindings/clock/stih410-clks.h
> @@ -0,0 +1,24 @@
> +/*
> + * This header provides constants clk index STMicroelectronics
> + * STiH410 SoC.
> + */
> +#ifndef _DT_BINDINGS_CLK_STIH410
> +#define _DT_BINDINGS_CLK_STIH410
> +#include "stih407-clks.h"
Nit: Please add a newline between the sentries and #include.
Apart from that, looks good:
Acked-by: Lee Jones <lee.jones@linaro.org>
> +/* STiH410 introduces new clock outputs compared to STiH407 */
> +
> +/* CLOCKGEN C0 */
> +#define CLK_TX_ICN_HADES 32
> +#define CLK_RX_ICN_HADES 33
> +#define CLK_ICN_REG_16 34
> +#define CLK_PP_HADES 35
> +#define CLK_CLUST_HADES 36
> +#define CLK_HWPE_HADES 37
> +#define CLK_FC_HADES 38
> +
> +/* CLOCKGEN D0 */
> +#define CLK_PCMR10_MASTER 4
> +#define CLK_USB2_PHY 5
> +
> +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-11-10 10:08 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 11:57 [PATCH 00/13] Add stih410 SoC and USB2/1.1 support Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` [PATCH 01/13] ARM: STi: DT: STiH416: Add pinctl setup for usb controllers Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:50 ` Lee Jones
2014-11-10 10:50 ` Lee Jones
2014-11-07 11:57 ` [PATCH 02/13] ARM: STi: DT: STiH416: Add DT node for the stih415/6 usb2 phy Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:49 ` Lee Jones
2014-11-10 10:49 ` Lee Jones
2014-11-10 10:49 ` Lee Jones
2014-11-12 13:55 ` Peter Griffin
2014-11-12 13:55 ` Peter Griffin
2014-11-07 11:57 ` [PATCH 03/13] ARM: STi: DT: STiH416: Add DT nodes for the ehci and ohci usb controllers Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 12:08 ` Arnd Bergmann
2014-11-07 12:08 ` Arnd Bergmann
2014-11-07 12:08 ` Arnd Bergmann
2014-11-12 13:44 ` Peter Griffin
2014-11-12 13:44 ` Peter Griffin
2014-11-07 11:57 ` [PATCH 04/13] ARM: multi_v7_defconfig: Enable st ohci and ehci HCD drivers Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:48 ` Lee Jones
2014-11-10 10:48 ` Lee Jones
2014-11-10 10:48 ` Lee Jones
2014-11-07 11:57 ` [PATCH 05/13] ARM: multi_v7_defconfig: Enable stih415/6 usb2 phy driver Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:47 ` Lee Jones
2014-11-10 10:47 ` Lee Jones
2014-11-10 10:47 ` Lee Jones
2014-11-07 11:57 ` [PATCH 06/13] ARM: multi_v7_defconfig: Enable stih407 usb picophy Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:28 ` Lee Jones
2014-11-10 10:28 ` Lee Jones
2014-11-07 11:57 ` [PATCH 07/13] ARM: STi: DT: STiH407: Add usb2 picophy dt nodes Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:11 ` Lee Jones
2014-11-10 10:11 ` Lee Jones
2014-11-10 10:11 ` Lee Jones
2014-11-13 10:22 ` Peter Griffin
2014-11-13 10:22 ` Peter Griffin
2014-11-13 10:22 ` Peter Griffin
2014-11-07 11:57 ` [PATCH 08/13] ARM: STi: DT: STiH410: Add defines for STiH410 DT clocks Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:08 ` Lee Jones [this message]
2014-11-10 10:08 ` Lee Jones
2014-11-10 10:08 ` Lee Jones
2014-11-07 11:57 ` [PATCH 09/13] ARM: STi: DT: STiH410: Add pinctl config for usb controllers Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:06 ` Lee Jones
2014-11-10 10:06 ` Lee Jones
2014-11-10 10:06 ` Lee Jones
2014-11-07 11:57 ` [PATCH 10/13] ARM: STi: DT: STih410: Add dt nodes for the ehci / ohci " Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 9:26 ` Maxime Coquelin
2014-11-10 9:26 ` Maxime Coquelin
2014-11-10 9:26 ` Maxime Coquelin
2014-11-10 10:06 ` Lee Jones
2014-11-10 10:06 ` Lee Jones
2014-11-10 10:06 ` Lee Jones
2014-11-07 11:57 ` [PATCH 11/13] ARM: STi: DT: STih407: Abstract common dt nodes into shared files Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 12:10 ` Arnd Bergmann
2014-11-07 12:10 ` Arnd Bergmann
2014-11-07 11:57 ` [PATCH 12/13] ARM: STi: DT: STiH410: Add STiH410 SoC clock support Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 12:13 ` Arnd Bergmann
2014-11-07 12:13 ` Arnd Bergmann
2014-11-12 13:48 ` Peter Griffin
2014-11-12 13:48 ` Peter Griffin
2014-11-12 13:48 ` Peter Griffin
2014-11-10 9:20 ` Maxime Coquelin
2014-11-10 9:20 ` Maxime Coquelin
2014-11-10 9:20 ` Maxime Coquelin
2014-11-07 11:57 ` [PATCH 13/13] ARM: STi: DT: STih407: Add clk_ignore_unused to kernel bootargs Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-07 11:57 ` Peter Griffin
2014-11-10 10:04 ` Lee Jones
2014-11-10 10:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110100840.GO21424@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.