All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: OMAP2+: gpmc: Get rid of "ti,elm-id not found" warning
@ 2014-11-07 12:26 Roger Quadros
  2014-11-10 17:00 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Roger Quadros @ 2014-11-07 12:26 UTC (permalink / raw)
  To: tony; +Cc: ezequiel, linux-omap, pekon, Roger Quadros

OMAP3 and lower SoCs don't have the ELM module so this warning
is annoying. Get rid of it.

Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/mach-omap2/gpmc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 104bc2c..2334235 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2/gpmc.c
@@ -1394,8 +1394,6 @@ static int gpmc_probe_nand_child(struct platform_device *pdev,
 	if (gpmc_nand_data->elm_of_node == NULL)
 		gpmc_nand_data->elm_of_node =
 					of_parse_phandle(child, "elm_id", 0);
-	if (gpmc_nand_data->elm_of_node == NULL)
-		pr_warn("%s: ti,elm-id property not found\n", __func__);
 
 	/* select ecc-scheme for NAND */
 	if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: OMAP2+: gpmc: Get rid of "ti,elm-id not found" warning
  2014-11-07 12:26 [PATCH] ARM: OMAP2+: gpmc: Get rid of "ti,elm-id not found" warning Roger Quadros
@ 2014-11-10 17:00 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2014-11-10 17:00 UTC (permalink / raw)
  To: Roger Quadros; +Cc: ezequiel, linux-omap, pekon

* Roger Quadros <rogerq@ti.com> [141107 04:28]:
> OMAP3 and lower SoCs don't have the ELM module so this warning
> is annoying. Get rid of it.
> 
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/mach-omap2/gpmc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index 104bc2c..2334235 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -1394,8 +1394,6 @@ static int gpmc_probe_nand_child(struct platform_device *pdev,
>  	if (gpmc_nand_data->elm_of_node == NULL)
>  		gpmc_nand_data->elm_of_node =
>  					of_parse_phandle(child, "elm_id", 0);
> -	if (gpmc_nand_data->elm_of_node == NULL)
> -		pr_warn("%s: ti,elm-id property not found\n", __func__);
>  
>  	/* select ecc-scheme for NAND */
>  	if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {

I'll apply this into omap-for-v3.19/fixes-not-urgent as that's where
the various error and warning message fixes are.

Thanks,

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-10 17:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-07 12:26 [PATCH] ARM: OMAP2+: gpmc: Get rid of "ti,elm-id not found" warning Roger Quadros
2014-11-10 17:00 ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.