From: Robert Richter <rric@kernel.org>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Sunil Goutham <sgoutham@cavium.com>,
Robert Richter <rrichter@cavium.com>
Subject: Re: [PATCH] AHCI: Add generic MSI-X interrupt support to SATA PCI driver
Date: Mon, 10 Nov 2014 21:55:18 +0100 [thread overview]
Message-ID: <20141110205518.GY20170@rric.localhost> (raw)
In-Reply-To: <5460D100.90403@linux.intel.com>
On 10.11.14 22:51:44, Jiang Liu wrote:
> On 2014/11/10 13:30, Robert Richter wrote:
> > From: Sunil Goutham <sgoutham@cavium.com>
> > + /* only enable the first entry (entry.entry = 0) */
> > + rc = pci_enable_msix_exact(pdev, &entry, 1);
> > + if (rc < 0)
> > + return rc;
> > +
> > + pdev->irq = entry.vector;
> You can't overwrite pci_dev->irq for MSI-X, it's no way to
> recover original irq for INTx after unbinding ahci driver. Instead,
> you may access msi_desc->irq when requesting irq.
Right, I have a version now that determines the irq vector from
pdev->msi_list.
-Robert
WARNING: multiple messages have this Message-ID (diff)
From: rric@kernel.org (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] AHCI: Add generic MSI-X interrupt support to SATA PCI driver
Date: Mon, 10 Nov 2014 21:55:18 +0100 [thread overview]
Message-ID: <20141110205518.GY20170@rric.localhost> (raw)
In-Reply-To: <5460D100.90403@linux.intel.com>
On 10.11.14 22:51:44, Jiang Liu wrote:
> On 2014/11/10 13:30, Robert Richter wrote:
> > From: Sunil Goutham <sgoutham@cavium.com>
> > + /* only enable the first entry (entry.entry = 0) */
> > + rc = pci_enable_msix_exact(pdev, &entry, 1);
> > + if (rc < 0)
> > + return rc;
> > +
> > + pdev->irq = entry.vector;
> You can't overwrite pci_dev->irq for MSI-X, it's no way to
> recover original irq for INTx after unbinding ahci driver. Instead,
> you may access msi_desc->irq when requesting irq.
Right, I have a version now that determines the irq vector from
pdev->msi_list.
-Robert
next prev parent reply other threads:[~2014-11-10 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 5:30 [PATCH] AHCI: Add generic MSI-X interrupt support to SATA PCI driver Robert Richter
2014-11-10 5:30 ` Robert Richter
2014-11-10 14:51 ` Jiang Liu
2014-11-10 14:51 ` Jiang Liu
2014-11-10 20:55 ` Robert Richter [this message]
2014-11-10 20:55 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110205518.GY20170@rric.localhost \
--to=rric@kernel.org \
--cc=jiang.liu@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrichter@cavium.com \
--cc=sgoutham@cavium.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.