From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jingchang Lu <jingchang.lu@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [RESENDv5] serial: of-serial: fix up PM ops on no_console_suspend and port type
Date: Tue, 11 Nov 2014 14:27:20 +0900 [thread overview]
Message-ID: <20141111052720.GC24727@kroah.com> (raw)
In-Reply-To: <CAGVrzcamoYbdPijWtrU=ge+UE+g9zBHAG84PJB7G3EyA09jBWg@mail.gmail.com>
On Mon, Nov 10, 2014 at 08:30:36PM -0800, Florian Fainelli wrote:
> 2014-10-27 2:24 GMT-07:00 Jingchang Lu <jingchang.lu@freescale.com>:
> > This patch fixes commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
> > "serial: of-serial: add PM suspend/resume support", which disables
> > the uart clock on suspend, but also causes a hardware hang on register
> > access if no_console_suspend command line option is used.
> >
> > Also, not every of_serial device is an 8250 port, so the serial8250
> > suspend/resume functions should only be applied to a real 8250 port.
>
> Greg, can you pick this one and submit it for your next 3.18-rc
> submission? This fixes a regression when using "no_console_suspend"
> introduced by:
>
> 2dea53bf57783f243c892e99c10c6921e956aa7e ("serial: of-serial: add PM
> suspend/resume support") which has been merged during 3.18-rc1
Why can't I just revert that patch instead? This is really late in the
-rc cycle to be doing large fixes like this.
And this patch is already queued up for 3.19-rc1, so this is a mess...
Any objection to me just reverting
2dea53bf57783f243c892e99c10c6921e956aa7e, and then this one in my
tty-next branch as well, and then someone resending the original patch
in a format that actually works?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESENDv5] serial: of-serial: fix up PM ops on no_console_suspend and port type
Date: Tue, 11 Nov 2014 14:27:20 +0900 [thread overview]
Message-ID: <20141111052720.GC24727@kroah.com> (raw)
In-Reply-To: <CAGVrzcamoYbdPijWtrU=ge+UE+g9zBHAG84PJB7G3EyA09jBWg@mail.gmail.com>
On Mon, Nov 10, 2014 at 08:30:36PM -0800, Florian Fainelli wrote:
> 2014-10-27 2:24 GMT-07:00 Jingchang Lu <jingchang.lu@freescale.com>:
> > This patch fixes commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
> > "serial: of-serial: add PM suspend/resume support", which disables
> > the uart clock on suspend, but also causes a hardware hang on register
> > access if no_console_suspend command line option is used.
> >
> > Also, not every of_serial device is an 8250 port, so the serial8250
> > suspend/resume functions should only be applied to a real 8250 port.
>
> Greg, can you pick this one and submit it for your next 3.18-rc
> submission? This fixes a regression when using "no_console_suspend"
> introduced by:
>
> 2dea53bf57783f243c892e99c10c6921e956aa7e ("serial: of-serial: add PM
> suspend/resume support") which has been merged during 3.18-rc1
Why can't I just revert that patch instead? This is really late in the
-rc cycle to be doing large fixes like this.
And this patch is already queued up for 3.19-rc1, so this is a mess...
Any objection to me just reverting
2dea53bf57783f243c892e99c10c6921e956aa7e, and then this one in my
tty-next branch as well, and then someone resending the original patch
in a format that actually works?
thanks,
greg k-h
next prev parent reply other threads:[~2014-11-11 5:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 9:24 [RESENDv5] serial: of-serial: fix up PM ops on no_console_suspend and port type Jingchang Lu
2014-10-27 9:24 ` Jingchang Lu
2014-10-27 9:24 ` Jingchang Lu
2014-11-11 4:30 ` Florian Fainelli
2014-11-11 4:30 ` Florian Fainelli
2014-11-11 5:27 ` Greg KH [this message]
2014-11-11 5:27 ` Greg KH
2014-11-11 5:41 ` Jingchang Lu
2014-11-11 5:41 ` Jingchang Lu
2014-11-11 5:41 ` Jingchang Lu
2014-11-11 6:15 ` Florian Fainelli
2014-11-11 6:15 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2014-10-27 9:27 Jingchang Lu
2014-10-27 9:27 ` Jingchang Lu
2014-10-27 9:27 ` Jingchang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111052720.GC24727@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=f.fainelli@gmail.com \
--cc=jingchang.lu@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.