From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: vf-colibri: add USB regulators
Date: Tue, 11 Nov 2014 22:12:30 +0800 [thread overview]
Message-ID: <20141111141228.GB2704@dragon> (raw)
In-Reply-To: <1415106430-6271-4-git-send-email-stefan@agner.ch>
On Tue, Nov 04, 2014 at 02:07:10PM +0100, Stefan Agner wrote:
> Add structure of USB supply logic. Especially, the USB hosts power
> enable regulator is needed to control VBUS supply.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 45 ++++++++++++++++++++++++++++++-
> arch/arm/boot/dts/vf-colibri.dtsi | 12 +++++++++
> 2 files changed, 56 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> index 80e8fbc..eb4ca50 100644
> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> @@ -11,6 +11,41 @@
> chosen {
> bootargs = "console=ttyLP0,115200";
> };
> +
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sys_5v0_reg: regulator at 1 {
> + compatible = "regulator-fixed";
> + reg = <1>;
The numbering generally starts from 0 instead of 1.
> + regulator-name = "5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + };
> +
> + usbc_vbus_reg: regulator at 2 {
> + compatible = "regulator-fixed";
> + reg = <2>;
> + regulator-name = "usbc_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&sys_5v0_reg>;
> + };
> +
> + /* USBH_PEN */
> + usbh_vbus_reg: regulator at 3 {
> + compatible = "regulator-fixed";
> + reg = <3>;
> + regulator-name = "usbh_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> + vin-supply = <&sys_5v0_reg>;
> + };
> + };
> };
>
> &bl {
> @@ -51,4 +86,12 @@
>
> &uart2 {
> status = "okay";
> -};
> \ No newline at end of file
> +};
> +
> +&usbdev0 {
> + vbus-supply = <&usbc_vbus_reg>;
> +};
> +
> +&usbh1 {
> + vbus-supply = <&usbh_vbus_reg>;
> +};
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index 2371760..79ccfe2 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -163,5 +163,17 @@
> VF610_PAD_PTD3__UART2_CTS 0x21a1
> >;
> };
> +
> + pinctrl_usbh1_ext: gpio_usb_vbus {
> + fsl,pins = <
> + VF610_PAD_PTD4__GPIO_83 0x22ed
We used to know the GPIO usage by looking for the phandle reference to
the node. But it doesn't work for VF610 case now.
I guess this is for usbh_vbus_reg usage? It would be nice to have a
comment telling the usage of the GPIO.
> + >;
> + };
> +
> + pinctrl_usbdev0_ext: gpio_usb_cdet {
> + fsl,pins = <
> + VF610_PAD_PTC29__GPIO_102 0x22ed
How is this one used?
Shawn
> + >;
> + };
> };
> };
> --
> 2.1.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: dts: vf-colibri: add USB regulators
Date: Tue, 11 Nov 2014 22:12:30 +0800 [thread overview]
Message-ID: <20141111141228.GB2704@dragon> (raw)
In-Reply-To: <1415106430-6271-4-git-send-email-stefan-XLVq0VzYD2Y@public.gmane.org>
On Tue, Nov 04, 2014 at 02:07:10PM +0100, Stefan Agner wrote:
> Add structure of USB supply logic. Especially, the USB hosts power
> enable regulator is needed to control VBUS supply.
>
> Signed-off-by: Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>
> ---
> arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 45 ++++++++++++++++++++++++++++++-
> arch/arm/boot/dts/vf-colibri.dtsi | 12 +++++++++
> 2 files changed, 56 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> index 80e8fbc..eb4ca50 100644
> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> @@ -11,6 +11,41 @@
> chosen {
> bootargs = "console=ttyLP0,115200";
> };
> +
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sys_5v0_reg: regulator@1 {
> + compatible = "regulator-fixed";
> + reg = <1>;
The numbering generally starts from 0 instead of 1.
> + regulator-name = "5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + };
> +
> + usbc_vbus_reg: regulator@2 {
> + compatible = "regulator-fixed";
> + reg = <2>;
> + regulator-name = "usbc_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&sys_5v0_reg>;
> + };
> +
> + /* USBH_PEN */
> + usbh_vbus_reg: regulator@3 {
> + compatible = "regulator-fixed";
> + reg = <3>;
> + regulator-name = "usbh_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> + vin-supply = <&sys_5v0_reg>;
> + };
> + };
> };
>
> &bl {
> @@ -51,4 +86,12 @@
>
> &uart2 {
> status = "okay";
> -};
> \ No newline at end of file
> +};
> +
> +&usbdev0 {
> + vbus-supply = <&usbc_vbus_reg>;
> +};
> +
> +&usbh1 {
> + vbus-supply = <&usbh_vbus_reg>;
> +};
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index 2371760..79ccfe2 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -163,5 +163,17 @@
> VF610_PAD_PTD3__UART2_CTS 0x21a1
> >;
> };
> +
> + pinctrl_usbh1_ext: gpio_usb_vbus {
> + fsl,pins = <
> + VF610_PAD_PTD4__GPIO_83 0x22ed
We used to know the GPIO usage by looking for the phandle reference to
the node. But it doesn't work for VF610 case now.
I guess this is for usbh_vbus_reg usage? It would be nice to have a
comment telling the usage of the GPIO.
> + >;
> + };
> +
> + pinctrl_usbdev0_ext: gpio_usb_cdet {
> + fsl,pins = <
> + VF610_PAD_PTC29__GPIO_102 0x22ed
How is this one used?
Shawn
> + >;
> + };
> };
> };
> --
> 2.1.3
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@linaro.org>
To: Stefan Agner <stefan@agner.ch>
Cc: kernel@pengutronix.de, linus.walleij@linaro.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: vf-colibri: add USB regulators
Date: Tue, 11 Nov 2014 22:12:30 +0800 [thread overview]
Message-ID: <20141111141228.GB2704@dragon> (raw)
In-Reply-To: <1415106430-6271-4-git-send-email-stefan@agner.ch>
On Tue, Nov 04, 2014 at 02:07:10PM +0100, Stefan Agner wrote:
> Add structure of USB supply logic. Especially, the USB hosts power
> enable regulator is needed to control VBUS supply.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 45 ++++++++++++++++++++++++++++++-
> arch/arm/boot/dts/vf-colibri.dtsi | 12 +++++++++
> 2 files changed, 56 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> index 80e8fbc..eb4ca50 100644
> --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi
> @@ -11,6 +11,41 @@
> chosen {
> bootargs = "console=ttyLP0,115200";
> };
> +
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sys_5v0_reg: regulator@1 {
> + compatible = "regulator-fixed";
> + reg = <1>;
The numbering generally starts from 0 instead of 1.
> + regulator-name = "5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + };
> +
> + usbc_vbus_reg: regulator@2 {
> + compatible = "regulator-fixed";
> + reg = <2>;
> + regulator-name = "usbc_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&sys_5v0_reg>;
> + };
> +
> + /* USBH_PEN */
> + usbh_vbus_reg: regulator@3 {
> + compatible = "regulator-fixed";
> + reg = <3>;
> + regulator-name = "usbh_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> + vin-supply = <&sys_5v0_reg>;
> + };
> + };
> };
>
> &bl {
> @@ -51,4 +86,12 @@
>
> &uart2 {
> status = "okay";
> -};
> \ No newline at end of file
> +};
> +
> +&usbdev0 {
> + vbus-supply = <&usbc_vbus_reg>;
> +};
> +
> +&usbh1 {
> + vbus-supply = <&usbh_vbus_reg>;
> +};
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index 2371760..79ccfe2 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -163,5 +163,17 @@
> VF610_PAD_PTD3__UART2_CTS 0x21a1
> >;
> };
> +
> + pinctrl_usbh1_ext: gpio_usb_vbus {
> + fsl,pins = <
> + VF610_PAD_PTD4__GPIO_83 0x22ed
We used to know the GPIO usage by looking for the phandle reference to
the node. But it doesn't work for VF610 case now.
I guess this is for usbh_vbus_reg usage? It would be nice to have a
comment telling the usage of the GPIO.
> + >;
> + };
> +
> + pinctrl_usbdev0_ext: gpio_usb_cdet {
> + fsl,pins = <
> + VF610_PAD_PTC29__GPIO_102 0x22ed
How is this one used?
Shawn
> + >;
> + };
> };
> };
> --
> 2.1.3
>
next prev parent reply other threads:[~2014-11-11 14:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 13:07 [PATCH 0/3] ARM: dts: vf610: USB/GPIO fixes Stefan Agner
2014-11-04 13:07 ` Stefan Agner
2014-11-04 13:07 ` Stefan Agner
2014-11-04 13:07 ` [PATCH 1/3] ARM: dts: vf610: use new GPIO support Stefan Agner
2014-11-04 13:07 ` Stefan Agner
2014-11-04 13:07 ` [PATCH 2/3] ARM: dts: vf610: enable USB misc/phy nodes where necessary Stefan Agner
2014-11-04 13:07 ` Stefan Agner
2014-11-04 13:07 ` [PATCH 3/3] ARM: dts: vf-colibri: add USB regulators Stefan Agner
2014-11-04 13:07 ` Stefan Agner
2014-11-11 14:12 ` Shawn Guo [this message]
2014-11-11 14:12 ` Shawn Guo
2014-11-11 14:12 ` Shawn Guo
2014-11-12 15:51 ` Stefan Agner
2014-11-12 15:51 ` Stefan Agner
2014-11-13 1:23 ` Shawn Guo
2014-11-13 1:23 ` Shawn Guo
2014-11-13 1:23 ` Shawn Guo
2014-11-11 14:14 ` [PATCH 0/3] ARM: dts: vf610: USB/GPIO fixes Shawn Guo
2014-11-11 14:14 ` Shawn Guo
2014-11-11 14:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111141228.GB2704@dragon \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.