From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
xen-devel@lists.xensource.com, Michael Tokarev <mjt@tls.msk.ru>,
Chen Gang <gang.chen.5i5j@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
Date: Tue, 11 Nov 2014 09:24:00 -0500 [thread overview]
Message-ID: <20141111142359.GB8751@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1411111052280.26318@kaball.uk.xensource.com>
On Tue, Nov 11, 2014 at 10:53:01AM +0000, Stefano Stabellini wrote:
> On Tue, 11 Nov 2014, Chen Gang wrote:
> > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> > xen_main_loop_prepare() directly, need not use additional variable for
> > it.
The title of your patch should say 'variable'.
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
> > xen-hvm.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/xen-hvm.c b/xen-hvm.c
> > index 21f1cbb..7548794 100644
> > --- a/xen-hvm.c
> > +++ b/xen-hvm.c
> > @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
> > static void xen_hvm_change_state_handler(void *opaque, int running,
> > RunState rstate)
> > {
> > - XenIOState *xstate = opaque;
> > if (running) {
> > - xen_main_loop_prepare(xstate);
> > + xen_main_loop_prepare((XenIOState *)opaque);
> > }
> > }
> >
> > --
> > 1.8.5.2 (Apple Git-48)
> >
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
xen-devel@lists.xensource.com, Michael Tokarev <mjt@tls.msk.ru>,
Chen Gang <gang.chen.5i5j@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
Date: Tue, 11 Nov 2014 09:24:00 -0500 [thread overview]
Message-ID: <20141111142359.GB8751@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1411111052280.26318@kaball.uk.xensource.com>
On Tue, Nov 11, 2014 at 10:53:01AM +0000, Stefano Stabellini wrote:
> On Tue, 11 Nov 2014, Chen Gang wrote:
> > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> > xen_main_loop_prepare() directly, need not use additional variable for
> > it.
The title of your patch should say 'variable'.
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
> > xen-hvm.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/xen-hvm.c b/xen-hvm.c
> > index 21f1cbb..7548794 100644
> > --- a/xen-hvm.c
> > +++ b/xen-hvm.c
> > @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
> > static void xen_hvm_change_state_handler(void *opaque, int running,
> > RunState rstate)
> > {
> > - XenIOState *xstate = opaque;
> > if (running) {
> > - xen_main_loop_prepare(xstate);
> > + xen_main_loop_prepare((XenIOState *)opaque);
> > }
> > }
> >
> > --
> > 1.8.5.2 (Apple Git-48)
> >
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
xen-devel@lists.xensource.com, Michael Tokarev <mjt@tls.msk.ru>,
Chen Gang <gang.chen.5i5j@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'
Date: Tue, 11 Nov 2014 09:24:00 -0500 [thread overview]
Message-ID: <20141111142359.GB8751@konrad-lan.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1411111052280.26318@kaball.uk.xensource.com>
On Tue, Nov 11, 2014 at 10:53:01AM +0000, Stefano Stabellini wrote:
> On Tue, 11 Nov 2014, Chen Gang wrote:
> > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to
> > xen_main_loop_prepare() directly, need not use additional variable for
> > it.
The title of your patch should say 'variable'.
> >
> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
>
> > xen-hvm.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/xen-hvm.c b/xen-hvm.c
> > index 21f1cbb..7548794 100644
> > --- a/xen-hvm.c
> > +++ b/xen-hvm.c
> > @@ -993,9 +993,8 @@ static void xen_main_loop_prepare(XenIOState *state)
> > static void xen_hvm_change_state_handler(void *opaque, int running,
> > RunState rstate)
> > {
> > - XenIOState *xstate = opaque;
> > if (running) {
> > - xen_main_loop_prepare(xstate);
> > + xen_main_loop_prepare((XenIOState *)opaque);
> > }
> > }
> >
> > --
> > 1.8.5.2 (Apple Git-48)
> >
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-11-11 15:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 9:23 [Qemu-trivial] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate' Chen Gang
2014-11-11 9:23 ` Chen Gang
2014-11-11 9:23 ` [Qemu-devel] " Chen Gang
2014-11-11 10:53 ` [Qemu-trivial] " Stefano Stabellini
2014-11-11 10:53 ` Stefano Stabellini
2014-11-11 10:53 ` [Qemu-devel] " Stefano Stabellini
2014-11-11 14:24 ` Konrad Rzeszutek Wilk [this message]
2014-11-11 14:24 ` Konrad Rzeszutek Wilk
2014-11-11 14:24 ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
2014-11-11 14:32 ` [Qemu-trivial] " Chen Gang
2014-11-11 14:32 ` Chen Gang
2014-11-11 14:32 ` [Qemu-devel] " Chen Gang
2014-11-11 14:37 ` [Qemu-trivial] " Michael Tokarev
2014-11-11 14:37 ` [Qemu-devel] " Michael Tokarev
2014-11-11 14:26 ` [Qemu-trivial] " Michael Tokarev
2014-11-11 14:26 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111142359.GB8751@konrad-lan.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.