All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	jdelvare@suse.de, benh@au1.ibm.com, linux-kernel@vger.kernel.org,
	michaele@au1.ibm.com, linuxppc-dev@lists.ozlabs.org,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device
Date: Tue, 11 Nov 2014 18:37:52 +0000	[thread overview]
Message-ID: <20141111183752.GA23539@roeck-us.net> (raw)
In-Reply-To: <1415574297.29291.3.camel@concordia>

On Mon, Nov 10, 2014 at 10:04:57AM +1100, Michael Ellerman wrote:
> On Wed, 2014-11-05 at 06:21 -0800, Guenter Roeck wrote:
> > On Wed, Nov 05, 2014 at 04:45:14PM +0530, Neelesh Gupta wrote:
> > > The current driver probe() function assumes the sensor device to be
> > > alwary present and gets executed every time if the driver is loaded,
> > > but the appropriate hardware could not be present.
> > > 
> > > So, move the platform device creation as part of platform init code
> > > and use the 'id_table' to check if the device present or not.
> > > 
> > > Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
> > 
> > Looks good. We'll need an ack from one of the powerpc maintainers to proceed.
> 
> Looks OK to me.
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> 
Applied to -next.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: benh@au1.ibm.com, michaele@au1.ibm.com,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, jdelvare@suse.de
Subject: Re: [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device
Date: Tue, 11 Nov 2014 10:37:52 -0800	[thread overview]
Message-ID: <20141111183752.GA23539@roeck-us.net> (raw)
In-Reply-To: <1415574297.29291.3.camel@concordia>

On Mon, Nov 10, 2014 at 10:04:57AM +1100, Michael Ellerman wrote:
> On Wed, 2014-11-05 at 06:21 -0800, Guenter Roeck wrote:
> > On Wed, Nov 05, 2014 at 04:45:14PM +0530, Neelesh Gupta wrote:
> > > The current driver probe() function assumes the sensor device to be
> > > alwary present and gets executed every time if the driver is loaded,
> > > but the appropriate hardware could not be present.
> > > 
> > > So, move the platform device creation as part of platform init code
> > > and use the 'id_table' to check if the device present or not.
> > > 
> > > Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
> > 
> > Looks good. We'll need an ack from one of the powerpc maintainers to proceed.
> 
> Looks OK to me.
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> 
Applied to -next.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	jdelvare@suse.de, benh@au1.ibm.com, linux-kernel@vger.kernel.org,
	michaele@au1.ibm.com, linuxppc-dev@lists.ozlabs.org,
	lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device
Date: Tue, 11 Nov 2014 10:37:52 -0800	[thread overview]
Message-ID: <20141111183752.GA23539@roeck-us.net> (raw)
In-Reply-To: <1415574297.29291.3.camel@concordia>

On Mon, Nov 10, 2014 at 10:04:57AM +1100, Michael Ellerman wrote:
> On Wed, 2014-11-05 at 06:21 -0800, Guenter Roeck wrote:
> > On Wed, Nov 05, 2014 at 04:45:14PM +0530, Neelesh Gupta wrote:
> > > The current driver probe() function assumes the sensor device to be
> > > alwary present and gets executed every time if the driver is loaded,
> > > but the appropriate hardware could not be present.
> > > 
> > > So, move the platform device creation as part of platform init code
> > > and use the 'id_table' to check if the device present or not.
> > > 
> > > Signed-off-by: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
> > 
> > Looks good. We'll need an ack from one of the powerpc maintainers to proceed.
> 
> Looks OK to me.
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> 
Applied to -next.

Thanks,
Guenter

  reply	other threads:[~2014-11-11 18:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 11:15 [PATCH v2] hwmon: (ibmpowernv) Use platform 'id_table' to probe the device Neelesh Gupta
2014-11-05 14:21 ` [lm-sensors] " Guenter Roeck
2014-11-05 14:21   ` Guenter Roeck
2014-11-05 14:21   ` Guenter Roeck
2014-11-09 23:04   ` [lm-sensors] " Michael Ellerman
2014-11-09 23:04     ` Michael Ellerman
2014-11-09 23:04     ` Michael Ellerman
2014-11-11 18:37     ` Guenter Roeck [this message]
2014-11-11 18:37       ` Guenter Roeck
2014-11-11 18:37       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111183752.GA23539@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=benh@au1.ibm.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=michaele@au1.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=neelegup@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.